[sr-dev] git:master: modules/tm: new implementation of load_contacts()/next_contacts ()

Alex Hermann alex at speakup.nl
Mon Aug 1 18:05:59 CEST 2011


Juha,

this change broke support for calling t_load_contacts from failure_route. When 
used from failure_route, the current ruri is added again as new branch. Can 
you elaborate on why the relevant code was removed?


Attached patch restores the functionality. Is there anything wrong with this 
fix or shall i commit it?

Alex.




On Friday 28 May 2010 14:43:32 Juha Heinanen wrote:
> Module: sip-router
> Branch: master
> Commit: e973bbe5e7310861f77b17ce0afaf1cca35fe48a
> URL:   
> http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e973bb
> e5e7310861f77b17ce0afaf1cca35fe48a
> 
> Author: Juha Heinanen <jh at tutpro.com>
> Committer: Juha Heinanen <jh at tutpro.com>
> Date:   Fri May 28 15:38:41 2010 +0300
> 
> modules/tm: new implementation of load_contacts()/next_contacts()
> 
> - Simpler implementation of load_contacts()/next_contacts() functions
>   based on recent changes related to Request-URI handling.
> - Function next_contacts() does not anymore set any timers.  Check
>   contact_avp and call t_set_fr() before calling t_relay() instead.
> - Removed fr_timer_next module parameter, because it is not needed
>   anymore.
> 
> ---
> 
>  modules/tm/README            |  255 ++++++++++++++------------------------
>  modules/tm/doc/functions.xml |   51 +++-----
>  modules/tm/doc/params.xml    |   73 -----------
>  modules/tm/doc/tm.xml        |   15 +--
>  modules/tm/t_serial.c        |  279
> ++++++++++++------------------------------ modules/tm/tm.c              | 
>   1 -
>  6 files changed, 190 insertions(+), 484 deletions(-)
> 
> Diff:  
> http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=e9
> 73bbe5e7310861f77b17ce0afaf1cca35fe48a
> 
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

-- 
Alex Hermann
-------------- next part --------------
A non-text attachment was scrubbed...
Name: modules-tm-t_load_contacts-restore-failure_route.diff
Type: text/x-patch
Size: 2599 bytes
Desc: not available
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20110801/52fcbbcc/attachment.bin>


More information about the sr-dev mailing list