[sr-dev] git:master: core:modparam. c In case of a STRING type to STR type convertion, garbage was written

Marius Zbihlei marius.zbihlei at 1and1.ro
Fri Jan 14 17:04:47 CET 2011


Module: sip-router
Branch: master
Commit: 97727e803ec765aff15355dce116454d72cd2323
URL:    http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=97727e803ec765aff15355dce116454d72cd2323

Author: Marius Zbihlei <marius.zbihlei at 1and1.ro>
Committer: Marius Zbihlei <marius.zbihlei at 1and1.ro>
Date:   Fri Jan 14 17:52:52 2011 +0200

core:modparam.c In case of a STRING  type to STR type convertion, garbage was written

The local "s" var was never written, a line was missing.

---

 modparam.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/modparam.c b/modparam.c
index ffc3125..8661b90 100644
--- a/modparam.c
+++ b/modparam.c
@@ -104,6 +104,7 @@ int set_mod_param_regex(char* regex, char* name, modparam_t type, void* val)
 					s.len = s.s ? strlen(s.s) : 0;
 					val2 = &s;
 				} else if (type == PARAM_STR && PARAM_TYPE_MASK(param_type) == PARAM_STRING) {
+					s = *(str*)val;
 					val2 = s.s;	/* zero terminator expected */
 				} else {
 					val2 = val;




More information about the sr-dev mailing list