[sr-dev] [tracker] Comment added: Kamailio hangs on start after dialog module reads variables from database

[sip-router]

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#171 - Kamailio hangs on start after dialog module reads variables from database
User who did this - Daniel-Constantin Mierla (miconda)

----------
I think is due to a wrong continue in the inner while(dlg) -- imo it should be a break:

diff --git a/modules_k/dialog/dlg_db_handler.c b/modules_k/dialog/dlg_db_handler.c
index c0b8fbc..a9b38ef 100644
--- a/modules_k/dialog/dlg_db_handler.c
+++ b/modules_k/dialog/dlg_db_handler.c
@@ -527,7 +527,7 @@ static int load_dialog_vars_from_db(int fetch_num_rows)
                                while (dlg) {
                                        if (dlg->h_id == VAL_INT(values+1)) {
                                                set_dlg_variable_unsafe(dlg, &VAL_STR(values+2), &VAL_STR(values+3));
-                                               continue;
+                                               break;
                                        }
                                        dlg = dlg->next;
                                        if (!dlg) {
----------

More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=171#comment320

You are receiving this message because you have requested it from the Flyspray bugtracking system.  If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.