[sr-dev] git:master: snmpstats: control exporting registrar records

[Daniel-Constantin Mierla]

Hello,

On 10/31/11 8:10 AM, Klaus Darilion wrote:
> Hi Daniel!
>
> I think there is a minor copy-paste bug in snmpstats.c, the function 
> is exported twice:
>
>  155         { "snmpCommunity",          STR_PARAM|USE_FUNC_PARAM,
>  156                         (void *)set_snmp_community        },
>  157         { "snmpCommunity",          STR_PARAM|USE_FUNC_PARAM,
>  158                         (void *)set_snmp_community        },
indeed, it was a duplicated module parameter exported twice. Such thing 
is completely harmless, anyhow, I committed to git a patch to remove one.

Thanks,
Daniel
>
>
> regards
> Klaus
>
> On 16.10.2011 11:43, Daniel-Constantin Mierla wrote:
>> Module: sip-router
>> Branch: master
>> Commit: 0696af54dac4ecc53bb0a9dc4e56da11bc3f2b30
>> URL:    
>> http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0696af54dac4ecc53bb0a9dc4e56da11bc3f2b30
>>
>> Author: Daniel-Constantin Mierla<miconda at gmail.com>
>> Committer: Daniel-Constantin Mierla<miconda at gmail.com>
>> Date:   Sun Oct 16 11:33:16 2011 +0200
>>
>> snmpstats: control exporting registrar records
>>
>> - exporting of large location database may result in out of shared
>>    memory, as well as when the records are not pulled - might be the 
>> case
>>    of out of memory messages reported by Klaus Darilion
>> - new parameter export_registrar was added to enable/disable location
>>    records export (off by default)
>> - fixed missing exporting the counter with all processed dialogs
>>    (discussion from March 2011 with Stefan Tiedje)
>>
>> ---
>>
>>   modules_k/snmpstats/README                  |   31 
>> ++++++++++++++++-----
>>   modules_k/snmpstats/doc/snmpstats_admin.xml |   25 +++++++++++++++++
>>   modules_k/snmpstats/mibs/OPENSER-MIB        |   13 ++++++++-
>>   modules_k/snmpstats/snmpObjects.c           |   28 +++++++++++++++++++
>>   modules_k/snmpstats/snmpObjects.h           |    1 +
>>   modules_k/snmpstats/snmpstats.c             |   40 
>> +++++++++++++++++----------
>>   6 files changed, 115 insertions(+), 23 deletions(-)
>>
>> Diff:   
>> http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=0696af54dac4ecc53bb0a9dc4e56da11bc3f2b30
>>
>> _______________________________________________
>> sr-dev mailing list
>> sr-dev at lists.sip-router.org
>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

-- 
Daniel-Constantin Mierla -- http://www.asipto.com
Kamailio Advanced Training, Dec 5-8, Berlin: http://asipto.com/u/kat
http://linkedin.com/in/miconda -- http://twitter.com/miconda