[sr-dev] mem leak in sdpops

[Daniel-Constantin Mierla]

Hello,

I missed the commit of that functions, was done by Peter Dunkley, I had 
in mind to add a PV to return the sdp body and other attributes.

You can commit the second patch, the one without pkg_malloc()/_free(), 
because avps duplicate the value in shared memory, cloning in pkg first 
makes no difference.

Cheers,
Daniel

On 8/31/12 2:07 PM, Vicente Hernando wrote:
> Sorry, previous attachment did not work.
>
> On 08/31/2012 02:06 PM, Vicente Hernando wrote:
>> Hello,
>>
>> within w_get_sdp function in modules/sdpops/sdpops_mod.c
>>
>>     } else {
>>         avp_val.s.s = pkg_malloc(sdp->raw_sdp.len);
>>         avp_val.s.len = sdp->raw_sdp.len;
>>         if (avp_val.s.s == NULL)
>>
>> I do not find anywhere where avp_val.s.s variable is freed.
>>
>>
>> So I attach two possible patches to solve that in two different ways.
>>
>> Kind regards,
>> Vicente.
>>
>> _______________________________________________
>> sr-dev mailing list
>> sr-dev at lists.sip-router.org
>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>>
>
>
>
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

-- 
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio Advanced Training, Berlin, Nov 5-8, 2012 - http://asipto.com/u/kat

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20120905/4e694141/attachment-0001.htm>