[sr-dev] [kamailio] modules/websocket: ensure linkage to libcrypto (#439)

Andrey Utkin notifications at github.com
Sat Dec 12 21:50:12 CET 2015


Fixes linkage for Ubuntu Wily (15.10).
The issue manifests itself as "undefined symbol: SHA1" error at module loading.

In Ubuntu 14 LTS (Trusty), ```pkg-config --libs libssl``` returns ```-lssl -lcrypto```, but in Ubuntu 15.10 (Wily) it returns only ```-lssl```. In the end, websocket.so gets SHA1 symbol (and some more) unresolved.

For unclear reason, this change is not needed for tls.so - it gets linked to libcrypto automatically, despite it is linked only with ```-lssl``` flag. Maybe it is something symbol-specific, or something I am completely unaware of.

SSL_BUILDER stuff in Makefile seems to become even more mostruous with the proposed change. Keep in mind that there is ~5 more modules with identical construction in their Makefiles. Rejection of this patch in favor of cleaner solution is appreciated.
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/439

-- Commit Summary --

  * modules/websocket: ensure linkage to libcrypto

-- File Changes --

    M modules/websocket/Makefile (6)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/439.patch
https://github.com/kamailio/kamailio/pull/439.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/439
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20151212/26858d12/attachment.html>


More information about the sr-dev mailing list