[sr-dev] [kamailio] UAC module - registration stuck in ONGOING state (does not retry) (#255)

[AndyJRobinson]

The only other thing going on at the time (before 23:18:40 and between 23:18:40 and 23:24:40) was some registrations (I have kamailio set up as a registrar), so I eliminated the log messages associated with those for brevity. The local patch that I've applied to log the message and keep things going is:

--- a/modules/uac/uac_reg.c	2015-07-13 10:55:13.596283423 -0400
+++ b/modules/uac/uac_reg.c	2015-07-13 10:57:09.301555783 -0400
@@ -929,7 +929,10 @@
 	if(reg->expires==0)
 		return 1;
 	if(reg->flags&UAC_REG_ONGOING)
-		return 2;
+		if (reg->timer_expires > tn - reg_retry_interval)
+			return 2;
+		else
+			LM_ERR("ONGOING flag still set");
 	if(reg->flags&UAC_REG_DISABLED)
 		return 4;
 	if(reg->timer_expires > tn + reg_timer_interval + 3)
@@ -942,7 +945,7 @@
 	}
 	reg->timer_expires = tn;
 	reg->flags |= UAC_REG_ONGOING;
-	reg->flags &= ~UAC_REG_ONLINE;
+	reg->flags &= ~(UAC_REG_ONLINE|UAC_REG_AUTHSENT);
 	counter_add(regactive, -1);		/* Take it out of the active pool while re-registering */
 	memcpy(uuid, reg->l_uuid.s, reg->l_uuid.len);
 	uuid[reg->l_uuid.len] = '\0';

---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/255#issuecomment-122951498
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20150720/89b190ae/attachment.html>