[sr-dev] [kamailio] P-Charging-Vector handling as RFC3455 (#215)

[Daniel-Constantin Mierla]

Is this patch storing something new in accounting record (eg., storing something new in acc database table)?

If not and it is only about SIP header management, then might be better to relocate the code to siputils module. Acc is intended to be the connector to write records to a backend.

Some remarks:

  * change to be a single class of variables: $pcv(name) - having like: $pcv(full), $pcv(value), $pcv(genaddr) -- it is more compact and adding new fields in the future will fit better
  * use commit message format as suggested at: http://www.kamailio.org/wiki/devel/git-commit-guidelines#commit_message

---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/215#issuecomment-113422700
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20150619/954612c9/attachment.html>