<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<br>
On 7/27/11 11:07 AM, Andrew Miller wrote:
<blockquote cite="mid:4E2FD54F.5040700@crocodile-rcs.com"
type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<span>Daniel,<br>
<br>
</span>The value in the structure (tcp_options.c line 117) is not
a default, it is a maximum. If this is not increased then setting
<span>tcp_rd_buf_size > 64K has no effect; it truncates to
65536. <br>
<br>
The default (DEFAULT_TCP_BUF_SIZE tcp_init.h line 42) remains at
4069.</span><span></span><br>
</blockquote>
Right, the cfg framework has min/max limits for integers. I
misinterpreted the commit log.<br>
<br>
Thanks,<br>
Daniel<br>
<br>
<blockquote cite="mid:4E2FD54F.5040700@crocodile-rcs.com"
type="cite"> <br>
Andy<br>
<br>
<blockquote
cite="mid:40E1439B-4AE6-4055-B9A3-EE16A7B8BA65@crocodile-rcs.com"
type="cite">
<blockquote type="cite">
<div><b>From:</b> Daniel-Constantin Mierla <<a
moz-do-not-send="true" href="mailto:miconda@gmail.com">miconda@gmail.com</a>><br>
<b>Date:</b> 27 July 2011 08:56:10 GMT+01:00<br>
<b>To:</b> Development mailing list of the sip-router
project <<a moz-do-not-send="true"
href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a>><br>
<b>Cc:</b> Peter Dunkley <<a moz-do-not-send="true"
href="mailto:peter.dunkley@crocodile-rcs.com">peter.dunkley@crocodile-rcs.com</a>><br>
<b>Subject:</b> <b>Re: [sr-dev] git:master: core: support
for receiving requests > 64kb on TCP</b><br>
<b>Reply-To:</b> <a moz-do-not-send="true"
href="mailto:miconda@gmail.com">miconda@gmail.com</a><br>
<br>
</div>
</blockquote>
<blockquote type="cite">
<div><span>Hello,</span><br>
<span></span><br>
<span>If I haven't missed the purpose, this commit is not
necessary. Having the default value very big is not common
in usual scenarios and the value can be changed via global
parameter:</span><br>
<span><a moz-do-not-send="true"
href="http://www.kamailio.org/dokuwiki/doku.php/core-cookbook:3.1.x#tcp_rd_buf_size">http://www.kamailio.org/dokuwiki/doku.php/core-cookbook:3.1.x#tcp_rd_buf_size</a></span><br>
<span></span><br>
<span>tcp_rd_buf_size=16777216</span><br>
<span></span><br>
<span>It should be set back to 64k unless the issue is
something else.</span><br>
<span></span><br>
<span>Cheers,</span><br>
<span>Daniel</span><br>
<span></span><br>
<span></span><br>
<span></span><br>
<span>On 7/25/11 11:55 AM, Peter Dunkley wrote:</span><br>
<blockquote type="cite"><span>Module: sip-router</span><br>
</blockquote>
<blockquote type="cite"><span>Branch: master</span><br>
</blockquote>
<blockquote type="cite"><span>Commit:
3c9a176bac4878983d324ce82354cd844b916373</span><br>
</blockquote>
<blockquote type="cite"><span>URL: <a
moz-do-not-send="true"
href="http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3c9a176bac4878983d324ce82354cd844b916373">http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3c9a176bac4878983d324ce82354cd844b916373</a></span><br>
</blockquote>
<blockquote type="cite"><span></span><br>
</blockquote>
<blockquote type="cite"><span>Author: pd<<a
moz-do-not-send="true"
href="mailto:peter.dunkley@crocodile-rcs.com">peter.dunkley@crocodile-rcs.com</a>></span><br>
</blockquote>
<blockquote type="cite"><span>Committer: pd<<a
moz-do-not-send="true"
href="mailto:peter.dunkley@crocodile-rcs.com">peter.dunkley@crocodile-rcs.com</a>></span><br>
</blockquote>
<blockquote type="cite"><span>Date: Mon Jul 25 10:53:10
2011 +0100</span><br>
</blockquote>
<blockquote type="cite"><span></span><br>
</blockquote>
<blockquote type="cite"><span>core: support for receiving
requests> 64kb on TCP</span><br>
</blockquote>
<blockquote type="cite"><span></span><br>
</blockquote>
<blockquote type="cite"><span>- Issue found and fixed by
Andrew Miller at Crocodile RCS</span><br>
</blockquote>
<blockquote type="cite"><span></span><br>
</blockquote>
<blockquote type="cite"><span>---</span><br>
</blockquote>
<blockquote type="cite"><span></span><br>
</blockquote>
<blockquote type="cite"><span> tcp_options.c | 2 +-</span><br>
</blockquote>
<blockquote type="cite"><span> 1 files changed, 1
insertions(+), 1 deletions(-)</span><br>
</blockquote>
<blockquote type="cite"><span></span><br>
</blockquote>
<blockquote type="cite"><span>diff --git a/tcp_options.c
b/tcp_options.c</span><br>
</blockquote>
<blockquote type="cite"><span>index 734f9fb..122965a 100644</span><br>
</blockquote>
<blockquote type="cite"><span>--- a/tcp_options.c</span><br>
</blockquote>
<blockquote type="cite"><span>+++ b/tcp_options.c</span><br>
</blockquote>
<blockquote type="cite"><span>@@ -114,7 +114,7 @@ static
cfg_def_t tcp_cfg_def[] = {</span><br>
</blockquote>
<blockquote type="cite"><span> "accept TCP messges
without Content-Lenght "},</span><br>
</blockquote>
<blockquote type="cite"><span> /* internal and/or
"fixed" versions of some vars</span><br>
</blockquote>
<blockquote type="cite"><span> (not supposed to be
writeable, read will provide only debugging value*/</span><br>
</blockquote>
<blockquote type="cite"><span>- { "rd_buf_size",
CFG_VAR_INT | CFG_ATOMIC, 512, 65536, 0,
0,</span><br>
</blockquote>
<blockquote type="cite"><span>+ { "rd_buf_size",
CFG_VAR_INT | CFG_ATOMIC, 512, 16777216, 0,
0,</span><br>
</blockquote>
<blockquote type="cite"><span> "internal read
buffer size (should be> max. expected datagram)"},</span><br>
</blockquote>
<blockquote type="cite"><span> { "wq_blk_size",
CFG_VAR_INT | CFG_ATOMIC, 1, 65535, 0, 0,</span><br>
</blockquote>
<blockquote type="cite"><span> "internal async
write block size (debugging use only for now)"},</span><br>
</blockquote>
<blockquote type="cite"><span></span><br>
</blockquote>
<blockquote type="cite"><span></span><br>
</blockquote>
<blockquote type="cite"><span>_______________________________________________</span><br>
</blockquote>
<blockquote type="cite"><span>sr-dev mailing list</span><br>
</blockquote>
<blockquote type="cite"><span><a moz-do-not-send="true"
href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a></span><br>
</blockquote>
<blockquote type="cite"><span><a moz-do-not-send="true"
href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a></span><br>
</blockquote>
<span></span><br>
<span>-- </span><br>
<span>Daniel-Constantin Mierla -- <a moz-do-not-send="true"
href="http://www.asipto.com">http://www.asipto.com</a></span><br>
<span>Kamailio Advanced Training, Oct 10-13, Berlin: <a
moz-do-not-send="true" href="http://asipto.com/u/kat">http://asipto.com/u/kat</a></span><br>
<span><a moz-do-not-send="true"
href="http://linkedin.com/in/miconda">http://linkedin.com/in/miconda</a>
-- <a moz-do-not-send="true"
href="http://twitter.com/miconda">http://twitter.com/miconda</a></span><br>
<span></span><br>
</div>
</blockquote>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
sr-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a>
<a class="moz-txt-link-freetext" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla -- <a class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a>
Kamailio Advanced Training, Oct 10-13, Berlin: <a class="moz-txt-link-freetext" href="http://asipto.com/u/kat">http://asipto.com/u/kat</a>
<a class="moz-txt-link-freetext" href="http://linkedin.com/in/miconda">http://linkedin.com/in/miconda</a> -- <a class="moz-txt-link-freetext" href="http://twitter.com/miconda">http://twitter.com/miconda</a></pre>
</body>
</html>