<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello,<br>
<br>
you are right.<br>
<br>
The tool I used to compare the databases structures and get the SQL
statements for upgrade seems to be buggy for text columns, it gave
the result:<br>
<br>
ALTER TABLE silo ADD COLUMN extra_hdrs text NOT NULL;<br>
<br>
But in kamctl the definition is with DEFAULT ''<br>
<br>
Thanks,<br>
Daniel<br>
<br>
On 5/4/12 11:57 AM, Hugh Waite wrote:
<blockquote cite="mid:4FA3A7EC.4020909@crocodile-rcs.com"
type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Hello,<br>
The current definition of the extra_hdrs is:<br>
<small><tt> <column><br>
<name>extra_hdrs</name><br>
<type>text</type><br>
<default/><br>
<description>Extra headers that must be
restored</description><br>
</column><br>
</tt></small>which results in<br>
<tt>extra_hdrs TEXT DEFAULT '' NOT NULL</tt><br>
in mysql and postgres. This has a default value. Do you think it
should have both a default and be allowed to be NULL?<br>
<br>
Regards,<br>
Hugh<br>
<br>
<br>
On 04/05/2012 08:40, Daniel-Constantin Mierla wrote:
<blockquote cite="mid:4FA387E6.7040007@gmail.com" type="cite">Hello,
<br>
<br>
looking at changes in the database structure from 3.2 to 3.3, I
noticed the columns in active_watchers/rls_watches that have no
default value and cannot be NULL. <br>
<br>
The usual issue with this kind of upgrades is that existing rows
have to be removed. active_watchers is with temporary records,
and I guess that is the same with rls_watchers. No persistent
data is to be lost, right? <br>
<br>
Another one is extra_hdrs in silo table. I think it should be
allowed to be NULL or default '' (empty string), so stored
messages will not be lost - the check over the code showed
inserting '' if no extra headers are present at message storage
time. <br>
<br>
Cheers, <br>
Daniel <br>
<br>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Hugh Waite
Senior Design Engineer
Crocodile RCS Ltd.</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla - <a class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a>
<a class="moz-txt-link-freetext" href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a> - <a class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a></pre>
</body>
</html>