<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Can you provide the patch taken with 'diff -u' or 'git diff' -- it
is easier to understand what parts you refer to and were updated.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<div class="moz-cite-prefix">On 9/27/12 12:31 AM, Jijo wrote:<br>
</div>
<blockquote
cite="mid:CAOYmDE_yANfRFv8b1VzR=CbtgSRxd0GMsYqQBK-UzS1XHQbosg@mail.gmail.com"
type="cite">Hello,
<div><br>
</div>
<div>I'm observing that Via Header domain name of type SRV is
resolving as DNS A. </div>
<div><br>
</div>
<div>I looked at the code and it does support only A. It is
basically setting to default SIP port
check_via_address which is causing DNS A query.</div>
<div><br>
</div>
<div>Is there any specific reason to do so?</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div>I changed the code to support SRV as below and working fine.</div>
<div><br>
</div>
<div>
<div>static int check_via_address(struct ip_addr* ip, str *name,</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>unsigned
short port, <b><font color="#006600">short proto</font></b>,
int resolver)</div>
<div>{</div>
</div>
<div>:<br>
:<br>
<div><span style="background-color:rgb(255,102,102)"><span
class="Apple-tab-span" style="white-space:pre"> </span>//if
(port==0) port=SIP_PORT;</span></div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>if
(resolver&DO_DNS){</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>DBG("check_via_address:
doing dns lookup\n");</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>/*
try all names ips */</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>he=sip_resolvehost(name,
&port,<font color="#009900"> <b>(char *) &proto</b></font>);
/* don't use naptr */</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>if
(he && ip->af==he->h_addrtype){</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>for(i=0;he
&& he->h_addr_list[i];i++){</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>if
( memcmp(&he->h_addr_list[i], ip->u.addr,
ip->len)==0)</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>return
0;</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>}</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>}</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>}</div>
</div>
<div>:</div>
<div>:</div>
<div>:</div>
<div>}</div>
<div><br>
</div>
<div><br>
</div>
<div>
<div>/* check if IP address in Via != source IP address of
signaling */</div>
<div>int received_test( struct sip_msg *msg )</div>
<div>{</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>int
rcvd;</div>
<div><br>
</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>rcvd=msg->via1->received</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>||
check_via_address(&msg->rcv.src_ip,
&msg->via1->host,</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>msg->via1->port,<b> <font
color="#006600">msg->via1->proto</font></b>, received_dns);</div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span>return
rcvd;</div>
<div>}</div>
</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div>Thanks</div>
<div>Jijo</div>
<div><br>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
sr-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a>
<a class="moz-txt-link-freetext" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla - <a class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a>
<a class="moz-txt-link-freetext" href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a> - <a class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a>
Kamailio Advanced Training, Berlin, Nov 5-8, 2012 - <a class="moz-txt-link-freetext" href="http://asipto.com/u/kat">http://asipto.com/u/kat</a>
Kamailio Advanced Training, Miami, USA, Nov 12-14, 2012 - <a class="moz-txt-link-freetext" href="http://asipto.com/u/katu">http://asipto.com/u/katu</a></pre>
</body>
</html>