Sure, done, see 02_better_printing_stacktrace.diff attached.<br><br><br><div class="gmail_quote">2012/12/4 Ovidiu Sas <span dir="ltr"><<a href="mailto:osas@voipembedded.com" target="_blank">osas@voipembedded.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello Konstantin,<br>
<br>
I applied the first patch. Thank you.<br>
For the second patch, I would like to use the internal kamailio memory<br>
manager: pkg_malloc and pkg_realloc instead of calloc and realloc.<br>
Could you please rework the second patch and test?<br>
<br>
Thanks,<br>
Ovidiu<br>
<div class="HOEnZb"><div class="h5"><br>
On Mon, Dec 3, 2012 at 6:14 PM, Konstantin M. <<a href="mailto:evilzluk@gmail.com">evilzluk@gmail.com</a>> wrote:<br>
> Hello Ovidiu Sas,<br>
> Sure, I just removed this, see 01_expand_log_facilities.diff attached.<br>
> Also I changed a printing of stack trace (see<br>
> 02_better_printing_stacktrace.diff) according to standard python's<br>
> traceback.<br>
><br>
> Example of old printing:<br>
> 0(4842) ERROR: app_python [python_support.c:38]: python_exec2: Unhandled<br>
> exception in the Python code:<br>
> 0(4842) ERROR: app_python [python_support.c:78]: Traceback (most<br>
> recent call last):<br>
> 0(4842) ERROR: app_python [python_support.c:78]: File<br>
> "/opt/kamailio/python/Kam-Loggers.py", line 34, in BuggyCode<br>
> return self.BuggyCode_lvl2(a)<br>
> 0(4842) ERROR: app_python [python_support.c:78]: File<br>
> "/opt/kamailio/python/Kam-Loggers.py", line 31, in BuggyCode_lvl2<br>
> return self.BuggyCode_lvl3(a)<br>
> 0(4842) ERROR: app_python [python_support.c:78]: File<br>
> "/opt/kamailio/python/Kam-Loggers.py", line 28, in BuggyCode_lvl3<br>
> return self.BuggyCode_lvl4(a)<br>
> 0(4842) ERROR: app_python [python_support.c:78]: File<br>
> "/opt/kamailio/python/Kam-Loggers.py", line 25, in BuggyCode_lvl4<br>
> return self.BuggyCode_lvl5(a)<br>
> 0(4842) ERROR: app_python [python_support.c:78]: File<br>
> "/opt/kamailio/python/Kam-Loggers.py", line 22, in BuggyCode_lvl5<br>
> a / 0<br>
> 0(4842) ERROR: app_python [python_support.c:78]: TypeError:<br>
> unsupported operand type(s) for /: 'Router.msg' and 'int'<br>
><br>
><br>
> Example of new printing:<br>
> 0(4753) ERROR: app_python [python_support.c:95]: python_exec2: Unhandled<br>
> exception in the Python code:<br>
> Traceback (most recent call last):<br>
> File "/opt/kamailio/python/Kam-Loggers.py", line 34, in BuggyCode<br>
> return self.BuggyCode_lvl2(a)<br>
> File "/opt/kamailio/python/Kam-Loggers.py", line 31, in BuggyCode_lvl2<br>
> return self.BuggyCode_lvl3(a)<br>
> File "/opt/kamailio/python/Kam-Loggers.py", line 28, in BuggyCode_lvl3<br>
> return self.BuggyCode_lvl4(a)<br>
> File "/opt/kamailio/python/Kam-Loggers.py", line 25, in BuggyCode_lvl4<br>
> return self.BuggyCode_lvl5(a)<br>
> File "/opt/kamailio/python/Kam-Loggers.py", line 22, in BuggyCode_lvl5<br>
> a / 0<br>
> TypeError: unsupported operand type(s) for /: 'Router.msg' and 'int'<br>
><br>
><br>
><br>
> 2012/12/4 Ovidiu Sas <<a href="mailto:osas@voipembedded.com">osas@voipembedded.com</a>><br>
>><br>
>> Hello Konstantin,<br>
>><br>
>> I would be happy to commit your patch, but I would like to ask you to<br>
>> remove, for now, the conditional FLAVOUR compilation.<br>
>> You could leave the module name as "Router" for now.<br>
>> Can you generate an new patch file without FLAVOUR?<br>
>><br>
>> Regards,<br>
>> Ovidiu Sas<br>
>><br>
>> On Mon, Dec 3, 2012 at 2:50 PM, Konstantin M. <<a href="mailto:evilzluk@gmail.com">evilzluk@gmail.com</a>> wrote:<br>
>> > Hi Dev,<br>
>> ><br>
>> > Modified app_python:<br>
>> ><br>
>> > 1) Added FLAVOUR support<br>
>> > 2) Added python objects:<br>
>> ><br>
>> > Module Properties:<br>
>> > Log Levels:<br>
>> > L_ALERT<br>
>> > L_BUG<br>
>> > L_CRIT2<br>
>> > L_CRIT<br>
>> > L_ERR<br>
>> > L_WARN<br>
>> > L_NOTICE<br>
>> > L_INFO<br>
>> > L_DBG<br>
>> ><br>
>> > Log Facilities:<br>
>> > DEFAULT_FACILITY<br>
>> ><br>
>> > Module Methods:<br>
>> > LM_GEN1(self, int log_level, str msg)<br>
>> > LM_GEN2(self, int log_facility, int log_level, str msg)<br>
>> > LM_ALERT(self, str msg)<br>
>> > LM_CRIT(self, str msg)<br>
>> > LM_ERR(self, str msg)<br>
>> > LM_WARN(self, str msg)<br>
>> > LM_NOTICE(self, str msg)<br>
>> > LM_INFO(self, str msg)<br>
>> > LM_DBG(self, str msg)<br>
>> ><br>
<br>
_______________________________________________<br>
sr-dev mailing list<br>
<a href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a><br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
</div></div></blockquote></div><br>