<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello,<br>
<br>
ok, if the tests went fine then you can merge the patches to the
master branch. I will test it from there in short time.<br>
<br>
Thanks,<br>
Daniel<br>
<br>
<div class="moz-cite-prefix">On 12/16/12 1:28 PM, MÉSZÁROS Mihály
wrote:<br>
</div>
<blockquote cite="mid:50CDBE71.2060105@niif.hu" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Hi Daniel,<br>
<br>
You have absolutely right, it has to be tested it without cache. <br>
I thought someone is using it that way and will help to test it,
anyhow I made the test myself now.<br>
<br>
I have tested sip-router without DNS CACHE and after this
correction:<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://git.sip-router.org/cgi-bin/gitweb.cgi?p=sip-router;a=commitdiff;h=7ce7d6413b45e7e9df190167e7faba8c10f96492">http://git.sip-router.org/cgi-bin/gitweb.cgi?p=sip-router;a=commitdiff;h=7ce7d6413b45e7e9df190167e7faba8c10f96492</a><br>
<br>
Now it seems to be working correctly. <br>
So I tested it, and i couldn't experience any issue with it.<br>
<br>
It will be more safe if others (like IBC,Klauss) can apply it to
any testing baranch and confirm that they have no issue with it.<br>
<br>
If you want to Test it yourself i can wait for the next major
release. <br>
(After it please merge it to master.)<br>
<br>
Many Thanks,<br>
Misi<br>
<br>
On 2012-12-10 10:26, Daniel-Constantin Mierla wrote:
<blockquote cite="mid:50C5AAD9.8090403@gmail.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Hello,<br>
<br>
one thing keeps it back for now - you said that you didn't
tested without cache. So that has to be reviewed as well, it is
a patch for core and cannot be overlooked. If you can test it
and report the results, then it can speed up. For me it will
take a bit of time to get to testing it, but I will before the
next major release.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<br>
<div class="moz-cite-prefix">On 12/10/12 9:37 AM, MÉSZÁROS
Mihály wrote:<br>
</div>
<blockquote cite="mid:50C59F4D.8070808@niif.hu" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Hi All,<br>
<br>
Any other issue or comment or request for correction?<br>
When can i expect to submit it to master tree?<br>
<br>
Thanks,<br>
Misi<br>
<br>
On 2012-12-05 13:07, MÉSZÁROS Mihály wrote:
<blockquote cite="mid:50BF38EC.7010504@niif.hu" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Hi Daniel <br>
<br>
I wrote in my first patch announcing email, that i didn't
test the patched dns resolution without cache.<br>
I only tested with dns cache.<br>
<br>
This is the reason why i didn't recognize this problem.<br>
You are right I made a mistake, but now it is corrected.<br>
<br>
Many Thanks,<br>
Misi<br>
<br>
On 2012-12-04 17:47, Daniel-Constantin Mierla wrote:
<blockquote cite="mid:50BE2914.3050802@gmail.com"
type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Hello,<br>
<br>
I was looking to the patch and I spotted that you didn't
assign anymore a value to he variable -- next is the
specific part of the diff:<br>
<br>
- /* fallback to normal srv lookup */<br>
- he=srv_sip_resolvehost(name, 0, port, proto, 0,
0);<br>
+ /* fallback to srv lookup */<br>
+ no_naptr_srv_sip_resolvehost(name,port,proto);<br>
<br>
Shouldn't be like: he =
no_naptr_srv_sip_resolvehost(name,port,proto);<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<div class="moz-cite-prefix">On 11/30/12 10:31 AM,
MÉSZÁROS Mihály wrote:<br>
</div>
<blockquote cite="mid:50B87D00.9090302@niif.hu"
type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Hi,<br>
<br>
On 2012-11-30 09:07, Daniel-Constantin Mierla wrote:
<blockquote cite="mid:50B86929.5050901@gmail.com"
type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Hello,<br>
<br>
<div class="moz-cite-prefix">On 11/19/12 10:18 AM,
MÉSZÁROS Mihály wrote:<br>
</div>
<blockquote cite="mid:50A9F96D.9020701@niif.hu"
type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Hi Daniel,<br>
<br>
On 2012-11-14 12:51, Daniel-Constantin Mierla wrote:
<blockquote cite="mid:50A385DD.7080300@gmail.com"
type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Hello,<br>
<br>
<div class="moz-cite-prefix">On 11/12/12 10:50 AM,
MÉSZÁROS Mihály wrote:<br>
</div>
<blockquote cite="mid:50A11AE2.5040305@niif.hu"
type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Hi,<br>
<br>
I made some progress. As I stated before, I made
a patch and submitted to git branch
misi/dns_srv.<br>
I tested with dns cache. It works for me.<br>
<br>
I made it also available for case if "no dns
cache" is used too,<br>
but it isn't tested yet.<br>
<br>
Please review my commit, and let me know if any
corrections needed. <br>
</blockquote>
if nobody does it meanwhile, I can look over it
next week and also check properly what's all about
this discussion, currently being out of the
office.<br>
<br>
</blockquote>
After you had time to review it, please let me know
your thoughts.<br>
</blockquote>
unfortunately I had no time to look at it yet.
Hopefully I will find some soon.<br>
<br>
Btw, is it complete? IIRC, I saw something like it
still has to be extended.<br>
<br>
</blockquote>
It is complete and working patch. <br>
If there are no NAPTR records to a domain, then
according to the local protocol preference it orders
protocols and it tries to resolve SRV records according
this ordered list. If there is no order then the order
is udp,tcp,tls,sctp,..<br>
<br>
SRV records are resolved in order Kamailio dns protocol
preference. <br>
My algorithm picks and returns with the first protocol
resolvable SRV record, so it sets from SRV the port and
protocol.<br>
(Of course if there are no SRV at all then it fallbacks
to host resolving so dns "A" record.)<br>
<br>
It is big step forward comparing to current Kamailio
behavior where it is using strictly udp only and after
it stops searching SRV records at all, and go for "A"
record!<br>
<br>
As i wrote in my patch announcing email it is a step
further on the way to conforming with RFC3263, but my
patch not handling fallback if there are SRV-s for
multiple protocols in DNS. <br>
In such case only and only if the first protocol is
temporary not available or fails we are not falling back
to other protocol but falling back to host resolving so
"A" record (and/or AAAA).<br>
<br>
Can you send meg the iirc message what was there
exactly? <br>
Is there any other problem in it?<br>
I guess no just what i explained above.<br>
<br>
I am eagerly waiting your review and comment.<br>
<br>
Thanks in advance!<br>
Misi<br>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla - <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://twitter.com/#%21/miconda">http://twitter.com/#!/miconda</a> - <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a></pre>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
sr-dev mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a>
</pre>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
sr-dev mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla - <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://twitter.com/#%21/miconda">http://twitter.com/#!/miconda</a> - <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a></pre>
</blockquote>
<br>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla - <a class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a>
<a class="moz-txt-link-freetext" href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a> - <a class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a></pre>
</body>
</html>