<div dir="ltr">Hi Olle, <div><br></div><div style>I just checked and this code is not in master branch (I assumed you were referring to master). You are obv. looking at my Ro branch. You can be sure that the duplication won't end up in master ;) - my private branch will be totally clean before merging. Right now however, my Ro branch is still new and incorporates code I wrote almost 2 years ago - so cleaning will come - but thanks for the heads-up</div>
<div style><br></div><div style>Cheers</div><div style>Jason </div><div style><br></div><div style>Cheers</div><div style>Jason</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Mar 12, 2013 at 3:25 PM, Jason Penton <span dir="ltr"><<a href="mailto:jason.penton@gmail.com" target="_blank">jason.penton@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks Olle,<div><br></div><div>It's one of the things we know about. The IMS library can be de-duped in a few areas but right now we are still concentrating on bug fixes and new features. Will clean when and as we have time. Of course the community is welcome to help out too when these things are spotted. For example this change probably would have been quicker to do than for the two of us to waste time on emails ;-)</div>
<div><br></div><div>cheers</div><span class="HOEnZb"><font color="#888888"><div>Jason</div></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Mar 12, 2013 at 3:18 PM, Olle E. Johansson <span dir="ltr"><<a href="mailto:oej@edvina.net" target="_blank">oej@edvina.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><div>12 mar 2013 kl. 14:16 skrev Jason Penton <<a href="mailto:jason.penton@gmail.com" target="_blank">jason.penton@gmail.com</a>>:</div>
<div><br><blockquote type="cite"><div dir="ltr">Thanks for volunteering to clean out for us Olle ;)</div></blockquote></div>You wish ;-)</div><div>In this case you added a function that must exist somewhere else, since I can find headers</div>
<div>in the config scripts... That should definitely be avoided...</div><span><font color="#888888"><div><br></div></font></span><div><span><font color="#888888">/O</font></span><div><div>
<br><blockquote type="cite"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 12, 2013 at 2:39 PM, Richard Good <span dir="ltr"><<a href="mailto:richard.good@smilecoms.com" target="_blank">richard.good@smilecoms.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi<br><br>Agreed on this - historically large parts of the IMS module code comes from the FOKUS Open Source IMS Core which I think started as an IMS specific SER branch.<br>
<br>The purpose of these new modules is to enable this same IMS functionality but take advantage of Kamailio's proven reliability and core functionality. Some functions, like the one you mentioned, still need to be reworked.<br>
<br>Regards<br>Richard.<div><div><br><br><br><div class="gmail_quote">On 12 March 2013 14:18, Olle E. Johansson <span dir="ltr"><<a href="mailto:oej@edvina.net" target="_blank">oej@edvina.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
12 mar 2013 kl. 12:31 skrev Jason Penton <<a href="mailto:jason.penton@gmail.com" target="_blank">jason.penton@gmail.com</a>>:<br>
<div><br>
> +/**<br>
> + * Returns the first header structure for a given header name.<br>
> + * @param msg - the SIP message to look into<br>
> + * @param header_name - the name of the header to search for<br>
> + * @returns the hdr_field on success or NULL if not found<br>
> + */<br>
> +struct hdr_field* cscf_get_header(struct sip_msg * msg, str header_name) {<br>
> + struct hdr_field *h;<br>
> + if (parse_headers(msg, HDR_EOH_F, 0) < 0) {<br>
> + LM_ERR("cscf_get_path: error parsing headers\n");<br>
> + return NULL ;<br>
> + }<br>
> + h = msg->headers;<br>
> + while (h) {<br>
> + if (h->name.len == header_name.len<br>
> + && strncasecmp(h->name.s, header_name.s, header_name.len) == 0)<br>
> + break;<br>
> + h = h->next;<br>
> + }<br>
> + return h;<br>
> +}<br>
> +<br>
<br>
</div>Just a small philosophical note. I think we should be careful not to rebuild Kamailio in a specific "IMS" version.<br>
<br>
Generic functions like this one doesn't belong in the IMS library, it should exist (and maybe does) in the<br>
core libraries.<br>
<br>
Let's try to merge functionality where we can and not complicate things.<br>
<span><font color="#888888"><br>
/O<br>
</font></span><div>_______________________________________________<br>
sr-dev mailing list<br>
<a href="mailto:sr-dev@lists.sip-router.org" target="_blank">sr-dev@lists.sip-router.org</a><br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
</div></blockquote></div><br><br clear="all"><br><table style="width:450.0pt" border="0" cellpadding="0" cellspacing="0" width="600"><tbody><tr style="min-height:10.5pt"><td rowspan="3" style="width:173.25pt;padding:0cm 0cm 0cm 0cm;min-height:10.5pt" valign="top" width="231">
<br></td><td style="padding:0cm 0cm 0cm 0cm;min-height:10.5pt" valign="top"><br></td></tr><tr style="min-height:42.75pt"><td style="padding:0cm 0cm 0cm 0cm;min-height:42.75pt" valign="top"><br></td></tr></tbody></table><span style="border-collapse:collapse;font-family:arial,sans-serif;font-size:13px"></span>
</div></div><pre>This email is subject to the disclaimer of Smile Communications (PTY) Ltd. at <a href="http://www.smilecoms.com/disclaimer" target="_blank">http://www.smilecoms.com/disclaimer</a>
</pre><br>_______________________________________________<br>
sr-dev mailing list<br>
<a href="mailto:sr-dev@lists.sip-router.org" target="_blank">sr-dev@lists.sip-router.org</a><br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
<br></blockquote></div><br></div>
_______________________________________________<br>sr-dev mailing list<br><a href="mailto:sr-dev@lists.sip-router.org" target="_blank">sr-dev@lists.sip-router.org</a><br><a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
</blockquote></div></div></div><br></div><br>_______________________________________________<br>
sr-dev mailing list<br>
<a href="mailto:sr-dev@lists.sip-router.org" target="_blank">sr-dev@lists.sip-router.org</a><br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
<br></blockquote></div><br></div>
</div></div></blockquote></div><br></div>