<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hello,<br>
<br>
it is ok from my point of view, it looks like a bug otherwise. But
please add notes in the docbook/readme documentation about this
change for each of these functions.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<br>
<div class="moz-cite-prefix">On 5/15/13 2:36 PM, Vicente Hernando
wrote:<br>
</div>
<blockquote cite="mid:5193815D.3000403@systemonenoc.com" type="cite">Hello,
<br>
<br>
uac_replace_to and uac_replace_from functions can receive two
arguments, display and uri.
<br>
<br>
In current implementation two double quotes are automatically
added to display during fixup.
<br>
<br>
<br>
Would it be a better behavior not to add any quotes? If the user
wants some quotes he should add them by himself.
<br>
<br>
E.g:
<br>
<br>
right now, if I get a display "Vicente" from an invite and store
it in $fn variable, if I call
<br>
<br>
uac_replace_from($fn, uri_foo) it produces ""Vicente"" in the
display which kamailio complaints about.
<br>
<br>
<br>
If we would avoid quotes, uac_replace_from function could accept:
<br>
<br>
uac_replace_from("Bob", uri) display = Bob
<br>
<br>
uac_replace_from("\"Bob\"", uri) display = "Bob"
<br>
<br>
<br>
standard supports quoted strings, not quoted tokens, spaces before
and after quotes, etc.
<br>
<br>
<br>
Attached patch should avoid quotes in uac_replace functons.
<br>
<br>
<br>
What are your opinions about this?
<br>
<br>
Kind regards,
<br>
Vicente.
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
sr-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a>
<a class="moz-txt-link-freetext" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla - <a class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a>
<a class="moz-txt-link-freetext" href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a> - <a class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a>
Kamailio Advanced Training, San Francisco, USA - June 24-27, 2013
* <a class="moz-txt-link-freetext" href="http://asipto.com/u/katu">http://asipto.com/u/katu</a> *</pre>
</body>
</html>