<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>Hi Olle,</div><div><br></div><div>Thank you for your comments. We're about to merge a complete overhaul of the json and jsonrpc-c modules. The code is already available on GitHub at <span style="font-family: '.HelveticaNeueUI'; font-size: 15px; line-height: 19px; white-space: nowrap; -webkit-tap-highlight-color: rgba(26, 26, 26, 0.296875); -webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469); -webkit-text-size-adjust: none; "><a href="https://github.com/flowroute/">https://github.com/flowroute/</a>. W</span><span style="-webkit-tap-highlight-color: rgba(26, 26, 26, 0.296875); -webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469); ">e have not, however, tested for IPv6. </span></div><div><span style="-webkit-tap-highlight-color: rgba(26, 26, 26, 0.292969); -webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469);"><br></span></div><div><span style="-webkit-tap-highlight-color: rgba(26, 26, 26, 0.292969); -webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469);">Matthew Williams</span></div><div><span style="-webkit-tap-highlight-color: rgba(26, 26, 26, 0.292969); -webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469);">Flowroute LLC</span></div><div><span style="-webkit-tap-highlight-color: rgba(26, 26, 26, 0.292969); -webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469);"><br></span>On Sep 8, 2013, at 3:25 PM, "Olle E. Johansson" <<a href="mailto:oej@edvina.net">oej@edvina.net</a>> wrote:<br><br></div><blockquote type="cite"><div><span>int connect_server(struct jsonrpc_server *server)</span><br><span>{</span><br><span> struct sockaddr_in server_addr;</span><br><span> struct hostent *hp;</span><br><span></span><br><span> server_addr.sin_family = AF_INET;</span><br><span> server_addr.sin_port = htons(server->port);</span><br><span></span><br><span></span><br><span>Hard coded IPv4 in a product that has supported IPv6 since over 10 years? Tss tss.</span><br><span></span><br><span>Also, the timouts are hardcoded. </span><br><span></span><br><span>Maybe we should try to use CURL, like the utils module do and standardise the way Kamailio connect to HTTP servers. Having one http client may be beneficial, an http_client module. </span><br><span></span><br><span>The idea with suspend and restart transactions in another route block that json_rpc uses seems like a good idea also for the HTTP client functions in utils.</span><br><span></span><br><span>Just some thoughts after looking into the code, a Sunday evening brainstorm :-)</span><br><span></span><br><span>/O</span><br><span>_______________________________________________</span><br><span>sr-dev mailing list</span><br><span><a href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a></span><br><span><a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a></span><br></div></blockquote></body></html>