<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>2 okt 2013 kl. 17:19 skrev Robert Boisvert <<a href="mailto:rdboisvert@gmail.com">rdboisvert@gmail.com</a>>:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><font size="3" face="Times New Roman">
</font><p style="margin:0in 0in 10pt"><font size="3" face="Calibri">All,</font></p><font size="3" face="Times New Roman">
</font><p style="margin:0in 0in 10pt"><font face="Calibri">These are good comments and very helpful.<span> </span>In response, …</font></p><font size="3" face="Times New Roman">
</font><p style="margin:0in 0in 10pt"><font face="Calibri">The naming decision came up early in the design process and
I concluded that queue is too generic.<span> </span>I
thought of “callqueue” but decided against it since there are many ways to put
calls into queues and I didn’t want to conflict with future modules which might
have their own “call queues”.<span> </span>I used “mohqueue”
because it is concise and hopefully makes the function more apparent.<span> </span>I could call it “MOHqueue” if that makes the “MOH”
part stand out more.</font></p><div><br></div></div></div></blockquote>No camelcase in module names, please.</div><div><br><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><font size="3" face="Times New Roman">
</font><p style="margin:0in 0in 10pt"><font size="3" face="Calibri">Using the payload number was not my choice but is the way
Sippy RTPproxy works.<span> </span>Like others, (</font><a href="http://lists.sip-router.org/pipermail/sr-users/2011-July/069391.html"><font color="#0000ff" size="3" face="Calibri">http://lists.sip-router.org/pipermail/sr-users/2011-July/069391.html</font></a><font size="3" face="Calibri">)
I found this out by going directly into the source code. If I am wrong in this conclusion, please help me get it right.</font></p><div><br></div></div></div></blockquote><div>It is still wrong and not very future-safe. Please add a conversion table. What's the state with rtpproxy-ng? Still using old payload numbers?</div><br><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><font size="3" face="Times New Roman">
</font><p style="margin:0in 0in 10pt"><font size="3" face="Calibri">Being able to choose a specific call out of queue is very
flexible, but under what circumstances would this feature be useful?</font></p><div><br></div></div></div></blockquote>It's just an idea. Many users have implemented this in UIs to Asterisk call queues. It's quite often a requirement.</div><div><br><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><font size="3" face="Times New Roman">
</font><p style="margin:0in 0in 10pt"><font face="Calibri">xavp is a useful extension and something to consider for the
future. <span> </span>I was in a hurry to meet
deadlines so I chose what worked best in the current environment.</font></p><div><br></div></div></div></blockquote>Can understand that. Just a suggestion too.<br><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div><br></div><div><br></div><font size="3" face="Times New Roman">
</font><p style="margin:0in 0in 10pt"><font face="Calibri">I will adjust the comment about request routes.<span> </span>I appreciate the help with documentation
since it is just as important as the code.</font></p><div><br></div></div></div></blockquote>That's the spirit!!!</div><div><br></div><div>Good work, Bob!</div><div><br></div><div>/O<br><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div><br></div><font size="3" face="Times New Roman">
</font><p style="margin:0in 0in 10pt"><font size="3" face="Calibri">Thanks,<br></font><font size="3" face="Calibri">Bob</font></p><font size="3" face="Times New Roman">
</font></div></div>
_______________________________________________<br>sr-dev mailing list<br><a href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a><br>http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev<br></blockquote></div><br><div apple-content-edited="true">
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0; "><div>---</div><div>* Olle E Johansson - <a href="mailto:oej@edvina.net">oej@edvina.net</a></div><div>* Cell phone +46 70 593 68 51, Office +46 8 96 40 20, Sweden</div><div><br class="webkit-block-placeholder"></div></span><br class="Apple-interchange-newline">
</div>
<br></body></html>