<div dir="ltr">Hi Daniel,<div><br></div><div>Thanks for the feedback.</div><div><br></div><div>I will address the points you mention and commit over the next day or two, in time for the freeze.</div><div><br></div><div>Thanks again and enjoy your weekend :)</div>
<div><br></div><div>Best regards,</div><div><br></div><div>Charles</div><div><br></div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 4 October 2013 19:26, Daniel-Constantin Mierla <span dir="ltr"><<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
Hi Charles,<br>
<br>
thanks for the patch. Few remarks:<br>
<br>
- for strict C compatibility, would be good to declare variables at
the beginning of the functions or block, not in between statements<br>
<br>
- i think the next variable has to be initialized to NULL in
modules/htable/ht_dmq.c, like:<br>
<br>
dmq_peer_t* ht_dmq_peer = NULL;<br>
<br>
Otherwise it can happen that enable_dmq is not set, but
dmqreplicate per hash table is set and could cause a crash.<br>
<br>
Eventually, when enable_dmq is not 1, then make dmqreplicate per
hash table 0, no matter what value is given -- I guess this will
require that enable_dmq parameter has to be set before defining a
hash table. Also, in such case, could be useful to have a log
message to warn about setting replication in hash table definition,
but the module-level parameter is not enabled.<br>
<br>
If you redo the entire patch, the line with $Id$ at the beginning of
files can be removed, it is a reminiscent from SVN/CVS times, with
no real usage now - this is just beautification.<br>
<br>
The rest seems ok, so can be committed.<br>
<br>
Cheers,<br>
Daniel<div><div class="h5"><br>
<br>
<div>On 10/3/13 6:58 PM, Charles Chance
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hi Daniel,
<div><br>
</div>
<div>Please see attached - if there is a better way of
presenting it please let me know (still getting to grips with
git!).</div>
<div><br>
</div>
<div>There are some improvements planned such as fetching values
from other nodes at startup and some kind of buffer/queue to
ensure updates are always applied in order, even if some
messages are delayed slightly. But it works well as a starting
point, and of course the functionality is optional.</div>
<div><br>
</div>
<div>Please let me have your feedback and I can modify/improve
as required.</div>
<div><br>
</div>
<div>Cheers,</div>
<div><br>
</div>
<div>Charles</div>
<div><br>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">
On 30 September 2013 10:46, Daniel-Constantin Mierla <span dir="ltr"><<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> Hello,
<div><br>
<br>
<div>On 9/30/13 11:39 AM, Charles Chance wrote:<br>
</div>
<blockquote type="cite">
<p dir="ltr">Hi,</p>
<p dir="ltr">Not sure whether it is appropriate to
get this in before the upcoming freeze or wait
until after.</p>
</blockquote>
<br>
</div>
all new code should go on git before freeze -- unless
there is a major change that will require a lot of
coding in other parts to get it coherent, there is no
rule of stopping new features from getting merged.
<div><br>
<br>
<blockquote type="cite">
<p dir="ltr">I have the additions to htable module
nearly ready for review. What is the most
convenient - patch or private branch?</p>
</blockquote>
<br>
</div>
Typically I review better patches, if they are not big.
But I can look at the patches on the gitweb as well if
it is more convenient for you.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<blockquote type="cite">
<div>
<p dir="ltr">Just completing tests but should be
available tomorrow or day after. I have kept
disruption to existing code to a minimum and added
all functions into a separate file. New
functionality is disabled by default and must be
enabled on a per table basis.</p>
<p dir="ltr">What are everyone's thoughts? Maybe it
is too close to deadline for such a new feature?
Very happy to try though :)</p>
<p dir="ltr">Cheers,</p>
<p dir="ltr">Charles<br>
</p>
<br>
</div>
<font face="Helvetica, Arial, sans-serif"><font><span style="font-size:10pt"><a href="http://www.sipcentric.com/" title="blocked::http://www.sipcentric.com/" target="_blank">www.sipcentric.com</a><br>
<br>
Follow us on twitter <a href="http://twitter.com/sipcentric" title="blocked::http://twitter.com/sipcentric" target="_blank">@sipcentric</a><br>
<br>
<font color="gray">Sipcentric Ltd. Company
registered in England & Wales no. 7365592.</font> <font color="gray">Registered office: Unit 10 iBIC,
Birmingham Science Park, Holt Court South,
Birmingham B7 4EJ.</font></span></font></font>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
sr-dev mailing list
<a href="mailto:sr-dev@lists.sip-router.org" target="_blank">sr-dev@lists.sip-router.org</a>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><span><font color="#888888">
</font></span></pre>
<span><font color="#888888"> </font></span></blockquote>
<span><font color="#888888"> <br>
<pre cols="72">--
Daniel-Constantin Mierla - <a href="http://www.asipto.com" target="_blank">http://www.asipto.com</a>
<a href="http://twitter.com/#%21/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a>
Kamailio Advanced Trainings - Berlin, Nov 25-28; Miami, Nov 18-20, 2013
- more details about Kamailio trainings at <a href="http://www.asipto.com" target="_blank">http://www.asipto.com</a> -
</pre>
</font></span></div>
<br>
_______________________________________________<br>
sr-dev mailing list<br>
<a href="mailto:sr-dev@lists.sip-router.org" target="_blank">sr-dev@lists.sip-router.org</a><br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
<br>
</blockquote>
</div>
<br>
<br>
</div>
</div>
<br>
<font face="Helvetica, Arial, sans-serif"><font><span style="font-size:10pt"><a href="http://www.sipcentric.com/" title="blocked::http://www.sipcentric.com/" target="_blank">www.sipcentric.com</a><br>
<br>
Follow us on twitter <a href="http://twitter.com/sipcentric" title="blocked::http://twitter.com/sipcentric" target="_blank">@sipcentric</a><br>
<br>
<font color="gray">Sipcentric Ltd. Company registered in
England & Wales no. 7365592.</font> <font color="gray">Registered
office: Unit 10 iBIC, Birmingham Science Park, Holt Court
South, Birmingham B7 4EJ.</font></span></font></font>
</blockquote>
<br>
<pre cols="72">--
Daniel-Constantin Mierla - <a href="http://www.asipto.com" target="_blank">http://www.asipto.com</a>
<a href="http://twitter.com/#!/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a>
Kamailio Advanced Trainings - Berlin, Nov 25-28; Miami, Nov 18-20, 2013
- more details about Kamailio trainings at <a href="http://www.asipto.com" target="_blank">http://www.asipto.com</a> -
</pre>
</div></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><font face="arial, helvetica, sans-serif"><b><font>Charles Chance</font></b><br><font>Managing Director</font></font><br><div><font face="arial, helvetica, sans-serif"><font><br>
</font></font></div><div><font face="arial, helvetica, sans-serif"><font>t. 0121 285 4400 m. 07932 063 891</font></font></div></div>
</div>
<br>
<font face="Helvetica, Arial, sans-serif"><font size="2"><span style="font-size:10pt"><a href="http://www.sipcentric.com/" title="blocked::http://www.sipcentric.com/" target="_blank">www.sipcentric.com</a><br>
<br>
Follow us on twitter <a href="http://twitter.com/sipcentric" title="blocked::http://twitter.com/sipcentric" target="_blank">@sipcentric</a><br>
<br>
<font color="gray">Sipcentric Ltd.
Company registered in England & Wales no. 7365592.</font> <font color="gray">Registered
office: Unit 10 iBIC, Birmingham Science Park, Holt Court South, Birmingham B7 4EJ.</font></span></font></font>