<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Øyvind,<br>
<br>
thanks for update -- I didn't find the time to follow up the
discussion as well.<br>
<br>
I tried to apply the patch, but apparently it is not for master
branch. Some chunk fails to apply. Can you update it for master
branch?<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<div class="moz-cite-prefix">On 11/11/13 2:48 PM, Øyvind Kolbu
wrote:<br>
</div>
<blockquote cite="mid:20131111134845.GA35793@putsch.kolbu.ws"
type="cite">
<pre wrap="">On 2013-10-29 at 09:34, Daniel-Constantin Mierla wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On 10/18/13 3:14 PM, Øyvind Kolbu wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Made a core option, dns_naptr_ignore_rfc, default off, to preserve today's
behavior.
</pre>
</blockquote>
<pre wrap="">did I get it wrong or the dns_naptr_ignore_rfc has to be 1 (on) to
preserve current behaviour? You said 'off' (expect 0) which collides
with the 'ignore' in the name of the parameter.
</pre>
</blockquote>
<pre wrap="">
Hi and sorry for the late reply. Been offline on vacation.
Yes, the value has to be 1 to actually ignore the rfc. The code
was correct, but the default value not. Fixed in the attached patch.
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">One implementation detail is that one currently can disable a protocol
by setting the priority to -1. In my patch that is currently ignored.
Can add a check for that in init_naptr_proto_prefs() before setting
a protocol's preference to 1.
</pre>
</blockquote>
<pre wrap="">
Can you add the check for ignoring a protocol? Sometime it might be
needed. Resend the patch and I will push it to repo.
</pre>
</blockquote>
<pre wrap="">
Fixed in the new patch.
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
sr-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a>
<a class="moz-txt-link-freetext" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla - <a class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a>
<a class="moz-txt-link-freetext" href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a> - <a class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a>
Kamailio Advanced Trainings - Berlin, Nov 25-28
- more details about Kamailio trainings at <a class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a> -
</pre>
</body>
</html>