<div dir="ltr"><div><div>Thanks Daniel,<br><br></div>I've just tested the patch, it works now.<br><br></div>Regards,<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Dec 6, 2013 at 11:38 AM, Daniel-Constantin Mierla <span dir="ltr"><<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  
    
  
  <div bgcolor="#FFFFFF" text="#000000">
    Hello,<br>
    <br>
    thanks, it was fixed on master and backported to 4.1 branch.<br>
    <br>
    Cheers,<br>
    Daniel<div><div class="h5"><br>
    <br>
    <div>On 12/5/13 6:37 PM, Tuan Viet Nguyen
      wrote:<br>
    </div>
    </div></div><blockquote type="cite"><div><div class="h5">
      <div dir="ltr">
        <div>Hello,<br>
          <br>
        </div>
        It seems that when calling the function sdp_get_line_startswith,
        it removes the \r (0d in hexa) from the SIP message before
        forwarding it. In the code (sdpops_mod.c) from line 1402 to
        1406, we see that<br>
              <br>
        <div>
          <div>// remove ending \r\n if exists<br>
                  if (avp_val.s.s[line.len-2] == '\r' &&
            avp_val.s.s[line.len-1] == '\n')<br>
                  {    <br>
                      avp_val.s.s[line.len-2] = '\0';<br>
                      avp_val.s.len -= 2;<br>
                  }    <br>
            <br>
          </div>
          <div>As avp_val is a reference to the found line which is also
            a reference to the line in the message, all modification
            made to this var will also be applied to the message. Am I
            wrong?<br>
            <br>
          </div>
          <div>Thank you,<br>
          </div>
        </div>
      </div>
      <br>
      <fieldset></fieldset>
      <br>
      </div></div><pre>_______________________________________________
sr-dev mailing list
<a href="mailto:sr-dev@lists.sip-router.org" target="_blank">sr-dev@lists.sip-router.org</a>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><span class="HOEnZb"><font color="#888888">
</font></span></pre><span class="HOEnZb"><font color="#888888">
    </font></span></blockquote><span class="HOEnZb"><font color="#888888">
    <br>
    <pre cols="72">-- 
Daniel-Constantin Mierla - <a href="http://www.asipto.com" target="_blank">http://www.asipto.com</a>
<a href="http://twitter.com/#!/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a></pre>
  </font></span></div>

<br>_______________________________________________<br>
sr-dev mailing list<br>
<a href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a><br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
<br></blockquote></div><br></div>