<html><head></head><body bgcolor="#FFFFFF"><div>Hello,</div><div><br></div><div>you can look at how keepalive flags are stored and used as example. You can probably extend the function that sets the property for keepalive for this new feature.</div><div><br></div><div>Cheers,</div><div>Daniel<br><br>--<br>Daniel-Constantin Mierla<div><a href="http://www.asipto.com">http://www.asipto.com</a></div></div><div><br>On 6 Jan 2014, at 14:05, Federico Cabiddu <<a href="mailto:federico.cabiddu@gmail.com">federico.cabiddu@gmail.com</a>> wrote:<br><br></div><div></div><blockquote type="cite"><div><div dir="ltr">Hi Daniel,<div>thanks for the suggestion, I will try to use the internal flags to store it.</div><div>Please found attached the previous patch without reformatting.</div><div><br></div><div>Regards,</div><div>
<br></div><div>Federico Cabiddu</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jan 6, 2014 at 1:46 PM, Daniel-Constantin Mierla <span dir="ltr"><<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
Hello,<br>
<br>
since it is about 0|1 state, it can be probably stored as a bit over
the dialog internal flags, which is iflags column.<br>
<br>
Also, for the patch, do it without reformatting a lot of code,
because it is not easy to track the real chances and review it. If
there is lot to reformat, do a separate patch before or after the
one that adds new features.<br>
<br>
Cheers,<br>
Daniel<div><div class="h5"><br>
<br>
<div>On 06/01/14 13:31, Federico Cabiddu
wrote:<br>
</div>
</div></div><blockquote type="cite"><div><div class="h5">
<div dir="ltr">Hi,
<div>we are using the dialog module to limit the duration of
users' calls.</div>
<div>We recently discovered (well, it's stated in the module
doc) that each subsequent in-dialog request resets the dialog
timeout. I can understand that this behavior can be useful in
some cases, but in our is causing the call duration limitation
to not work. I prepared a simple patch to introduce a new
parameter to make this behavior configurable (per module). I
would like to have it configurable per dialog, via means of an
AVP, but this would have implications on the dialog
save/restore mechanism and on the db schema, so for the moment
I left it simple.</div>
<div><br>
</div>
<div>Regards,</div>
<div><br>
</div>
<div>Federico Cabiddu</div>
</div>
<br>
<fieldset></fieldset>
<br>
</div></div><div class="im"><pre>_______________________________________________
sr-dev mailing list
<a href="mailto:sr-dev@lists.sip-router.org" target="_blank">sr-dev@lists.sip-router.org</a>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a>
</pre>
</div></blockquote><span class="HOEnZb"><font color="#888888">
<br>
<pre cols="72">--
Daniel-Constantin Mierla - <a href="http://www.asipto.com" target="_blank">http://www.asipto.com</a>
<a href="http://twitter.com/#!/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a></pre>
</font></span></div>
<br>_______________________________________________<br>
sr-dev mailing list<br>
<a href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a><br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
<br></blockquote></div><br></div>
</div></blockquote><blockquote type="cite"><div><dialog_timeout.patch></div></blockquote></body></html>