<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Hi,<br>
Marek Bazler posted a patch to implement SIP Digest authentication
and Carsten said on Sunday he was looking at it. I expect they are
the same though.<br>
<br>
There were a few IMS fixes in December, I was thinking about
cherry-picking them to 4.1 ready for the 4.1.1 release on
Thursday, but I don't want to get in the way of someone else (e.g.
the developer that wrote it) doing the same thing!<br>
<br>
Hugh<br>
<br>
On 08/01/2014 11:45, Richard Good wrote:<br>
</div>
<blockquote
cite="mid:CAOvD117vNtWbv8Douknd3yPeD4bebN8UmLZsEVkryicxHmxe1A@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div>
<div>
<div>
<div>
<div>Hi Rob<br>
<br>
</div>
Thanks for the fixes, I hope you have everything
working now.<br>
<br>
</div>
sem_post issue: we have had the same issue on Ubuntu
and have added -lpthread to the Makefiles. We didn't
commit as we are not 100% sure of the impact on other
OS'. Does anyone have any objections to adding
-lpthread to the Makefile of cdp, ims_qos and
ims_registrar_pcscf?<br>
<br>
</div>
seg_fault and memory management: The seg fault has been
fixed in the master branch. Please feel free to commit
the fix to 4.0. The memory management does seem odd, this
code comes from the OpenIMSCore project, will have a look
and see if I can figure it out.<br>
<br>
</div>
SIP digest: This was accidentally left off as we do not use
it - please feel free to commit.<br>
<br>
</div>
Config file: You are correct these are out of date in 4.0 -
Please feel free to commit the fix to 4.0. The master branch
config files are up to date.<br>
<br>
</div>
I recommend using the master branch for the time being as there
are still quite a few changes coming through.<br>
<br>
Regards<br>
Richard.<br>
<div class="gmail_extra">
<div>
<div dir="ltr">
<table style="width:450.0pt" width="600" cellpadding="0"
cellspacing="0" border="0">
<tbody>
<tr>
<td style="padding:0cm" valign="top"><br>
</td>
</tr>
<tr>
<td style="padding:3.75pt 0cm 3.75pt 0cm"
valign="top"><br>
</td>
</tr>
</tbody>
</table>
<table style="width:450.0pt" width="600" cellpadding="0"
cellspacing="0" border="0">
<tbody>
<tr style="min-height:10.5pt">
<td rowspan="3" style="width:173.25pt;padding:0cm
0cm 0cm 0cm;min-height:10.5pt" valign="top"
width="231"><br>
</td>
<td style="padding:0cm 0cm 0cm
0cm;min-height:10.5pt" valign="top"><br>
</td>
</tr>
<tr style="min-height:42.75pt">
<td style="padding:0cm 0cm 0cm
0cm;min-height:42.75pt" valign="top"><br>
</td>
</tr>
</tbody>
</table>
<span
style="border-collapse:collapse;font-family:arial,sans-serif;font-size:13px"></span></div>
</div>
<br>
<br>
<div class="gmail_quote">On 28 December 2013 23:04, Rob Day <span
dir="ltr"><<a moz-do-not-send="true"
href="mailto:rkd@rkd.me.uk" target="_blank">rkd@rkd.me.uk</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> <font size="-1">Hi,<br>
<br>
I've been trying to set up Kamailio 4.0.5 as a P-CSCF,
I-CSCF and S-CSCF today, and hit a few issues which
I've fixed. <a moz-do-not-send="true"
href="http://sip-router.org/contribute/"
target="_blank">http://sip-router.org/contribute/</a>
suggests that patches should be submitted to this
list, so here I am.<br>
<br>
The first issue I hit was the sem_post issue that has
been reported from time to time (<a
moz-do-not-send="true"
href="http://lists.kamailio.org/pipermail/sr-users/2013-January/076554.html"
target="_blank">http://lists.kamailio.org/pipermail/sr-users/2013-January/076554.html</a>)
- it looks as though sem_post is only included in
-lpthread on Ubuntu 12.04, not -lrt (<a
moz-do-not-send="true"
href="https://bugs.launchpad.net/ubuntu/+source/manpages/+bug/874418"
target="_blank">https://bugs.launchpad.net/ubuntu/+source/manpages/+bug/874418</a>),
so I've updated some Makefiles to reflect that.<br>
<br>
I subsequently hit a segfault when calling pcscf_save:
I've tracked this down to a while loop that was
missing curly braces, and so tried to dereference a
null pointer. I think there's another bug in this
piece of code - because h is NULL at the end of the
first while loop, we never go round the second loop,
and so never call free_rr. It looks like even if we
did, h->parsed has been set to 0 before we try and
free it, so nothing would happen. I wasn't sure how
the memory management here works, though, and so
haven't tried to change this.<br>
<br>
I also found that the ims_auth module didn't handle
standard SIP Digest authentication on the MAR
interface, only AKA and Digest-MD5 (which seems to be
specific to OpenIMSCore HSS, and not mentioned in the
IMS specs). Most of the code to allow SIP Digest
authentication was already there, so I just hooked the
last piece in to get it to work. I'm not sure whether
this counts as a new feature or a bugfix - it's not
clear whether this was meant to be supported but just
missing a piece, or not meant to be supported but very
easy to add in.<br>
<br>
Finally, I was working from the 4.0 nightlies Debian
repository, and the examples/scsf/kamailio.cfg file
for 4.0.x seems to skip authentication. It looks like
this section has been reworked heavily in 4.1.0, so
this may be less important - but I put together a
different kamailio.cfg based on a mailing list post (<a
moz-do-not-send="true"
href="http://lists.sip-router.org/pipermail/sr-users/2013-March/077142.html"
target="_blank">http://lists.sip-router.org/pipermail/sr-users/2013-March/077142.html</a>),
and it might make sense to use that as the default
file for 4.0.x.<br>
<br>
The attached patches are against the 4.0 branch in Git
(specifically, commit
1b98961522fd8a7eb73ecc7d1772541f8b81aabc). I'm happy
to apply any feedback which more knowledgeable
contributors have.<br>
<br>
Best regards,<br>
Rob<br>
</font> </div>
<br>
_______________________________________________<br>
sr-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a><br>
<a moz-do-not-send="true"
href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev"
target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
<pre>This email is subject to the disclaimer of Smile Communications at <a class="moz-txt-link-freetext" href="http://www.smilecoms.com/disclaimer">http://www.smilecoms.com/disclaimer</a>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre wrap="">_______________________________________________
sr-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a>
<a class="moz-txt-link-freetext" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a>
</pre>
</pre>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Hugh Waite
Principal Design Engineer
Crocodile RCS Ltd.</pre>
</body>
</html>