<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi Ovidiu!<div><br></div><div>Thanks for this commit. </div><div><br></div><div>A few questions:</div><div><br></div><div>- Did you update the README? THe original commit did not commit a new README file. Maybe you did it later.</div><div><br></div><div>The docs say:</div><div><br></div><div><div class="diff add" style="font-family: monospace; font-size: small; white-space: pre; color: rgb(0, 136, 0); background-color: rgb(255, 255, 255);"> <section id="kex.r.stats.get_statistics"></div><div class="diff add" style="font-family: monospace; font-size: small; white-space: pre; color: rgb(0, 136, 0); background-color: rgb(255, 255, 255);">+ <title></div><div class="diff add" style="font-family: monospace; font-size: small; white-space: pre; color: rgb(0, 136, 0); background-color: rgb(255, 255, 255);">+ <function moreinfo="none">stats.get_statistics</function></div><div class="diff add" style="font-family: monospace; font-size: small; white-space: pre; color: rgb(0, 136, 0); background-color: rgb(255, 255, 255);">+ </title></div><div class="diff add" style="font-family: monospace; font-size: small; white-space: pre; color: rgb(0, 136, 0); background-color: rgb(255, 255, 255);">+ <para>Print the list of available internal statistics.</para></div><div class="diff add" style="font-family: monospace; font-size: small; white-space: pre; color: rgb(0, 136, 0); background-color: rgb(255, 255, 255);">+ <para>Parameters: <emphasis>statsid</emphasis> - which statistics to</div><div class="diff add" style="font-family: monospace; font-size: small; white-space: pre; color: rgb(0, 136, 0); background-color: rgb(255, 255, 255);">+ be printed. If set to 'all' then all statistics are printed; if</div><div class="diff add" style="font-family: monospace; font-size: small; white-space: pre; color: rgb(0, 136, 0); background-color: rgb(255, 255, 255);">+ set to 'statsgroup:' then all statistics in the group are printed;</div><div class="diff add" style="font-family: monospace; font-size: small; white-space: pre; color: rgb(0, 136, 0); background-color: rgb(255, 255, 255);">+ if set to 'statsname' then the statistics identified by the name</div><div class="diff add" style="font-family: monospace; font-size: small; white-space: pre; color: rgb(0, 136, 0); background-color: rgb(255, 255, 255);">+ is printed.</para></div></div><div class="diff add" style="font-family: monospace; font-size: small; white-space: pre; color: rgb(0, 136, 0); background-color: rgb(255, 255, 255);"><br></div><div class="diff add" style="font-family: monospace; font-size: small; white-space: pre; color: rgb(0, 136, 0); background-color: rgb(255, 255, 255);"><br></div><div class="diff add" style="font-family: monospace; font-size: small; white-space: pre; color: rgb(0, 136, 0); background-color: rgb(255, 255, 255);">"all statistics" - does this really apply to ALL - user configured and produced by other modules? Or just the kex module stats?</div><div class="diff add" style="font-family: monospace; font-size: small; white-space: pre; color: rgb(0, 136, 0); background-color: rgb(255, 255, 255);">Maybe a clarification would be good. If it's all, including other modules, there's an overlap with stats and counters.</div><div class="diff add" style="font-family: monospace; font-size: small; white-space: pre; color: rgb(0, 136, 0); background-color: rgb(255, 255, 255);"><br></div><div class="diff add" style="font-family: monospace; font-size: small; white-space: pre; color: rgb(0, 136, 0); background-color: rgb(255, 255, 255);">/O</div></body></html>