<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello,<br>
<br>
what is the state with this patch?<br>
<br>
This tracker item seems related:<br>
<br>
-
<a class="moz-txt-link-freetext" href="http://sip-router.org/tracker/index.php?do=details&task_id=353&project=1">http://sip-router.org/tracker/index.php?do=details&task_id=353&project=1</a><br>
<br>
Cheers,<br>
Daniel<br>
<br>
<div class="moz-cite-prefix">On 16/11/13 20:36, Marius Zbihlei
wrote:<br>
</div>
<blockquote
cite="mid:CAD85-0sVsGdWx_AFSrHXB_DX5XkG4wXBxO+O5W8Q10DZG2HtYw@mail.gmail.com"
type="cite">
<div dir="ltr">Hello Lucian,
<div><br>
</div>
<div>Sorry for the delay I was fairly busy and also I wanted to
try to use Rietveld(*) for doing the code review(@Daniel ever
think about extending something like this to all commits or
all patches coming from contributors?)</div>
<div><br>
</div>
<div>So, I will do my review here:</div>
<div><br>
</div>
<div><a moz-do-not-send="true"
href="https://codereview.appspot.com/27270044/">https://codereview.appspot.com/27270044/</a>
(@Lucian see the comments section for needed improvement)</div>
<div><br>
</div>
<div>(*) developed by Guido Van Rossum when working at Google.
FOSS, but requires AppEngine</div>
<div><br>
</div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Fri, Nov 8, 2013 at 4:37 PM, Lucian
Balaceanu <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:lucian.balaceanu@1and1.ro" target="_blank">lucian.balaceanu@1and1.ro</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#ffffff" text="#000000"> Hello Marius,<br>
<br>
I have attached a patched version of an internal parser
for carrierroute. I would very much appreciate suggestions
related to it.<br>
Some build dependencies would still have to be removed:
fedora, openbsd and centos.<br>
<br>
Thank you,<br>
Lucian Balaceanu
<div>
<div class="h5"><br>
<br>
<br>
<br>
On 10/21/2013 11:04 AM, Marius Zbihlei wrote:
<blockquote type="cite">
<div dir="ltr">That would be great! Thanks!
<div> </div>
<div>Marius.</div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Mon, Oct 21, 2013 at
8:04 AM, Lucian Balaceanu <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:lucian.balaceanu@1and1.ro"
target="_blank">lucian.balaceanu@1and1.ro</a>></span>
wrote:<br>
<blockquote class="gmail_quote"
style="margin:0pt 0pt 0pt
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div bgcolor="#ffffff" text="#000000"> Hi
Marius,<br>
<br>
I will commit such a patch related to
libconfuse. Maybe you want to have a look
over it?<br>
<br>
Thank you,<br>
Lucian Balaceanu
<div>
<div><br>
<br>
<br>
On 10/20/2013 11:51 PM, Marius Zbihlei
wrote: </div>
</div>
<blockquote type="cite">
<div>
<div>
<div dir="ltr">Hi all,
<div><br>
</div>
<div>This has been in the back of my
head from some time now.
Libconfuse is a small project not
distributed with major distros and
unmaintained for 3.5 years now. As
it is only used for reading of a
simple cfg file, I want to write a
simple parser that does the job(I
do not want external deps ... see
below why)</div>
<div><br>
</div>
<div>Benefits: we can now pack
carrierroute with the common used
modules (as it will not have any
external dependencies) and also
will remove a lot of problems seen
on the list regarding linkage of
libconfuse.</div>
<div><br>
</div>
<div>Any thoughts?</div>
<div><br>
</div>
<div>Marius</div>
</div>
</div>
</div>
<pre><fieldset></fieldset>
_______________________________________________
sr-dev mailing list
<a moz-do-not-send="true" href="mailto:sr-dev@lists.sip-router.org" target="_blank">sr-dev@lists.sip-router.org</a>
<a moz-do-not-send="true" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a>
</pre>
</blockquote>
<br>
</div>
<br>
_______________________________________________<br>
sr-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:sr-dev@lists.sip-router.org"
target="_blank">sr-dev@lists.sip-router.org</a><br>
<a moz-do-not-send="true"
href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev"
target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
<br>
</blockquote>
</div>
<br>
</div>
<pre><fieldset></fieldset>
_______________________________________________
sr-dev mailing list
<a moz-do-not-send="true" href="mailto:sr-dev@lists.sip-router.org" target="_blank">sr-dev@lists.sip-router.org</a>
<a moz-do-not-send="true" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a>
</pre>
</blockquote>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
sr-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a>
<a class="moz-txt-link-freetext" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla - <a class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a>
<a class="moz-txt-link-freetext" href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a> - <a class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a></pre>
</body>
</html>