<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello,<br>
<br>
it can be committed, indeed.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<div class="moz-cite-prefix">On 09/03/14 17:01, Jason Penton wrote:<br>
</div>
<blockquote
cite="mid:CAE=Kcrhw4oofKvNpxW5KCmyyVi9G88+W+4wq+-JZPTunHsHMAg@mail.gmail.com"
type="cite">
<div dir="ltr">Hi Devs,
<div><br>
</div>
<div>Any comment/problem with this change? If not, I'd like to
commit this week. Seem fine to me.</div>
<div><br>
</div>
<div>Cheers</div>
<div>Jason</div>
</div>
<div class="gmail_extra">
<br>
<br>
<div class="gmail_quote">On Fri, Mar 7, 2014 at 5:41 PM, Richard
Good <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:richard.good@smilecoms.com" target="_blank">richard.good@smilecoms.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div>
<div>
<div>
<div>Hi<br>
<br>
</div>
We have found that in kamailio processing if you:<br>
1. set msg->path_vec<br>
2. call msg_apply_changes()<br>
3. t_telay<br>
<br>
</div>
The route-header of the outgoing message is set twice.<br>
<br>
</div>
We think this is because msg_apply_changes() adds the
router header if the path is set - but leaves the path
set. So the router header is added again when you
t_relay.<br>
<br>
</div>
To fix this:<br>
--- a/modules/textopsx/textopsx.c<br>
+++ b/modules/textopsx/textopsx.c<br>
@@ -166,7 +166,7 @@ static int
msg_apply_changes_f(sip_msg_t *msg, char *str1, char
*str2)<br>
} else {<br>
obuf.s = build_req_buf_from_sip_req(msg,<br>
(unsigned
int*)&obuf.len, &dst,<br>
-
BUILD_NO_LOCAL_VIA|BUILD_NO_VIA1_UPDATE);<br>
+
BUILD_NO_PATH|BUILD_NO_LOCAL_VIA|BUILD_NO_VIA1_UPDATE);<br>
}<br>
if(obuf.s == NULL)<br>
{<br>
<br>
<div>
<div>
<div>
<div><br>
</div>
<div>This stops msg_apply_changes() from adding the
router header if path is set.<br>
<br>
</div>
<div>Any objections to comitting this to master?
Might other functionality be effected?<br>
<br>
</div>
<div>The alternative is for msg_apply_changes() to
add the router header but then unset the path.<br>
</div>
<div><br>
</div>
<div>Regards<br>
Richard.<br>
</div>
</div>
</div>
</div>
</div>
<br>
<span><font color="#888888">
<pre>This email is subject to the disclaimer of Smile Communications at <a moz-do-not-send="true" href="http://www.smilecoms.com/home/email-disclaimer/" target="_blank">http://www.smilecoms.com/home/email-disclaimer/</a></pre>
</font></span><br>
_______________________________________________<br>
sr-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a><br>
<a moz-do-not-send="true"
href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev"
target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
<br>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
<div dir="ltr">
<div>
<table style="width:450pt" border="0" cellpadding="0"
cellspacing="0" width="600">
<tbody>
<tr>
<td style="padding:0cm" valign="top">
<br>
</td>
</tr>
</tbody>
</table>
<table style="font-family:monospace" border="0"
cellpadding="0" cellspacing="0" width="320px">
<tbody>
<tr>
<td
style="font-family:Arial,sans-serif;font-size:16px;color:rgb(117,179,67);line-height:18px;padding-left:15px;padding-top:10px"><strong>Jason
Penton</strong></td>
</tr>
<tr>
<td
style="font-family:Arial,sans-serif;font-size:16px;color:rgb(117,179,67);line-height:18px;padding-left:15px;padding-top:10px"><strong>Senior
Manager: Applications and Services</strong></td>
</tr>
<tr>
<td
style="font-family:Arial,sans-serif;font-size:16px;color:rgb(134,145,154);line-height:18px;padding-left:15px;padding-top:10px"><strong>Smile
Communications Pty (Ltd)</strong></td>
</tr>
<tr>
<td>
<table cellpadding="0" cellspacing="0" width="100%">
<tbody>
<tr>
<td
style="font-family:Arial,sans-serif;font-size:16px;color:rgb(134,145,154);line-height:18px;padding-left:15px;padding-top:10px"
width="27%"><strong>Mobile:</strong></td>
<td
style="font-family:Arial,sans-serif;font-size:16px;color:rgb(134,145,154);line-height:18px;padding-left:10px;padding-top:10px"
width="73%">
+27 (0) 83 283 7000</td>
</tr>
<tr>
<td
style="font-family:Arial,sans-serif;font-size:16px;color:rgb(134,145,154);line-height:18px;padding-left:15px;padding-top:10px"><strong>Skype:</strong></td>
<td
style="font-family:Arial,sans-serif;font-size:16px;color:rgb(134,145,154);line-height:18px;padding-left:10px;padding-top:10px">jason.barry.penton</td>
</tr>
</tbody>
</table>
</td>
</tr>
<tr>
<td
style="font-family:Arial,sans-serif;font-size:16px;color:rgb(117,179,67);line-height:18px;padding-left:15px;padding-top:10px"><a
moz-do-not-send="true"
href="mailto:name.surname@smilecoms.com"
style="font-family:Arial;color:rgb(117,179,67);text-decoration:none"
target="_blank">jason.penton@smilecoms.com</a></td>
</tr>
<tr>
<td
style="font-family:Arial,sans-serif;font-size:16px;color:rgb(117,179,67);line-height:18px;padding-left:15px;padding-top:10px"><a
moz-do-not-send="true"
href="http://www.smilecoms.com/"
style="font-family:Arial;color:rgb(117,179,67)"
target="_blank">www.smilecoms.com</a><br>
<img moz-do-not-send="true"
src="http://196.33.227.129/%7Esmlcoms/sigs/pty/images/smile_signature_07_09.jpg"
height="144" width="420"><br>
</td>
</tr>
</tbody>
</table>
</div>
<br>
</div>
</div>
<br>
<span><font color="#888888">
<pre>This email is subject to the disclaimer of Smile Communications at <a moz-do-not-send="true" href="http://www.smilecoms.com/home/email-disclaimer/" target="_blank">http://www.smilecoms.com/home/<wbr>email-disclaimer/</a></pre>
</font></span>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
sr-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a>
<a class="moz-txt-link-freetext" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla - <a class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a>
<a class="moz-txt-link-freetext" href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a> - <a class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a>
Kamailio World Conference - April 2-4, 2014, Berlin, Germany
<a class="moz-txt-link-freetext" href="http://www.kamailioworld.com">http://www.kamailioworld.com</a></pre>
</body>
</html>