<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello,<br>
<br>
I wrapped the patch within defines and pushed it to master branch. I
plan to test it very soon as I need it in some old systems.<br>
<br>
To enable it, websocket module has to be compuled with
EMBEDDED_UTF8_DECODE=1, e.g.:<br>
<br>
make modules EMBEDDED_UTF8_DECODE=1 modules=modules/websocket<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<div class="moz-cite-prefix">On 05/02/14 10:23, Peter Dunkley wrote:<br>
</div>
<blockquote
cite="mid:CAEqTk6Tb07JEwGuxb+_F3W7qZf+mapgWz8bZn0mw7TEepi0+ww@mail.gmail.com"
type="cite">
<div dir="ltr">Hello,
<div><br>
</div>
<div>I have no problem in principle with the patch, I am just
wary of changing something that works. I do Kamailio builds
on four (very different) Linux variants (CentOS 6, Fedora 19,
Ubuntu 13.10, Rasbian (Debian Wheezy on Raspberry Pi)) and
have never had a problem with the libunistring dependency for
WebSockets.
<div>
<br>
</div>
<div>The code in the patch looks straight forward, and the
information appears compelling, my question was just about
verification and testing of this code copied from the
webpage before using it to replace something that currently
works.</div>
<div><br>
Regards,</div>
<div><br>
</div>
<div>Peter</div>
</div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On 5 February 2014 08:05,
Daniel-Constantin Mierla <span dir="ltr"><<a
moz-do-not-send="true" href="mailto:miconda@gmail.com"
target="_blank">miconda@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks for
update. Can you wrap your patch in some define, so it can be
applied while keeping the libunistring as alternative?
Something like:<br>
<br>
#ifdef USE_UTF8_EMBEDDED<br>
// your code here<br>
#else<br>
// libunistring function call<br>
#endif<br>
<br>
Then it can be pushed without any problem to the master
branch, allowing me (and others) to test it easily. After
that we can re-evaluate to remove libunistring completely or
maybe just make the embedded version default.<br>
<br>
Cheers,<br>
Daniel
<div class="HOEnZb">
<div class="h5"><br>
<br>
On 05/02/14 07:45, Timo Teras wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
On Tue, 04 Feb 2014 21:34:35 +0100<br>
Daniel-Constantin Mierla <<a moz-do-not-send="true"
href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>>
wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Was there any resolution on this topic? I would like
to get rid of<br>
the unnecessary dependency, the code looked fine at
a quick check --<br>
if it is just about utf8 encoding/decoding.<br>
<br>
Eventually it can be made a compile time switch with
defines for both<br>
options, keep the code for both cases and be able to
easily switch<br>
from one to another.<br>
</blockquote>
I think the patch was not 'blessed' yet.<br>
<br>
Peter asked for testing results along the lines of:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Something as simple as a loop through all possible
values calling your<br>
function, the libunistring function, and comparing
the results would<br>
be perfect.<br>
</blockquote>
The calling the function with every possible utf-8
string is<br>
impossible test plan.<br>
<br>
Dunno. Perhaps you want to push the patch with
dictator hat on, or some<br>
sane test plan can be made. For now, I just applied
the patch to my<br>
local builds and forgot this.<br>
<br>
- Timo<br>
<br>
_______________________________________________<br>
sr-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:sr-dev@lists.sip-router.org"
target="_blank">sr-dev@lists.sip-router.org</a><br>
<a moz-do-not-send="true"
href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev"
target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
</blockquote>
<br>
<br>
</div>
</div>
<div class="HOEnZb">
<div class="h5">
-- <br>
Daniel-Constantin Mierla - <a moz-do-not-send="true"
href="http://www.asipto.com" target="_blank">http://www.asipto.com</a><br>
<a moz-do-not-send="true"
href="http://twitter.com/#%21/miconda" target="_blank">http://twitter.com/#!/miconda</a>
- <a moz-do-not-send="true"
href="http://www.linkedin.com/in/miconda"
target="_blank">http://www.linkedin.com/in/miconda</a><br>
<br>
</div>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
<div dir="ltr">
<div><font face="courier new, monospace">Peter Dunkley</font></div>
<div><font face="courier new, monospace">Technical Director</font></div>
<div><font face="courier new, monospace">Crocodile RCS Ltd</font></div>
</div>
</div>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla - <a class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a>
<a class="moz-txt-link-freetext" href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a> - <a class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a></pre>
</body>
</html>