<div dir="ltr">Daniel,<br><br>What's the contributing policy here? I'm not able to create a pulling request without either pushing a new branch or pushing a changes to any existing one.<br></div><div class="gmail_extra">
<br><br><div class="gmail_quote">2014-07-18 20:02 GMT+04:00 Alekzander Spiridonov <span dir="ltr"><<a href="mailto:alekz@li.ru" target="_blank">alekz@li.ru</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Hmmm.. What's the way of pushing a new branch to github? <br></div><div class="gmail_extra"><br><br><div class="gmail_quote">2014-07-18 12:50 GMT+04:00 Daniel-Constantin Mierla <span dir="ltr"><<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>></span>:<div>
<div class="h5"><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
I prefer one per module, because it is easier to review and keeps
the history cleaner for that module.<br>
<br>
Thanks,<br>
Daniel<div><div><br>
<br>
<div>On 18/07/14 10:45, Alekzander
Spiridonov wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Should I submit patch per module or one for all?
Actually there are numerous cases in kamailio/modules/*<br>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">2014-07-17 22:58 GMT+04:00
Daniel-Constantin Mierla <span dir="ltr"><<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,
<div>
<div><br>
<br>
On 09/07/14 11:00, Alekzander Spiridonov wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi list,<br>
<br>
While going through mod_init's and finding things like<br>
rtpp_table_name.len = strlen(rtpp_table_name.s);<br>
<br>
I became curious if using of deprecated STR_PARAM in
new modules is done on purpose. Why not using
PARAM_STR for string module parameters?<br>
<br>
Quote from sr_module.h:<br>
#define PARAM_STRING (1U<<0) /**< String
(char *) parameter type */<br>
#define PARAM_STR (1U<<2) /**< struct
str parameter type */<br>
#define STR_PARAM PARAM_STRING<br>
<br>
P.S.: That's not only about curiosity but to avoid any
bugs in my kamailio extensions.<br>
</blockquote>
</div>
</div>
Indeed PARAM_STR should be used if the value of the
parameter needs to be stored in a str structure.<br>
<br>
PARAM_STR was introduced by SER developers before joining
back with Kamailio source code, so many developers are not
aware of it.<br>
<br>
We should review and migrate in such cases.<br>
<br>
Cheers,<br>
Daniel<span><font color="#888888"><br>
<br>
-- <br>
Daniel-Constantin Mierla - <a href="http://www.asipto.com" target="_blank">http://www.asipto.com</a><br>
<a href="http://twitter.com/#%21/miconda" target="_blank">http://twitter.com/#!/miconda</a>
- <a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a><br>
<br>
<br>
_______________________________________________<br>
sr-dev mailing list<br>
<a href="mailto:sr-dev@lists.sip-router.org" target="_blank">sr-dev@lists.sip-router.org</a><br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
</font></span></blockquote>
</div>
<br>
<br clear="all">
<br>
-- <br>
<div>
<div>Best regards,<br>
Alekzander Spiridonov</div>
<br>
</div>
</div>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
sr-dev mailing list
<a href="mailto:sr-dev@lists.sip-router.org" target="_blank">sr-dev@lists.sip-router.org</a>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a>
</pre>
</blockquote>
<br>
<pre cols="72">--
Daniel-Constantin Mierla - <a href="http://www.asipto.com" target="_blank">http://www.asipto.com</a>
<a href="http://twitter.com/#!/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a></pre>
</div></div></div>
<br>_______________________________________________<br>
sr-dev mailing list<br>
<a href="mailto:sr-dev@lists.sip-router.org" target="_blank">sr-dev@lists.sip-router.org</a><br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
<br></blockquote></div></div></div><div><div class="h5"><br><br clear="all"><br>-- <br><div><div>Best regards,<br>Alekzander Spiridonov</div><br></div>
</div></div></div>
</blockquote></div><br><br clear="all"><br>-- <br><div><div>Best regards,<br>Alekzander Spiridonov</div><br></div>
</div>