<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello,<br>
<br>
thanks for sending the patch! Two remarks for now:<br>
<br>
1) you changed the inter-module API prototype for ds_select_dst_f,
respectively:<br>
<br>
typedef int (*ds_select_dst_f)(struct sip_msg *msg, int set,<br>
- int alg, int mode);<br>
+ int alg, unsigned int limit, int mode);<br>
<br>
I think the reason for that function is an export to app_lua (and
maybe other embedded languages). With this change, things get broken
there. I would do:<br>
<br>
- rename the function ds_select_dst() to ds_select_dst_limit()<br>
- add ds_select_dst() as a wrapper function calling the new
ds_select_dst_limit()<br>
<br>
The API stay unchanged, and eventually one can add a new member for
ds_select_dst_limit() when needed<br>
<br>
Otherwise, the change of ds_select_dst() prototype should involve
reviewing other modules and seeing if people are happy with this
change, because it breaks existing embedded scripts.<br>
<br>
2) You need to document the new functions exported to kamailio
config, in modules/dispatcher/doc/dispatcher_admin.xml<br>
<br>
Once the patch is overall ok, I can commit it to the repository.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<div class="moz-cite-prefix">On 21/08/14 17:40, Alekzander
Spiridonov wrote:<br>
</div>
<blockquote
cite="mid:CA+=mParovEYEK4YpqR=yWVYm_ZuHfbfw5Y-W1RfchOtw9YcG3Q@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div>Hi list,<br>
<br>
</div>
I'd like to propose a patch that allows user to limit the
number of items that appears in dst_avp after ds_select_dst or
ds_select_domain call.<br>
<br>
</div>
There are some use cases when one could have couple of dst sets
and would like to failover from the first to another without
checking all items but have just 3 or 4 of them dead in a row.<br>
<br>
What do you think about that?<br clear="all">
<br>
-- <br>
<div>
<div>Best regards,<br>
Alekzander Spiridonov</div>
<br>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
sr-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a>
<a class="moz-txt-link-freetext" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla
<a class="moz-txt-link-freetext" href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a> - <a class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a>
Next Kamailio Advanced Trainings 2014 - <a class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a>
Sep 22-25, Berlin, Germany ::: Oct 15-17, San Francisco, USA</pre>
</body>
</html>