<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello,<br>
<br>
patch to json has been pushed.<br>
<br>
Then publish your patch to pua_dialoginfo and pua_mwi module
somewhere (e.g., tracker) and we will review and merge into master
branch.<br>
<br>
For the new pua_mwi module, once reviewd and all looks ok, you can
get git commit access, so you can push it yourself and maintain it
afterwards -- I will send you the appropriate details when it is the
time for it.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<div class="moz-cite-prefix">On 22/08/14 16:00, Luis Azedo wrote:<br>
</div>
<blockquote
cite="mid:CAEvFzR_LRvAgKOqCkiHc+0GBsNzbo4bsUcGynhwrWP0fHEMvrw@mail.gmail.com"
type="cite">
<div dir="ltr">Hi Daniel,
<div><br>
</div>
<div>thank you for your reply.</div>
<div><br>
</div>
<div>regarding mwi and dialoginfo, we are getting/creating the
values that should be published inside the script. </div>
<div><br>
</div>
<div>json module patch below</div>
<div><br>
</div>
<div>
<div>diff --git a/modules/json/json_mod.c
b/modules/json/json_mod.c</div>
<div>index f102927..9fa0ec4 100644</div>
<div>--- a/modules/json/json_mod.c</div>
<div>+++ b/modules/json/json_mod.c</div>
<div>@@ -88,7 +88,7 @@</div>
<div> <span class="" style="white-space:pre"> </span>}</div>
<div> </div>
<div> <span class="" style="white-space:pre"> </span>if
(param_no == 3) {</div>
<div>-<span class="" style="white-space:pre"> </span>return
fixup_free_pvar_null(param, 3);</div>
<div>+<span class="" style="white-space:pre"> </span>return
fixup_free_pvar_null(param, 1);</div>
<div> <span class="" style="white-space:pre"> </span>}</div>
<div> </div>
<div> <span class="" style="white-space:pre"> </span>LM_ERR("invalid
parameter number <%d>\n", param_no);</div>
</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Fri, Aug 22, 2014 at 2:37 PM,
Daniel-Constantin Mierla <span dir="ltr"><<a
moz-do-not-send="true" href="mailto:miconda@gmail.com"
target="_blank">miconda@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> Hello,<br>
<br>
thanks for considering to contribute back to the public
project.<br>
<br>
Do you have the patches on some public server? If yes,
send the link to them here, otherwise the best way is to
upload them on our tracker:<br>
<br>
- <a moz-do-not-send="true"
href="http://sip-router.org/tracker/" target="_blank">http://sip-router.org/tracker/</a><br>
<br>
New features are included only on devel branch (git master
branch). Due to 'stable' branch release policies, new
features are not going to be included in 4.0 and 4.1. Next
major release (4.2) is expected to be out by mid of
October.<br>
<br>
Regarding the new pua_mwi module, considering that
kamailio is not tracking voicemail boxes, how is it
getting the information?<br>
<br>
And yes, that seems to be a bug in fixup_get_field_free()
function, make a git patch for it, send here and I will
push it.<br>
<br>
Cheers,<br>
Daniel
<div>
<div class="h5"><br>
<br>
<div>On 22/08/14 15:11, Luis Azedo wrote:<br>
</div>
</div>
</div>
<blockquote type="cite">
<div>
<div class="h5">
<div dir="ltr">hi ,
<div><br>
</div>
<div>i would like to submit a patch to
pua_dialoginfo to expose the dialog_publish
function to the script so that we can configure
something like this in the script.</div>
<div><br>
</div>
<div> route[MY_ROUTE]<br>
<div>{</div>
</div>
<div> pua_dialoginfo_publish(.......)</div>
<div>}</div>
<div><br>
</div>
<div>i also want to provide a new module pua_mwi
that publishes mwi info.</div>
<div><br>
</div>
<div>what's the proper flow to submit this ? i
want to submit it to 4.0 and 4.1 branch.</div>
<div><br>
</div>
<div><br>
</div>
<div>also, there seems to be a bug in json module
on fixup_get_field_free function</div>
<div>
<div><span style="white-space:pre-wrap"> </span>if
(param_no == 3) {</div>
<div><span style="white-space:pre-wrap"> </span>return
fixup_free_pvar_null(param, 3); <<<==
shouldn't this be 1 ?</div>
<div><span style="white-space:pre-wrap"> </span>}</div>
</div>
<div><br>
</div>
<div><br>
</div>
<div>thanks</div>
<div><br>
</div>
</div>
<br>
<fieldset></fieldset>
<br>
</div>
</div>
<pre>_______________________________________________
sr-dev mailing list
<a moz-do-not-send="true" href="mailto:sr-dev@lists.sip-router.org" target="_blank">sr-dev@lists.sip-router.org</a>
<a moz-do-not-send="true" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><span class="HOEnZb"><font color="#888888">
</font></span></pre>
<span class="HOEnZb"><font color="#888888"> </font></span></blockquote>
<span class="HOEnZb"><font color="#888888"> <br>
<pre cols="72">--
Daniel-Constantin Mierla
<a moz-do-not-send="true" href="http://twitter.com/#%21/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a moz-do-not-send="true" href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a>
Next Kamailio Advanced Trainings 2014 - <a moz-do-not-send="true" href="http://www.asipto.com" target="_blank">http://www.asipto.com</a>
Sep 22-25, Berlin, Germany ::: Oct 15-17, San Francisco, USA</pre>
</font></span></div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla
<a class="moz-txt-link-freetext" href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a> - <a class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a>
Next Kamailio Advanced Trainings 2014 - <a class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a>
Sep 22-25, Berlin, Germany ::: Oct 15-17, San Francisco, USA</pre>
</body>
</html>