<div dir="ltr">Daniel, <div><br></div><div>Yes…just verified your patch and it looks good.</div><div><br></div><div>thanks </div><div>bsingh</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Sep 2, 2014 at 1:33 AM, Daniel-Constantin Mierla <span dir="ltr"><<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
Hello,<br>
<br>
thanks for troubleshooting further. I pushed a different patch, as
your suggestion was causing to go again from the beginning of sent
list each time, until there was no more sent-ok message.<br>
<br>
Can you try the patch from commit:<br>
<br>
-
<a href="http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5fd8a1bdaae82decdb606901fe7bf3e6e9149803" target="_blank">http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5fd8a1bdaae82decdb606901fe7bf3e6e9149803</a><br>
<br>
If all ok, I will backport.<br>
<br>
Cheers,<br>
Daniel<div><div class="h5"><br>
<br>
<div>On 02/09/14 09:36, Bhupendra Singh
wrote:<br>
</div>
</div></div><blockquote type="cite"><div><div class="h5">
<div dir="ltr">Hello Folks,
<div><br>
</div>
<div>I found the root cause of this issue. </div>
<div><br>
</div>
<div>In file ms_msg_list.c, issue is on line 290.</div>
<div>(<a href="https://github.com/sipwise/kamailio/blob/master/modules/msilo/ms_msg_list.c" target="_blank">https://github.com/sipwise/kamailio/blob/master/modules/msilo/ms_msg_list.c</a>)<br>
</div>
<div><br>
</div>
<div><br>
</div>
<div><span style="white-space:pre-wrap">Line 290: </span>p0
= p0->next; </div>
<div><br>
</div>
<div>should be like this below :</div>
<div><br>
</div>
<div><span style="white-space:pre-wrap"> </span>p0 =
ml->lsent;<br>
</div>
<div><br>
</div>
<div><br>
</div>
<div>The issue is p0->next becomes null in first iteration so
it won't process more than one element in 'while' loop. Hence
this is the main cause of slowness of message deletion. </div>
<div>I have tested modified code and it works fine now. </div>
<div><br>
</div>
<div>Develoerps, </div>
<div>Please review this change and advise accordingly.</div>
<div><br>
</div>
<div>Thanks </div>
</div>
<div class="gmail_extra">
<br>
<br>
<div class="gmail_quote">On Mon, Aug 25, 2014 at 11:35 PM,
Bhupendra Singh <span dir="ltr"><<a href="mailto:bsingh@bsingh.net" target="_blank">bsingh@bsingh.net</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div>Hi Guys, </div>
<div><br>
</div>
<div>Has anyone used/using offline message handling and
storage in "silo" table?</div>
<div>My issue is cleanup of stored message is taking very
long time specially when many messages are left for
target users. </div>
<div>After further investigation I realized, only one
message gets deleted in one pass and next in next pass (
after 30 second default timer). </div>
<div>Is it intentional ? How can we make sure that all
delivered messages get deleted right away for that
user? </div>
<div><br>
</div>
<div>Thanks</div>
<div><br>
</div>
<div><br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset></fieldset>
<br>
</div></div><pre>_______________________________________________
sr-dev mailing list
<a href="mailto:sr-dev@lists.sip-router.org" target="_blank">sr-dev@lists.sip-router.org</a>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><span class="HOEnZb"><font color="#888888">
</font></span></pre><span class="HOEnZb"><font color="#888888">
</font></span></blockquote><span class="HOEnZb"><font color="#888888">
<br>
<pre cols="72">--
Daniel-Constantin Mierla
<a href="http://twitter.com/#!/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a>
Next Kamailio Advanced Trainings 2014 - <a href="http://www.asipto.com" target="_blank">http://www.asipto.com</a>
Sep 22-25, Berlin, Germany ::: Oct 15-17, San Francisco, USA</pre>
</font></span></div>
</blockquote></div><br></div>