<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello,<br>
<br>
the patch to registrar module looks ok, so you can push it as well.<br>
<br>
Also the patch to tm seems to touch only a bit existing code,
respectively:<br>
- export add_uac() function - remove its static constraints and
adding the prototype to a header file<br>
- keep branch route id in a new field to be used for executing the
branch_route for new branches added later<br>
<br>
Then it is the new function you added, but it doesn't affect the
existing code.<br>
<br>
Assuming I got the tm patch right, then it is safe to be pushed as
well, with some remarks: the copyright at the top of new added files
seems to be taken from other existing files, giving the right to
someone else than you, also for an old year. You have to update that
and also for the tm code, license for new contributions has to be
bsd.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<div class="moz-cite-prefix">On 10/09/14 10:25, Federico Cabiddu
wrote:<br>
</div>
<blockquote
cite="mid:CAFOaF_hHkP5BTvfoqwKadwB=6Gy=NWJj+Bpf0b32fCWgM6VCQQ@mail.gmail.com"
type="cite">
<div dir="ltr">Hi Daniel and Kamailio developers,
<div>here are the two patches for registrar and tm modules
needed by the tsilo module.</div>
<div><br>
</div>
<div>Looking forward to hearing your feedback.</div>
<div><br>
</div>
<div>Regards,</div>
<div><br>
</div>
<div>Federico</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Sep 10, 2014 at 9:22 AM,
Daniel-Constantin Mierla <span dir="ltr"><<a
moz-do-not-send="true" href="mailto:miconda@gmail.com"
target="_blank">miconda@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> Hi Federico,<br>
<br>
thanks for this contribution! We will grant you write
access to the git repository to push and maintain your new
module.<br>
<br>
I will review the patches for registrar and tm modules.
For sake of everyone having a chance to look at them, can
you send the patches to this mailing list?<br>
<br>
Cheers,<br>
Daniel
<div>
<div class="h5"><br>
<br>
<div>On 10/09/14 07:36, Federico Cabiddu wrote:<br>
</div>
</div>
</div>
<blockquote type="cite">
<div>
<div class="h5">
<div dir="ltr">Hi all Kamailio developers,
<div>I would like to propose a new module that
I've written recently, the tsilo module where
tsilo stands for "transaction silo" (thanks
Daniel for suggesting the name). The module
provides the ability to add branches to a
transaction that has already been relayed and
still hasn't got a final response. It achieves
it by storing in an internal table a list of
transactions per r-uri. </div>
<div><br>
</div>
<div>The scenarios for which this functionality
has been originally though are those in which a
user's device is usually not registered on
kamailio but, in case of incoming invite, can be
"waken up" (and so trigger its registration) by
means of mechanisms other than SIP; typically
scenarios involving APN, GCM or other push
mechanisms.</div>
<div><br>
</div>
<div>The module exposes 3 functions to
configuration script:</div>
<div><br>
</div>
<div>- t_store(): store the current transaction </div>
<div>- t_append(domain, ruri): append branches to
all the transactions existing for "ruri" looking
up new contacts in "domain" table</div>
<div>- t_append_to(tindex, tlabel, domain): append
branches to transaction identified by tindex and
tlabel looking up new contacts in "domain" table</div>
<div><br>
</div>
<div>The module depends on tm and registrar module
on which some modifications have been done:</div>
<div><br>
</div>
<div>registrar: new api function update_to_dset to
update the dset without rewriting the r-uri</div>
<div>tm: new api function t_append_branches and
some modifications on t_fwd.* to implement it<br>
</div>
<div><br>
</div>
<div>I hope that this contribution could be useful
for the community and I look forward to hearing
your feedback, thoughts, suggestions.</div>
<div><br>
</div>
<div>Best regards,</div>
<div><br>
</div>
<div>Federico Cabiddu </div>
<div><br>
</div>
</div>
<br>
<fieldset></fieldset>
<br>
</div>
</div>
<pre>_______________________________________________
sr-dev mailing list
<a moz-do-not-send="true" href="mailto:sr-dev@lists.sip-router.org" target="_blank">sr-dev@lists.sip-router.org</a>
<a moz-do-not-send="true" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><span class="HOEnZb"><font color="#888888">
</font></span></pre>
<span class="HOEnZb"><font color="#888888"> </font></span></blockquote>
<span class="HOEnZb"><font color="#888888"> <br>
<pre cols="72">--
Daniel-Constantin Mierla
<a moz-do-not-send="true" href="http://twitter.com/#%21/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a moz-do-not-send="true" href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a>
Next Kamailio Advanced Trainings 2014 - <a moz-do-not-send="true" href="http://www.asipto.com" target="_blank">http://www.asipto.com</a>
Sep 22-25, Berlin, Germany</pre>
</font></span></div>
<br>
_______________________________________________<br>
sr-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a><br>
<a moz-do-not-send="true"
href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev"
target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla
<a class="moz-txt-link-freetext" href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a> - <a class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a>
Next Kamailio Advanced Trainings 2014 - <a class="moz-txt-link-freetext" href="http://www.asipto.com">http://www.asipto.com</a>
Sep 22-25, Berlin, Germany</pre>
</body>
</html>