<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 17/09/14 15:38, Federico Cabiddu
wrote:<br>
</div>
<blockquote
cite="mid:CAFOaF_gPhA-3aMF3uSkYk3b=9e8A01LAWaQhXBLcsB61=oD36A@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Sep 17, 2014 at 1:09 PM,
Daniel-Constantin Mierla <span dir="ltr"><<a
moz-do-not-send="true" href="mailto:miconda@gmail.com"
target="_blank">miconda@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"><span
class=""><br>
On 17/09/14 13:01, Olle E. Johansson wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
On 17 Sep 2014, at 12:54, Daniel-Constantin Mierla
<<a moz-do-not-send="true"
href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>>
wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Hello,<br>
<br>
historically 'tm' stays for 'transaction management'
-- the the x for the other module was for
eXtensions.<br>
<br>
The new module doesn't really do any management of
transaction, but store structures that include the
id of transactions with custom info (at this moment
an AoR). It has a completely different hash table in
memory (so nothing new in tm structure). Internally
it binds to tm to get some callbacks executed, but
also to registrar module for getting access to new
branches.<br>
<br>
Being in relation only with Transaction, storing
some extra info for it, not sure the 'm' makes sense
to add.<br>
</blockquote>
The whole idea seems to be to manipulate a transaction
- add a branch to an existing transaction, so the "m"
certainly makes sense to me... ;-)<br>
</blockquote>
</span>
Well, somehow around that but not exactly :-) -- because
the function doing that is in tm, added by commit:
468a2c645f5fcb66376b81b06e69eb8f5377bb02<br>
<br>
The tsilo module just calls it internally via tm api. The
module is managing an internal hash table, acting on some
callbacks from tm and calling functions from registrar and
tm. There are many other modules calling functions from tm
(e.g., dialog, msilo, ...).<br>
<br>
But maybe the functions of the module should be renamed to
use the prefix ts_ instead of t_.<br>
</blockquote>
<div><br>
</div>
<div>I'm fine with this change if you feel that it would be
better. Just let me know if I have to proceed with the
change.</div>
</div>
</div>
</div>
</blockquote>
I think it would be more clear with a prefix like ts_, you can go
ahead and do the changes.<br>
<br>
Cheers,<br>
Daniel<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla
<a class="moz-txt-link-freetext" href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a> - <a class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a></pre>
</body>
</html>