<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
I was actually thinking of it, but couldn't get to a clear
conclusion before ...<br>
<br>
Overall, I am not sure if making white or black is the best. I see
it more of a per case situation.<br>
<br>
For example, usrloc is a standalone component by itself, with
registrar being the interface to kamailio.cfg, then pua_usrloc or
pua_reginfo being the presence events publishing. Being such a
component used in various directions, I think it should stay rather
independent, not getting extra stuff inside, but other components
can be built on top of its exported API.<br>
<br>
On the other hand, just adding a new module for each other module
that wants to notify via dmq could be an unnecessary overhead.<br>
<br>
So, at this moment, I would say, if the module has everything that
is needed exported via API, the dmq can be done as separate module.
Also, if the module is very sensitive, I would suggest the same
approach (e.g., I wouldn't like to see it inside tm module, if
someone thinks of dmq-ing transactions, but rather a separate module
or part of tmx).<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<br>
<div class="moz-cite-prefix">On 29/10/14 19:38, Charles Chance
wrote:<br>
</div>
<blockquote
cite="mid:CAOvxgzCkUan2PEAKADXJv5hbud52H8N4=uCcODux2u_E1ZafeQ@mail.gmail.com"
type="cite">
<div dir="ltr">Maybe others can offer their advice as to which is
the preferred way to go?
<div><br>
</div>
<div><br>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On 28 October 2014 14:40, Andrey
Rybkin <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:rybkin.a@bks.tv" target="_blank">rybkin.a@bks.tv</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div style="font-family:arial,sans-serif;font-size:13px"><font
face="Arial, sans-serif"><span
style="font-size:14px;line-height:18px;white-space:pre-wrap">Thought
about to add this functionality to the module. If
this approach seems to be more correct, then I can
move my code in a module, but, in my opinion, it
is not very correct.</span></font></div>
<div style="font-family:arial,sans-serif;font-size:13px">
<div class="gmail_extra">
<div dir="ltr"><span
style="line-height:18.2000007629395px;color:rgb(102,102,102);font-family:Arial,Tahoma,Verdana,sans-serif;font-size:small">________________________________</span><br>
</div>
</div>
</div>
<div class="gmail_extra"><span class="">
<div>
<div dir="ltr">
<div><font color="#666666" face="Arial, Tahoma,
Verdana, sans-serif"><span
style="line-height:18.2000007629395px">Andrey
Rybkin</span></font></div>
<div><span
style="line-height:18.2000007629395px;color:rgb(102,102,102);font-family:Arial,Tahoma,Verdana,sans-serif">JID:
</span><a moz-do-not-send="true"
href="mailto:rybkin.a@bks.tv"
style="line-height:18.2000007629395px;font-family:Arial,Tahoma,Verdana,sans-serif"
target="_blank">rybkin.a@bks.tv</a><br>
</div>
<div><font color="#666666" face="Arial, Tahoma,
Verdana, sans-serif"><span
style="line-height:18.2000007629395px">E-Mail:
<a moz-do-not-send="true"
href="mailto:rybkin.a@bks.tv"
target="_blank">rybkin.a@bks.tv</a></span></font></div>
<div><br>
</div>
</div>
</div>
</span>
<div>
<div class="h5">
<div class="gmail_quote">2014-10-28 16:46
GMT+03:00 Alex Hermann <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:alex@speakup.nl"
target="_blank">alex@speakup.nl</a>></span>:<br>
<blockquote class="gmail_quote"
style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span>On
Tuesday 28 October 2014, Андрей Рыбкин
wrote:<br>
> Module DMQ_SYNC:<br>
> The module add replication between
multiple servers via DMQ module.<br>
> Currently only usrloc replications.<br>
<br>
</span>I think some decision should be made on
where syncing code should be placed.<br>
The htable module has dmq sync integrated, now
you introduce a module<br>
dedicated to syncing via dmq.<br>
<br>
I have no strong preference, but am against
different implementations<br>
depending on the module. So i would prefer
either dmq-sync integrated into<br>
each module, or one dmq_sync module. Not a
combination of both.<br>
<span><br>
<br>
> TODO:<br>
> 1. dialog replications.<br>
> 2. bugfixes.<br>
><br>
> Patch fo DMQ:<br>
> 1. add find_dmq_node_uri function to
API<br>
> dmq_node_t* find_dmq_node_uri(str*
uri)<br>
<br>
> 2. add init_callback to dmq_peer<br>
> int init_callback()<br>
<br>
</span>Except for the broken indenting, this
seems equal to my code. If it is mine,<br>
and the code is useful, please cherry-pick the
relevant commits so authorship<br>
is retained.<br>
<span><font color="#888888"><br>
--<br>
Greetings,<br>
<br>
Alex Hermann<br>
<br>
</font></span></blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
<br>
_______________________________________________<br>
sr-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a><br>
<a moz-do-not-send="true"
href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev"
target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
<br>
</blockquote>
</div>
<br>
<br>
</div>
</div>
<br>
<font face="Helvetica, Arial, sans-serif"><font size="2"><span
style="font-size:10pt"><a moz-do-not-send="true"
href="http://www.sipcentric.com/"
title="blocked::http://www.sipcentric.com/"
target="_blank">www.sipcentric.com</a><br>
<br>
Follow us on twitter <a moz-do-not-send="true"
href="http://twitter.com/sipcentric"
title="blocked::http://twitter.com/sipcentric"
target="_blank">@sipcentric</a><br>
<br>
<font color="gray">Sipcentric Ltd. Company registered in
England & Wales no. 7365592.</font> <font color="gray">Registered
office: Faraday Wharf, Innovation Birmingham Campus, Holt
Street, Birmingham Science Park, Birmingham B7 4BB.</font></span></font></font>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
sr-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a>
<a class="moz-txt-link-freetext" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla
<a class="moz-txt-link-freetext" href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a> - <a class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a></pre>
</body>
</html>