<p dir="ltr">Hi Andrey,</p>
<p dir="ltr">I will get to it later today.</p>
<p dir="ltr">Cheers,<br>
Charles<br>
</p>
<div class="gmail_quote">On 13 Nov 2014 09:15, "Andrey Rybkin" <<a href="mailto:rybkin.a@bks.tv">rybkin.a@bks.tv</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hello, Charles!<div><br></div><div>Can you commit my patch to your DMQ module?<br><div class="gmail_extra"><br clear="all"><div><div><div dir="ltr"><div><font face="Arial, Tahoma, Verdana, sans-serif" color="#666666"><span style="line-height:18.2000007629395px">________________________________</span></font></div><div><font face="Arial, Tahoma, Verdana, sans-serif" color="#666666"><span style="line-height:18.2000007629395px">Andrey Rybkin</span></font></div><div><font face="Arial, Tahoma, Verdana, sans-serif" color="#666666"><span style="line-height:18.2000007629395px">JID: <a href="mailto:rybkin.a@bks.tv" target="_blank">rybkin.a@bks.tv</a></span></font></div><div><font face="Arial, Tahoma, Verdana, sans-serif" color="#666666"><span style="line-height:18.2000007629395px">E-Mail: <a href="mailto:rybkin.a@bks.tv" target="_blank">rybkin.a@bks.tv</a></span></font></div><div><br></div></div></div></div><div class="gmail_quote">2014-10-29 21:38 GMT+03:00 Charles Chance <span dir="ltr"><<a href="mailto:charles.chance@sipcentric.com" target="_blank">charles.chance@sipcentric.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Maybe others can offer their advice as to which is the preferred way to go?<div><br></div><div><br></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div>On 28 October 2014 14:40, Andrey Rybkin <span dir="ltr"><<a href="mailto:rybkin.a@bks.tv" target="_blank">rybkin.a@bks.tv</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div dir="ltr"><div style="font-family:arial,sans-serif;font-size:13px"><font face="Arial, sans-serif"><span style="font-size:14px;line-height:18px;white-space:pre-wrap">Thought about to add this functionality to the module. If this approach seems to be more correct, then I can move my code in a module, but, in my opinion, it is not very correct.</span></font></div><div style="font-family:arial,sans-serif;font-size:13px"><div class="gmail_extra"><div dir="ltr"><span style="line-height:18.2000007629395px;color:rgb(102,102,102);font-family:Arial,Tahoma,Verdana,sans-serif;font-size:small">________________________________</span><br></div></div></div><div class="gmail_extra"><span><div><div dir="ltr"><div><font color="#666666" face="Arial, Tahoma, Verdana, sans-serif"><span style="line-height:18.2000007629395px">Andrey Rybkin</span></font></div><div><span style="line-height:18.2000007629395px;color:rgb(102,102,102);font-family:Arial,Tahoma,Verdana,sans-serif">JID: </span><a href="mailto:rybkin.a@bks.tv" style="line-height:18.2000007629395px;font-family:Arial,Tahoma,Verdana,sans-serif" target="_blank">rybkin.a@bks.tv</a><br></div><div><font face="Arial, Tahoma, Verdana, sans-serif" color="#666666"><span style="line-height:18.2000007629395px">E-Mail: <a href="mailto:rybkin.a@bks.tv" target="_blank">rybkin.a@bks.tv</a></span></font></div><div><br></div></div></div></span><div><div><div class="gmail_quote">2014-10-28 16:46 GMT+03:00 Alex Hermann <span dir="ltr"><<a href="mailto:alex@speakup.nl" target="_blank">alex@speakup.nl</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span>On Tuesday 28 October 2014, Андрей Рыбкин wrote:<br>
> Module DMQ_SYNC:<br>
> The module add replication between multiple servers via DMQ module.<br>
> Currently only usrloc replications.<br>
<br>
</span>I think some decision should be made on where syncing code should be placed.<br>
The htable module has dmq sync integrated, now you introduce a module<br>
dedicated to syncing via dmq.<br>
<br>
I have no strong preference, but am against different implementations<br>
depending on the module. So i would prefer either dmq-sync integrated into<br>
each module, or one dmq_sync module. Not a combination of both.<br>
<span><br>
<br>
> TODO:<br>
> 1. dialog replications.<br>
> 2. bugfixes.<br>
><br>
> Patch fo DMQ:<br>
> 1. add find_dmq_node_uri function to API<br>
> dmq_node_t* find_dmq_node_uri(str* uri)<br>
<br>
> 2. add init_callback to dmq_peer<br>
> int init_callback()<br>
<br>
</span>Except for the broken indenting, this seems equal to my code. If it is mine,<br>
and the code is useful, please cherry-pick the relevant commits so authorship<br>
is retained.<br>
<span><font color="#888888"><br>
--<br>
Greetings,<br>
<br>
Alex Hermann<br>
<br>
</font></span></blockquote></div><br></div></div></div></div>
<br></div></div>_______________________________________________<br>
sr-dev mailing list<br>
<a href="mailto:sr-dev@lists.sip-router.org" target="_blank">sr-dev@lists.sip-router.org</a><br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
<br></blockquote></div><br><br>
</div></div>
<br>
<font face="Helvetica, Arial, sans-serif"><font><span style="font-size:10pt"><a href="http://www.sipcentric.com/" title="blocked::http://www.sipcentric.com/" target="_blank">www.sipcentric.com</a><br>
<br>
Follow us on twitter <a href="http://twitter.com/sipcentric" title="blocked::http://twitter.com/sipcentric" target="_blank">@sipcentric</a><br>
<br>
<font color="gray">Sipcentric Ltd.
Company registered in England & Wales no. 7365592.</font> <font color="gray">Registered
office: Faraday Wharf, Innovation Birmingham Campus, Holt Street, Birmingham Science Park, Birmingham B7 4BB.</font></span></font></font><br>_______________________________________________<br>
sr-dev mailing list<br>
<a href="mailto:sr-dev@lists.sip-router.org" target="_blank">sr-dev@lists.sip-router.org</a><br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
<br></blockquote></div><br></div></div></div>
</blockquote></div>
<br>
<font face="Helvetica, Arial, sans-serif"><font size="2"><span style="font-size:10pt"><a href="http://www.sipcentric.com/" title="blocked::http://www.sipcentric.com/" target="_blank">www.sipcentric.com</a><br>
<br>
Follow us on twitter <a href="http://twitter.com/sipcentric" title="blocked::http://twitter.com/sipcentric" target="_blank">@sipcentric</a><br>
<br>
<font color="gray">Sipcentric Ltd.
Company registered in England & Wales no. 7365592.</font> <font color="gray">Registered
office: Faraday Wharf, Innovation Birmingham Campus, Holt Street, Birmingham Science Park, Birmingham B7 4BB.</font></span></font></font>