<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 08/12/14 16:40, Charles Chance
wrote:<br>
</div>
<blockquote
cite="mid:CAOvxgzA2irYN3NsGVm7mRw1k_fx3ZTVOANyE_15akpPjXKTkOA@mail.gmail.com"
type="cite">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">On 8 December 2014 at 15:09, Olle E.
Johansson <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:oej@edvina.net" target="_blank">oej@edvina.net</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><br>
<div><span>
<div>On 08 Dec 2014, at 16:00, Charles Chance <<a
moz-do-not-send="true"
href="mailto:charles.chance@sipcentric.com"
target="_blank">charles.chance@sipcentric.com</a>>
wrote:</div>
<br>
<blockquote type="cite">
<div dir="ltr">
<div>Hi Olle,</div>
<div><br>
</div>
msg_apply_changes() is for getting the Path
saved the first place if adding/saving on the
same instance.
<div><br>
</div>
<div>My patch is for later on, to avoid looping
if lookup is performed on the same instance
that received the register.</div>
<div><br>
</div>
<div>Scenario is 2 x registrar/location servers,
both sharing common DB - no separate edge
proxies, but each adds itself as Path before
saving (which is where msg_apply_changes()
comes in).</div>
</div>
</blockquote>
</span>Can't you sort that out in the routing script?
I don't see why we need to add this in the code... </div>
<div><br>
</div>
<div>If the topmost, leftmost routing header in the
outbound INVITE points to me, remove it and move on.</div>
<div>You have the branch route for that kind of
manipulation.</div>
<div><br>
</div>
<div>What am I missing?</div>
</div>
</blockquote>
</div>
</div>
</div>
</blockquote>
<br>
If I got it right upon quick read, this case is not trivial to
handle via config file -- i.e., it is about saving registration with
local address as a Path, the registration can be read by same proxy
or another one (the other will have to send the register to this
instance, this one will need to ignore the path).<br>
<br>
After lookup("location"), the first Path appears as outbound proxy
address ($du / dst_uri), but it is also added in the lumps to be a
Route header for outgoing INVITE. If there are more than on Path
header, things can get quite complex to handle from config and might
be easier to simplify by adding a module parameter to enable/disable
the proposed patch.<br>
<br>
Cheers,<br>
Daniel<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla
<a class="moz-txt-link-freetext" href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a> - <a class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a></pre>
</body>
</html>