<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello,<br>
<br>
<div class="moz-cite-prefix">On 08/01/15 11:58, Jason Penton wrote:<br>
</div>
<blockquote
cite="mid:CALoGXNVvFup8HW6zvpq5YyZ1k_UN9d=p6wB=5bT0f=Q3DYWeEw@mail.gmail.com"
type="cite">Hey Daniel,<br>
<br>
The problem in the case I have noticed is that some UEs are taking
the contact from the 200OK and all subsequent requests from the
UEs have the alias in (when leaving UE). This causes problems in
the routing as a result of the same alias being added multiple
times.....</blockquote>
<br>
do you add the alias also for requests within the dialog?<br>
<blockquote
cite="mid:CALoGXNVvFup8HW6zvpq5YyZ1k_UN9d=p6wB=5bT0f=Q3DYWeEw@mail.gmail.com"
type="cite">
<div><br>
</div>
<div>If you are happy with the general concept I'd like to add
this patch but with addition of:</div>
<div>1. configurable parameter to enable (disabled by default)</div>
</blockquote>
<br>
OK.<br>
<br>
<blockquote
cite="mid:CALoGXNVvFup8HW6zvpq5YyZ1k_UN9d=p6wB=5bT0f=Q3DYWeEw@mail.gmail.com"
type="cite">
<div>2. make the check more intelligent to check you are not
adding *exactly* the same alias again.... (which would be
pointless)</div>
</blockquote>
<br>
Make it a different patch to be able to review it.<br>
<br>
I remember at some point I needed to force adding the alias with
same ip/port as the contact, because of a broken ALG changing the
URI, but leaving the parameters alone, so I could recover the proper
values from the alias.<br>
<br>
Cheers,<br>
Daniel<br>
<blockquote
cite="mid:CALoGXNVvFup8HW6zvpq5YyZ1k_UN9d=p6wB=5bT0f=Q3DYWeEw@mail.gmail.com"
type="cite">
<div><br>
</div>
<div>?</div>
<div><br>
</div>
<div>Cheers</div>
<div>Jason</div>
<br>
<div class="gmail_quote">On Thu Jan 08 2015 at 12:34:30
Daniel-Constantin Mierla <<a moz-do-not-send="true"
href="mailto:miconda@gmail.com">miconda@gmail.com</a>>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> Hello,<br>
<br>
there are two functions, add_contact_alias() and
set_contact_alias(), fist added by Juha and the second by
me.<br>
<br>
Is that really needed, because if couple of sip nodes add
that parameter, then expect that each node will handle it. <br>
<br>
A --- P1 --- P2 --- P3 --- B<br>
<br>
If P1 is adding by P2 is processing as well, then it will
mess up routing. I think by the order they are added, they
are going to be processed ok even many nodes are adding it.<br>
<br>
If there is no safe around detecting if alias was added
locally in handle_ruri_alias(), then this patch behaviour
should be made configurable if still wanted.<br>
<br>
Cheers,<br>
Daniel</div>
<div bgcolor="#FFFFFF" text="#000000"><br>
<br>
<div>On 08/01/15 09:09, Jason Penton wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hi,
<div><br>
</div>
<div>I assume this will be for Juha or Maxim, but I
would like to suggest the following patch for
nathelper to ensure that the alias is not added if it
already exists in the contact uri.</div>
<div><br>
</div>
<div>Juha, Maxim as this is your module are you happy
with this?</div>
<div><br>
</div>
<div>Cheers</div>
<div>Jason<br clear="all">
<div><br>
</div>
-- <br>
<div>
<div dir="ltr">
<div>
<table style="width:450pt" border="0"
cellpadding="0" cellspacing="0" width="600">
<tbody>
<tr>
<td style="padding:0cm" valign="top"><br>
</td>
</tr>
</tbody>
</table>
<table style="font-family:monospace" border="0"
cellpadding="0" cellspacing="0" width="320px">
<tbody>
<tr>
<td
style="font-family:Arial,sans-serif;font-size:16px;color:rgb(117,179,67);line-height:18px;padding-left:15px;padding-top:10px"><strong>Jason
Penton</strong></td>
</tr>
<tr>
<td
style="font-family:Arial,sans-serif;font-size:16px;color:rgb(117,179,67);line-height:18px;padding-left:15px;padding-top:10px"><strong>Senior
Manager: Applications and Services</strong></td>
</tr>
<tr>
<td
style="font-family:Arial,sans-serif;font-size:16px;color:rgb(134,145,154);line-height:18px;padding-left:15px;padding-top:10px"><strong>Smile
Communications Pty (Ltd)</strong></td>
</tr>
<tr>
<td>
<table cellpadding="0" cellspacing="0"
width="100%">
<tbody>
<tr>
<td
style="font-family:Arial,sans-serif;font-size:16px;color:rgb(134,145,154);line-height:18px;padding-left:15px;padding-top:10px"
width="27%"><strong>Mobile:</strong></td>
<td
style="font-family:Arial,sans-serif;font-size:16px;color:rgb(134,145,154);line-height:18px;padding-left:10px;padding-top:10px"
width="73%">+27 (0) 83 283 7000</td>
</tr>
<tr>
<td
style="font-family:Arial,sans-serif;font-size:16px;color:rgb(134,145,154);line-height:18px;padding-left:15px;padding-top:10px"><strong>Skype:</strong></td>
<td
style="font-family:Arial,sans-serif;font-size:16px;color:rgb(134,145,154);line-height:18px;padding-left:10px;padding-top:10px">jason.barry.penton</td>
</tr>
</tbody>
</table>
</td>
</tr>
<tr>
<td
style="font-family:Arial,sans-serif;font-size:16px;color:rgb(117,179,67);line-height:18px;padding-left:15px;padding-top:10px"><a
moz-do-not-send="true"
href="mailto:name.surname@smilecoms.com"
style="font-family:Arial;color:rgb(117,179,67);text-decoration:none"
target="_blank">jason.penton@smilecoms.com</a></td>
</tr>
<tr>
<td
style="font-family:Arial,sans-serif;font-size:16px;color:rgb(117,179,67);line-height:18px;padding-left:15px;padding-top:10px"><a
moz-do-not-send="true"
href="http://www.smilecoms.com/"
style="font-family:Arial;color:rgb(117,179,67)"
target="_blank">www.smilecoms.com</a><br>
<img moz-do-not-send="true"
src="http://196.33.227.129/%7Esmlcoms/sigs/pty/images/smile_signature_07_09.jpg"
height="144" width="420"><br>
</td>
</tr>
</tbody>
</table>
</div>
<br>
</div>
</div>
</div>
</div>
<br>
<span><font color="#888888">
<pre>This email is subject to the disclaimer of Smile Communications at <a moz-do-not-send="true" href="http://www.smilecoms.com/home/email-disclaimer/" target="_blank">http://www.smilecoms.com/home/email-disclaimer/</a></pre>
</font></span> <br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
sr-dev mailing list
<a moz-do-not-send="true" href="mailto:sr-dev@lists.sip-router.org" target="_blank">sr-dev@lists.sip-router.org</a>
<a moz-do-not-send="true" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a>
</pre>
</blockquote>
<br>
</div>
<div bgcolor="#FFFFFF" text="#000000">
<pre cols="72">--
Daniel-Constantin Mierla
<a moz-do-not-send="true" href="http://twitter.com/#%21/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a moz-do-not-send="true" href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a></pre>
</div>
_______________________________________________<br>
sr-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:sr-dev@lists.sip-router.org" target="_blank">sr-dev@lists.sip-router.org</a><br>
<a moz-do-not-send="true"
href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev"
target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
</blockquote>
</div>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla
<a class="moz-txt-link-freetext" href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a> - <a class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a></pre>
</body>
</html>