<p dir="ltr">Yes, given that it is possible to do between branches of the same repo, I vote for it being preferred also.</p>
<p dir="ltr">Thanks again,</p>
<p dir="ltr">Charles<br>
</p>
<div class="gmail_quote">On 9 Jan 2015 18:21, "Daniel-Constantin Mierla" <<a href="mailto:miconda@gmail.com">miconda@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<br>
<div>On 09/01/15 19:00, Charles Chance
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hey Victor,<br>
<div class="gmail_extra"><br>
<div class="gmail_quote">On 9 January 2015 at 17:57, Victor
Seva <span dir="ltr"><<a href="mailto:linuxmaniac@torreviejawireless.org" target="_blank">linuxmaniac@torreviejawireless.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On 01/09/2015 06:54 PM, Charles Chance wrote:<br>
> Would anyone like to review the final changes,
before I merge them into<br>
> master?<br>
<br>
</span>I usually use pull-request to get some feedback.
Just my 2 cents.<br>
<br>
</blockquote>
<div><br>
</div>
<div>Thanks - are pull requests the preferred choice now
we're on GitHub?</div>
<br>
</div>
</div>
</div>
</blockquote>
For external contributors (no direct commit access), probably is
more convenient due to the option to review and make comments inline
the patch.<br>
<br>
Otherwise, it can be from case to case, more or less the preference
of the developer. If it something that needs a larger review,
probably the pull request web interface on github offers more tools
and ensures that the discussion is not lost on mailing list.
Practically is like alternative to what we used to open a bug
tracker item for a patch.<br>
<br>
It seems it allows to do pull requests even from branches of
kamailio project, as I can see you did the pull request already. I
expected that it required to fork the repository on personal github
account, do changes and then make the pull request. That would have
been heavy in my opinion for devs with commit access.<br>
<br>
Given the above, I would consider pull requests as 'preferred'
instead of opening tracker issues with patches. But again, not
enforced (or at least not now, until majority considers is the best
to do).<br>
<br>
Cheers,<br>
Daniel<br>
<pre cols="72">--
Daniel-Constantin Mierla
<a href="http://twitter.com/#!/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a></pre>
</div>
<br>_______________________________________________<br>
sr-dev mailing list<br>
<a href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a><br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
<br></blockquote></div>
<br>
<font face="Helvetica, Arial, sans-serif"><font size="2"><span style="font-size:10pt"><a href="http://www.sipcentric.com/" title="blocked::http://www.sipcentric.com/" target="_blank">www.sipcentric.com</a><br>
<br>
Follow us on twitter <a href="http://twitter.com/sipcentric" title="blocked::http://twitter.com/sipcentric" target="_blank">@sipcentric</a><br>
<br>
<font color="gray">Sipcentric Ltd.
Company registered in England & Wales no. 7365592.</font> <font color="gray">Registered
office: Faraday Wharf, Innovation Birmingham Campus, Holt Street, Birmingham Science Park, Birmingham B7 4BB.</font></span></font></font>