<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello,<br>
<br>
I wanted first to discuss and see if you are interested in
maintaining the module for a while (at least one year -- this is
more like a gentlemen agreement) on the official repository.<br>
<br>
If yes, you will receive an invitation very soon. Next are several
remarks:<br>
<br>
- your commits will trigger email notifications sent to sr-dev
mailing list. The email you use for those git commits must be
subscribed to sr-dev (it is now, just to be clear you need to do it
in case you change to another email)<br>
- more details on how the commits should be done<br>
* <a class="moz-txt-link-freetext" href="http://www.kamailio.org/wiki/devel/git-commit-guidelines">http://www.kamailio.org/wiki/devel/git-commit-guidelines</a><br>
- special care to the formatting of commit:<br>
* first line with short description of the commit, then if
needed, an empty line and the extra details in the following lines<br>
- fixes - if there is a bug that applies to master branch as well,
the commit must be done first there and then use 'git cherry-pick -x
COMMITID' to backport it in stable branches.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<div class="moz-cite-prefix">On 12/01/15 08:11, Andrey Rybkin wrote:<br>
</div>
<blockquote
cite="mid:CAJ9A6EBuZw9yTLCQ6pVJePx0cUaeEffMdjL2Xo3kv=+HFQf0Fg@mail.gmail.com"
type="cite">
<div dir="ltr">Hello,
<div><br>
</div>
<div>I have tried to make changes in the module, but I do not
have the rights for this.</div>
<div>
<div class="gmail_extra"><br clear="all">
<div>
<div class="gmail_signature">
<div dir="ltr">
<div><font color="#666666" face="Arial, Tahoma,
Verdana, sans-serif"><span
style="line-height:18.2000007629395px">________________________________</span></font></div>
<div><font color="#666666" face="Arial, Tahoma,
Verdana, sans-serif"><span
style="line-height:18.2000007629395px">Andrey
Rybkin</span></font></div>
<div><font color="#666666" face="Arial, Tahoma,
Verdana, sans-serif"><span
style="line-height:18.2000007629395px">JID: <a
moz-do-not-send="true"
href="mailto:rybkin.a@bks.tv" target="_blank">rybkin.a@bks.tv</a></span></font></div>
<div><font color="#666666" face="Arial, Tahoma,
Verdana, sans-serif"><span
style="line-height:18.2000007629395px">E-Mail: <a
moz-do-not-send="true"
href="mailto:rybkin.a@bks.tv" target="_blank">rybkin.a@bks.tv</a></span></font></div>
<div><br>
</div>
</div>
</div>
</div>
<div class="gmail_quote">2015-01-06 14:25 GMT+03:00
Daniel-Constantin Mierla <span dir="ltr"><<a
moz-do-not-send="true" href="mailto:miconda@gmail.com"
target="_blank">miconda@gmail.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hello,<br>
<br>
your pull request to merge the usrloc_dmq module was
accepted few days ago.<br>
<br>
I wrote in the merge comment some remarks about few
thinks to be cared of:<br>
<br>
- add the license text at the top of .c/.h files
(license must be gplv2<br>
or bsd, at your choice)<br>
- variables to be declared at the beginning of functions
or blocks, to<br>
be sure it still compiles with old strict C compilers<br>
<br>
Giving a second thought and considering the current
common naming<br>
patterns, I propose to rename the module from usrloc_dmq
to dmq_usrloc<br>
(we have similar for pua_usrloc or pua_reginfo) -- the
idea is that the<br>
main purpose of the module is extending dmq with a new
data flow type,<br>
rather than usrloc specific extensions. Is that ok for
you? If you don't<br>
have time for it in short term, I can do it.<br>
<br>
Cheers,<br>
Daniel<br>
<span class=""><font color="#888888"><br>
--<br>
Daniel-Constantin Mierla<br>
<a moz-do-not-send="true"
href="http://twitter.com/#%21/miconda"
target="_blank">http://twitter.com/#!/miconda</a>
- <a moz-do-not-send="true"
href="http://www.linkedin.com/in/miconda"
target="_blank">http://www.linkedin.com/in/miconda</a><br>
<br>
</font></span></blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla
<a class="moz-txt-link-freetext" href="http://twitter.com/#!/miconda">http://twitter.com/#!/miconda</a> - <a class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a></pre>
</body>
</html>