<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On 17 Jan 2015, at 14:43, Robert Boisvert <<a href="mailto:rdboisvert@gmail.com">rdboisvert@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div>Olle,</div><div><br></div><div>Please address your concerns to me so I can look into them.</div></div></blockquote>Hi!</div><div>Thanks for a quick response!</div><div>- LM_DBG and LM_ERR needs to be terminated with \n</div><div>I did fix a few - but there's a lot more fixing to be done.</div><div><br></div><div>See how mohqueue stacks error messages on top of each other here where they should be on one line each.</div><div><br></div><div><div style="margin: 0px; font-size: 17px; font-family: Monaco; background-color: rgb(242, 172, 64);"> 0(92166) DEBUG: <core> [sr_module.c:731]: find_mod_export(): <db_query_lock> in module <db_mysql> not found</div><div style="margin: 0px; font-size: 17px; font-family: Monaco; background-color: rgb(242, 172, 64);"> 0(92166) ERROR: <core> [db.c:73]: db_check_api(): module db_mysql does not export db_use_table function. Please check if module is loaded.</div><div style="margin: 0px; font-size: 17px; font-family: Monaco; background-color: rgb(242, 172, 64);"> 0(92166) ERROR: mohqueue [mohq.c:236]: init_db(): Unable to bind DB API using <a href="mysql://kamailio:kamailiorw@localhost/kamailio">mysql://kamailio:kamailiorw@localhost/kamailio</a> 0(92166) ERROR: <core> [sr_module.c:945]: init_mod(): Error while initializing module mohqueue (/usr/local/lib64/kamailio/modules/mohqueue.so)</div><div style="margin: 0px; font-size: 17px; font-family: Monaco; background-color: rgb(242, 172, 64);">ERROR: error while initializing modules</div><div style="margin: 0px; font-size: 17px; font-family: Monaco; background-color: rgb(242, 172, 64);"> 0(92166) DEBUG: xprint [xprint.c:174]: destroy(): destroy module ...</div><div><br></div></div><div><br></div><div>It may be my personal opinion, but comparing the source code formatting in the mohqueue</div><div>source code files with other modules, it is not very well formatted. </div><div><br></div><div>Regards,</div><div>/O</div><div><br></div><div><blockquote type="cite"><div dir="ltr"><div><br></div><div>Thanks,</div><div>Bob</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jan 17, 2015 at 6:34 AM, Olle E. Johansson <span dir="ltr"><<a href="mailto:oej@edvina.net" target="_blank">oej@edvina.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Module: kamailio<br>
Branch: master<br>
Commit: 6daf77d666ff0fcb1bd8df4bb3c63dc0fdac9656<br>
URL: <a href="https://github.com/kamailio/kamailio/commit/6daf77d666ff0fcb1bd8df4bb3c63dc0fdac9656" target="_blank">https://github.com/kamailio/kamailio/commit/6daf77d666ff0fcb1bd8df4bb3c63dc0fdac9656</a><br>
<br>
Author: Olle E. Johansson <<a href="mailto:oej@edvina.net">oej@edvina.net</a>><br>
Committer: Olle E. Johansson <<a href="mailto:oej@edvina.net">oej@edvina.net</a>><br>
Date: 2015-01-17T12:33:45+01:00<br>
<br>
mohqueue Remove SVN IDs, add some \n at end of error messages<br>
<br>
More cleanup of LM_DBG and LM_ERR needed, as well as code formatting<br>
<br>
---<br>
<br>
Modified: modules/mohqueue/mohq.c<br>
Modified: modules/mohqueue/mohq.h<br>
Modified: modules/mohqueue/mohq_common.h<br>
Modified: modules/mohqueue/mohq_db.c<br>
Modified: modules/mohqueue/mohq_db.h<br>
Modified: modules/mohqueue/mohq_funcs.c<br>
Modified: modules/mohqueue/mohq_funcs.h<br>
Modified: modules/mohqueue/mohq_locks.c<br>
Modified: modules/mohqueue/mohq_locks.h<br>
<br>
---<br>
<br>
Diff: <a href="https://github.com/kamailio/kamailio/commit/6daf77d666ff0fcb1bd8df4bb3c63dc0fdac9656.diff" target="_blank">https://github.com/kamailio/kamailio/commit/6daf77d666ff0fcb1bd8df4bb3c63dc0fdac9656.diff</a><br>
Patch: <a href="https://github.com/kamailio/kamailio/commit/6daf77d666ff0fcb1bd8df4bb3c63dc0fdac9656.patch" target="_blank">https://github.com/kamailio/kamailio/commit/6daf77d666ff0fcb1bd8df4bb3c63dc0fdac9656.patch</a><br>
<br>
<br>
_______________________________________________<br>
sr-dev mailing list<br>
<a href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a><br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
</blockquote></div><br></div>
_______________________________________________<br>sr-dev mailing list<br><a href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a><br>http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev<br></blockquote></div><br></body></html>