<div dir="ltr">Hmm, you may have a point - working backwards, we only call parse_headers(msg, HDR_EOH_F, 0) - which does not include From header, right?</div><div class="gmail_extra"><br><div class="gmail_quote">On 30 January 2015 at 15:00, Daniel-Constantin Mierla <span dir="ltr"><<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">parse_from_header() should do nothing if the From header is found parsed. I am not sure if this alone is solving the issue properly. Maybe the From was not parsed in the first place, before cloning...<div><br></div><div>Cheers,</div><div>Daniel</div></div><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Fri, Jan 30, 2015 at 3:09 PM, Charles Chance <span dir="ltr"><<a href="mailto:charles.chance@sipcentric.com" target="_blank">charles.chance@sipcentric.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Module: kamailio<br>
Branch: master<br>
Commit: 102504294f9edaaee9d4baea873d4ed9151b8fed<br>
URL: <a href="https://github.com/kamailio/kamailio/commit/102504294f9edaaee9d4baea873d4ed9151b8fed" target="_blank">https://github.com/kamailio/kamailio/commit/102504294f9edaaee9d4baea873d4ed9151b8fed</a><br>
<br>
Author: Charles Chance <<a href="mailto:charles.chance@sipcentric.com" target="_blank">charles.chance@sipcentric.com</a>><br>
Committer: Charles Chance <<a href="mailto:charles.chance@sipcentric.com" target="_blank">charles.chance@sipcentric.com</a>><br>
Date: 2015-01-30T14:08:01Z<br>
<br>
dmq: do not parse From header again, since it was done already prior to cloning msg.<br>
<br>
- introduces a memory leak if not manually freed<br>
- but there is no need to parse it again anyway<br>
- discovered by Andrey Rybkin<br>
<br>
---<br>
<br>
Modified: modules/dmq/worker.c<br>
<br>
---<br>
<br>
Diff: <a href="https://github.com/kamailio/kamailio/commit/102504294f9edaaee9d4baea873d4ed9151b8fed.diff" target="_blank">https://github.com/kamailio/kamailio/commit/102504294f9edaaee9d4baea873d4ed9151b8fed.diff</a><br>
Patch: <a href="https://github.com/kamailio/kamailio/commit/102504294f9edaaee9d4baea873d4ed9151b8fed.patch" target="_blank">https://github.com/kamailio/kamailio/commit/102504294f9edaaee9d4baea873d4ed9151b8fed.patch</a><br>
<br>
---<br>
<br>
diff --git a/modules/dmq/worker.c b/modules/dmq/worker.c<br>
index 8426730..ca1b3dc 100644<br>
--- a/modules/dmq/worker.c<br>
+++ b/modules/dmq/worker.c<br>
@@ -91,11 +91,11 @@ void worker_loop(int id)<br>
current_job = job_queue_pop(worker->queue);<br>
/* job_queue_pop might return NULL if queue is empty */<br>
if(current_job) {<br>
- /* extract the from uri */<br>
- if (parse_from_header(current_job->msg) < 0) {<br>
- LM_ERR("bad sip message or missing From hdr\n");<br>
- } else {<br>
+ /* attempt to identify node based on from uri */<br>
+ if (current_job->msg->from->parsed) {<br>
dmq_node = find_dmq_node_uri(node_list, &((struct to_body*)current_job->msg->from->parsed)->uri);<br>
+ } else {<br>
+ LM_ERR("bad sip message or missing From hdr\n");<br>
}<br>
<br>
ret_value = current_job->f(current_job->msg, &peer_response, dmq_node);<br>
<br>
<br>
_______________________________________________<br>
sr-dev mailing list<br>
<a href="mailto:sr-dev@lists.sip-router.org" target="_blank">sr-dev@lists.sip-router.org</a><br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br><div><div dir="ltr"><div>Daniel-Constantin Mierla - <a href="http://www.asipto.com" target="_blank">http://www.asipto.com</a></div><div><a href="http://twitter.com/#!/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/micond</a></div></div></div>
</font></span></div>
<br>_______________________________________________<br>
sr-dev mailing list<br>
<a href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a><br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><font face="arial, helvetica, sans-serif"><b><font>Charles Chance</font></b><br><font>Managing Director</font></font><br><div><font face="arial, helvetica, sans-serif"><font><br></font></font></div><div><font face="arial, helvetica, sans-serif"><font>t. 0121 285 4400 m. 07932 063 891</font></font></div></div></div>
</div>
<br>
<font face="Helvetica, Arial, sans-serif"><font size="2"><span style="font-size:10pt"><a href="http://www.sipcentric.com/" title="blocked::http://www.sipcentric.com/" target="_blank">www.sipcentric.com</a><br>
<br>
Follow us on twitter <a href="http://twitter.com/sipcentric" title="blocked::http://twitter.com/sipcentric" target="_blank">@sipcentric</a><br>
<br>
<font color="gray">Sipcentric Ltd.
Company registered in England & Wales no. 7365592.</font> <font color="gray">Registered
office: Faraday Wharf, Innovation Birmingham Campus, Holt Street, Birmingham Science Park, Birmingham B7 4BB.</font></span></font></font>