<div dir="ltr">Hello,<div><br></div><div>ok, you can backport the patch to 4.2.</div><div><br></div><div>Cheers,</div><div>Daniel</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jan 29, 2015 at 12:15 PM, Luis Azedo <span dir="ltr"><<a href="mailto:luis@2600hz.com" target="_blank">luis@2600hz.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF">
<div style="direction:ltr;font-family:Tahoma;color:#000000;font-size:10pt">Hi Daniel,
<div><br>
</div>
<div>the current behaviour is, if the body is NULL it doesn't send the body, which works with most phones.</div>
<div><br>
</div>
<div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
NOTIFY <a href="mailto:sip%3Auser_7z7b6s@192.168.16.12" target="_blank">sip:user_7z7b6s@192.168.16.12</a>:<u></u>49454;transport=udp SIP/2.0</div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
Via: SIP/2.0/UDP 192.168.16.155;branch=<u></u>z9hG4bK7b96.<u></u>7cb452f20000000000000000000000<u></u>00.0</div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
To: <<a href="mailto:sip%3Auser_7z7b6s@teste.sip.90e9.com" style="color:rgb(17,85,204)" target="_blank">sip:user_7z7b6s@test.sip.com</a>>;tag=25ad9c33</div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
From: <<a href="mailto:sip%3A995582134@teste.sip.90e9.com" style="color:rgb(17,85,204)" target="_blank">sip:995582134@test.sip.<u></u>com</a>>;tag=<u></u>bc2b9f04dce18e817c04a8a86ca551<u></u>08-f69b</div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
CSeq: 2 NOTIFY</div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
Call-ID: NWEyNmRmMjg2YmJhMjQ0MWM2Y2Y1OT<u></u>NjNTFhZDU1ZmY</div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
Content-Length: 0</div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
Max-Forwards: 70</div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
Event: dialog</div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
Contact: <sip:<a href="http://192.168.16.155:5060" target="_blank">192.168.16.155:5060</a>;<u></u>transport=udp></div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
Subscription-State: active;expires=1800</div>
</div>
<div><br>
</div>
<div><b>with the patch, if param force_dummy_dialog = 1</b></div>
<div><br>
</div>
<div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
NOTIFY <a href="mailto:sip%3Auser_7z7b6s@192.168.16.12" target="_blank">sip:user_7z7b6s@192.168.16.12</a>:<u></u>49454;transport=udp SIP/2.0</div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
Via: SIP/2.0/UDP 192.168.16.155;branch=<u></u>z9hG4bK811e.<u></u>7c3b7b250000000000000000000000<u></u>00.0</div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
To: <<a href="mailto:sip%3Auser_7z7b6s@teste.sip.90e9.com" style="color:rgb(17,85,204)" target="_blank">sip:user_7z7b6s@test.sip.com</a>>;tag=4dce5b3e</div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
From: <<a href="mailto:sip%3A995582135@teste.sip.90e9.com" style="color:rgb(17,85,204)" target="_blank">sip:995582135@test.sip.<u></u>com</a>>;tag=<u></u>bc2b9f04dce18e817c04a8a86ca551<u></u>08-bab8</div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
CSeq: 2 NOTIFY</div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
Call-ID: MTY0Zjk1ZWFhOGI2OTBmNTM1MTQ4Nm<u></u>MxN2Q1OTlmNGQ</div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
Content-Length: 246</div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
Max-Forwards: 70</div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
Event: dialog</div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
Contact: <sip:<a href="http://192.168.16.155:5060" target="_blank">192.168.16.155:5060</a>;<u></u>transport=udp></div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
Subscription-State: active;expires=1800</div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
Content-Type: application/dialog-info+xml</div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
<br>
</div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
<?xml version="1.0"?></div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
<dialog-info xmlns="urn:ietf:params:xml:ns:<u></u>dialog-info" version="1" state="full" entity="<a href="mailto:sip%3A995582135@teste.sip.90e9.com" style="color:rgb(17,85,204)" target="_blank">sip:995582134@test.<u></u>sip.com</a>"></div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
<dialog direction="recipient"></div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
<state>terminated</state></div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
</dialog></div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small">
</dialog-info></div>
</div>
<div><br>
</div>
<div>which works for astra and bria (maybe others) and also works for previously working phones (tested with polycom, cisco, jitsi)</div>
<div><br>
</div>
<div><br>
<div style="font-family:Times New Roman;color:#000000;font-size:16px">
<hr>
<div style="direction:ltr"><font face="Tahoma" color="#000000"><b>From:</b> sr-dev [<a href="mailto:sr-dev-bounces@lists.sip-router.org" target="_blank">sr-dev-bounces@lists.sip-router.org</a>] on behalf of Daniel-Constantin Mierla [<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>]<br>
<b>Sent:</b> Thursday, January 29, 2015 1:53 AM<br>
<b>To:</b> Kamailio (SER) - Development Mailing List<br>
<b>Subject:</b> Re: [sr-dev] request for backporting to 4.2 - presence_dialoginfo : optionally send dummy dialog<br>
</font><br>
</div><div><div class="h5">
<div></div>
<div>Hello,<br>
<br>
<div>On 28/01/15 23:19, Luis Azedo wrote:<br>
</div>
<blockquote type="cite">
<div style="direction:ltr;font-family:Tahoma;color:#000000;font-size:10pt">
<div style="font-family:Times New Roman;color:#000000;font-size:16px">
<div style="direction:ltr"><br>
</div>
<div>
<div style="direction:ltr;font-family:Tahoma;color:#000000;font-size:10pt">
<div style="font-family:Times New Roman;color:#000000;font-size:16px">
<div>
<div style="direction:ltr;font-family:Tahoma;color:#000000;font-size:10pt">
<div>Hi List,</div>
<div><br>
</div>
<div>some sip clients like Bria and some sip phones like Astra </div>
<div>expect a <dialog-info><dialog><span style="font-size:13.3333330154419px"></dialog></span><span style="font-size:13.3333330154419px"></dialog-info></span></div>
<div><span style="font-size:13.3333330154419px">on the NOTIFY message sent.</span></div>
<div><span style="font-size:13.3333330154419px"><br>
</span></div>
<div><span style="font-size:13.3333330154419px">presence sends a NOTIFY after the SUBSCRIBE with NULL body if it doesn't find the presentity.</span></div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<br>
for clarification, the body is empty, not with a string NULL, isn't it?<br>
<br>
Even it adds a new module parameter, the behaviour is preserved, and given bria and astra are quite spread, I am ok to backport. Let's see if others are fine as well.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<blockquote type="cite">
<div style="direction:ltr;font-family:Tahoma;color:#000000;font-size:10pt">
<div style="font-family:Times New Roman;color:#000000;font-size:16px">
<div>
<div style="direction:ltr;font-family:Tahoma;color:#000000;font-size:10pt">
<div style="font-family:Times New Roman;color:#000000;font-size:16px">
<div>
<div style="direction:ltr;font-family:Tahoma;color:#000000;font-size:10pt">
<div><span style="font-size:13.3333330154419px"><br>
</span></div>
<div><span style="font-size:13.3333330154419px">the patch already in master allows to configure the creation of a dummy dialog to be sent when presence doesn't find the presentity.</span></div>
<div><span style="font-size:13.3333330154419px"><br>
</span></div>
<div><span style="font-size:13.3333330154419px">this behavior was only observed in dialog subscriptions so the patch was made against presence_dialoginfo.</span></div>
<div><span style="font-size:13.3333330154419px"><br>
</span></div>
<div><span style="font-size:13.3333330154419px"><b>the new param force_dummy_dialog defaults to 0 to preserve existing behavior.</b></span></div>
<div><span style="font-size:13.3333330154419px"><br>
</span></div>
<div><span style="font-size:13.3333330154419px">using this patch Bria, Astra started working with BLF and others (Cisco, Polycom, Jitsi) kept running.</span></div>
<div><span style="font-size:13.3333330154419px"><br>
</span></div>
<div><span style="font-size:13.3333330154419px">does anyone have anything against backporting this to 4.2 ?</span></div>
<div><span style="font-size:13.3333330154419px"><br>
</span></div>
<div><span style="font-size:13.3333330154419px">Best</span></div>
<div style="font-family:Times New Roman;color:#000000;font-size:16px">
<div style="direction:ltr"><br>
</div>
<div>
<div></div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<br>
<fieldset></fieldset> <br>
<pre>_______________________________________________
sr-dev mailing list
<a href="mailto:sr-dev@lists.sip-router.org" target="_blank">sr-dev@lists.sip-router.org</a>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a>
</pre>
</blockquote>
<br>
<pre cols="72">--
Daniel-Constantin Mierla
<a href="http://twitter.com/#!/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a></pre>
</div>
</div></div></div>
</div>
</div>
</div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div>Daniel-Constantin Mierla - <a href="http://www.asipto.com" target="_blank">http://www.asipto.com</a></div><div><a href="http://twitter.com/#!/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/micond</a></div></div></div>
</div>