Detail:<br><br>Process 1: Suspend transaction and get some other process to do some work<div>Process 2: Receive callback from some other process to continue the transaction (work has been done). In this process we respond (in code) with a reply for example (maybe 401 Auth required), this reply will set kr to REQ_RPLD (for example). Finally, process 2 calls t_continue on the transaction..... which now resets kr to 0. As a result, IMHO, the process is out of sync (truth is not correct). A symptom is that you have a litter of "WARNING: script writer didn't release transaction" in your log file...</div><div><br></div><div>Maybe you have another idea to fix, but I don't see a reason to reset kr... at least not to 0?</div><div><br></div><div>Cheers</div><div>Jason</div><br><div class="gmail_quote">On Fri Jan 30 2015 at 16:01:49 Jason Penton <<a href="mailto:jason.penton@gmail.com">jason.penton@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hey Daniel, apologies, I actually meant to delete the line and not comment it........ ;) - but I will update<br><br>Cheers<div>Jason</div><br><div class="gmail_quote">On Fri Jan 30 2015 at 15:15:26 Daniel-Constantin Mierla <<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Can you detail the situation you ran into and gets fixed with the patch?<div><br></div><div>Also, better remove than comment, or use C classic comments /* ... */ instead of C++ style //.</div><div><br></div><div>Makes sense to keep it in comments when you add some info why it was done. Simply commenting is making the code not very clean over the time.</div><div><br></div><div>Cheers,</div><div>Daniel</div></div><div class="gmail_extra"></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jan 30, 2015 at 1:53 PM, Jason Penton <span dir="ltr"><<a href="mailto:jason.penton@gmail.com" target="_blank">jason.penton@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Module: kamailio<br>
Branch: master<br>
Commit: 4ba9ee6bff2fc74188c058f71240f1<u></u>e128717588<br>
URL: <a href="https://github.com/kamailio/kamailio/commit/4ba9ee6bff2fc74188c058f71240f1e128717588" target="_blank">https://github.com/kamailio/<u></u>kamailio/commit/<u></u>4ba9ee6bff2fc74188c058f71240f1<u></u>e128717588</a><br>
<br>
Author: Jason Penton <<a href="mailto:jason.penton@gmail.com" target="_blank">jason.penton@gmail.com</a>><br>
Committer: Jason Penton <<a href="mailto:jason.penton@gmail.com" target="_blank">jason.penton@gmail.com</a>><br>
Date: 2015-01-30T14:53:18+02:00<br>
<br>
modules/tm: no reason to reset KR on continuation of async requests<br>
- maybe before continuing, a reply has been sent, request forwarded, etc...<br>
<br>
---<br>
<br>
Modified: modules/tm/t_suspend.c<br>
<br>
---<br>
<br>
Diff: <a href="https://github.com/kamailio/kamailio/commit/4ba9ee6bff2fc74188c058f71240f1e128717588.diff" target="_blank">https://github.com/kamailio/<u></u>kamailio/commit/<u></u>4ba9ee6bff2fc74188c058f71240f1<u></u>e128717588.diff</a><br>
Patch: <a href="https://github.com/kamailio/kamailio/commit/4ba9ee6bff2fc74188c058f71240f1e128717588.patch" target="_blank">https://github.com/kamailio/<u></u>kamailio/commit/<u></u>4ba9ee6bff2fc74188c058f71240f1<u></u>e128717588.patch</a><br>
<br>
---<br>
<br>
diff --git a/modules/tm/t_suspend.c b/modules/tm/t_suspend.c<br>
index f07307d..8838a97 100644<br>
--- a/modules/tm/t_suspend.c<br>
+++ b/modules/tm/t_suspend.c<br>
@@ -221,7 +221,7 @@ int t_continue(unsigned int hash_index, unsigned int label,<br>
Not a huge problem, fr timer will fire, but CANCEL<br>
will not be sent. last_received will be set to 408. */<br>
<br>
- reset_kr();<br>
+// reset_kr();<br>
<br>
/* fake the request and the environment, like in failure_route */<br>
if (!fake_req(&faked_req, t->uas.request, 0 /* extra flags */, uac)) {<br>
<br>
<br>
______________________________<u></u>_________________<br>
sr-dev mailing list<br>
<a href="mailto:sr-dev@lists.sip-router.org" target="_blank">sr-dev@lists.sip-router.org</a><br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/<u></u>cgi-bin/mailman/listinfo/sr-<u></u>dev</a><br>
</blockquote></div><br><br clear="all"><div><br></div></div><div class="gmail_extra">-- <br><div><div dir="ltr"><div>Daniel-Constantin Mierla - <a href="http://www.asipto.com" target="_blank">http://www.asipto.com</a></div><div><a href="http://twitter.com/#!/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/<u></u>micond</a></div></div></div>
</div>
______________________________<u></u><u></u>_________________<br>
sr-dev mailing list<br>
<a href="mailto:sr-dev@lists.sip-router.org" target="_blank">sr-dev@lists.sip-router.org</a><br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/<u></u>cg<u></u>i-bin/mailman/listinfo/sr-<u></u>dev</a><br>
</blockquote></div></blockquote></div>