<div dir="ltr">Once the call goes into terminated state, the confirmed state doesn't exist anymore (it is replaced by the terminated state). I have been using this patch on production servers for months without any issues.<div><br></div><div>-ovidiu</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 11, 2015 at 3:49 PM, Daniel-Constantin Mierla <span dir="ltr"><<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This has to be made parameter. Also, the expires for trying and early<br>
state has to be configurable -- there was a discussions on sr-users<br>
during past days ending up in such conclusion, but I didn't have time to<br>
pursue yet.<br>
<br>
And I think there is another thing to care of -- once terminated state<br>
is published, the confirmed state document must be deleted. No time<br>
either to analyze the code and decide how to do it. Because if<br>
terminated state record is deleted, then the confirmed state remains<br>
alone and the lines would appear busy to watchers.<br>
<br>
Cheers,<br>
Daniel<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
On 11/02/15 21:32, Ovidiu Sas wrote:<br>
> Module: kamailio<br>
> Branch: master<br>
> Commit: dfaf93c3cc9bd6e65dacafd01a8299f42abacbf5<br>
> URL: <a href="https://github.com/kamailio/kamailio/commit/dfaf93c3cc9bd6e65dacafd01a8299f42abacbf5" target="_blank">https://github.com/kamailio/kamailio/commit/dfaf93c3cc9bd6e65dacafd01a8299f42abacbf5</a><br>
><br>
> Author: Ovidiu Sas <<a href="mailto:osas@voipembedded.com">osas@voipembedded.com</a>><br>
> Committer: Ovidiu Sas <<a href="mailto:osas@voipembedded.com">osas@voipembedded.com</a>><br>
> Date: 2015-02-11T15:30:42-05:00<br>
><br>
> pua_dialoginfo: set expiration timeout to 10s for dialogs in terminated state<br>
> - this will avoid accumulation of expired dialogs<br>
><br>
> ---<br>
><br>
> Modified: modules/pua_dialoginfo/pua_dialoginfo.c<br>
><br>
> ---<br>
><br>
> Diff: <a href="https://github.com/kamailio/kamailio/commit/dfaf93c3cc9bd6e65dacafd01a8299f42abacbf5.diff" target="_blank">https://github.com/kamailio/kamailio/commit/dfaf93c3cc9bd6e65dacafd01a8299f42abacbf5.diff</a><br>
> Patch: <a href="https://github.com/kamailio/kamailio/commit/dfaf93c3cc9bd6e65dacafd01a8299f42abacbf5.patch" target="_blank">https://github.com/kamailio/kamailio/commit/dfaf93c3cc9bd6e65dacafd01a8299f42abacbf5.patch</a><br>
><br>
> ---<br>
><br>
> diff --git a/modules/pua_dialoginfo/pua_dialoginfo.c b/modules/pua_dialoginfo/pua_dialoginfo.c<br>
> index 7bed1998..de53e0f 100644<br>
> --- a/modules/pua_dialoginfo/pua_dialoginfo.c<br>
> +++ b/modules/pua_dialoginfo/pua_dialoginfo.c<br>
> @@ -269,11 +269,11 @@ __dialog_sendpublish(struct dlg_cell *dlg, int type, struct dlg_cb_params *_para<br>
> dlginfo->from_uri.s);<br>
> dialog_publish_multi("terminated", dlginfo->pubruris_caller,<br>
> &(dlginfo->from_uri), &uri, &(dlginfo->callid), 1,<br>
> - dlginfo->lifetime, 0, 0, &(dlginfo->from_contact),<br>
> + 10, 0, 0, &(dlginfo->from_contact),<br>
> &target, send_publish_flag==-1?1:0);<br>
> dialog_publish_multi("terminated", dlginfo->pubruris_callee,<br>
> &uri, &(dlginfo->from_uri), &(dlginfo->callid), 0,<br>
> - dlginfo->lifetime, 0, 0, &target, &(dlginfo->from_contact),<br>
> + 10, 0, 0, &target, &(dlginfo->from_contact),<br>
> send_publish_flag==-1?1:0);<br>
> break;<br>
> case DLGCB_CONFIRMED:<br>
> @@ -364,11 +364,11 @@ __dialog_sendpublish(struct dlg_cell *dlg, int type, struct dlg_cb_params *_para<br>
> type, dlginfo->from_uri.len, dlginfo->from_uri.s);<br>
> dialog_publish_multi("terminated", dlginfo->pubruris_caller,<br>
> &(dlginfo->from_uri), &uri, &(dlginfo->callid), 1,<br>
> - dlginfo->lifetime, 0, 0, &(dlginfo->from_contact), &target,<br>
> + 10, 0, 0, &(dlginfo->from_contact), &target,<br>
> send_publish_flag==-1?1:0);<br>
> dialog_publish_multi("terminated", dlginfo->pubruris_callee, &uri,<br>
> &(dlginfo->from_uri), &(dlginfo->callid), 0,<br>
> - dlginfo->lifetime, 0, 0, &target, &(dlginfo->from_contact),<br>
> + 10, 0, 0, &target, &(dlginfo->from_contact),<br>
> send_publish_flag==-1?1:0);<br>
><br>
> }<br>
><br>
><br>
> _______________________________________________<br>
> sr-dev mailing list<br>
> <a href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a><br>
> <a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
Daniel-Constantin Mierla<br>
<a href="http://twitter.com/#!/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a><br>
Kamailio World Conference, May 27-29, 2015<br>
Berlin, Germany - <a href="http://www.kamailioworld.com" target="_blank">http://www.kamailioworld.com</a><br>
</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
_______________________________________________<br>
sr-dev mailing list<br>
<a href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a><br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">VoIP Embedded, Inc.<br><a href="http://www.voipembedded.com" target="_blank">http://www.voipembedded.com</a></div>
</div>