<div dir="ltr">Ok ! I keep the patch running.<div><br></div><div>With the patch, the AOR is saved and the outbound routing works.</div><div><br></div><div>Thank you.<br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 23, 2015 at 4:25 PM, <span dir="ltr"><<a href="mailto:sr-dev-request@lists.sip-router.org" target="_blank">sr-dev-request@lists.sip-router.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Send sr-dev mailing list submissions to<br>
<a href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a><br>
<br>
To subscribe or unsubscribe via the World Wide Web, visit<br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
or, via email, send a message with subject or body 'help' to<br>
<a href="mailto:sr-dev-request@lists.sip-router.org">sr-dev-request@lists.sip-router.org</a><br>
<br>
You can reach the person managing the list at<br>
<a href="mailto:sr-dev-owner@lists.sip-router.org">sr-dev-owner@lists.sip-router.org</a><br>
<br>
When replying, please edit your Subject line so it is more specific<br>
than "Re: Contents of sr-dev digest..."<br>
<br>
<br>
Today's Topics:<br>
<br>
1. git:master:91596953: sdpops: safety check when location a=<br>
line not to exceed end of message (Daniel-Constantin Mierla)<br>
2. Re: [kamailio] registrar - additional features (#91) (lazedo)<br>
3. aastra outbound support (GG GG)<br>
4. git:master:b9e5b918: kazoo - fix timeouts (Luis Azedo)<br>
5. git:4.2:449ba0c0: kazoo - fix timeouts (Luis Azedo)<br>
6. git:4.2:e24c9ff7: sdpops: safety check when location a= line<br>
not to exceed end of message (Daniel-Constantin Mierla)<br>
7. Issue after tcpops enhancement for lifetime per connection<br>
(Daniel-Constantin Mierla)<br>
8. Re: aastra outbound support (Daniel-Constantin Mierla)<br>
9. Re: [kamailio] registrar - additional features (#91)<br>
(Daniel-Constantin Mierla)<br>
<br>
<br>
----------------------------------------------------------------------<br>
<br>
Message: 1<br>
Date: Mon, 23 Feb 2015 14:31:19 +0100<br>
From: Daniel-Constantin Mierla <<a href="mailto:miconda@gmail.com">miconda@gmail.com</a>><br>
To: <a href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a><br>
Subject: [sr-dev] git:master:91596953: sdpops: safety check when<br>
location a= line not to exceed end of message<br>
Message-ID: <<a href="mailto:E1YPt6V-0004Hd-UP@www.kamailio.org">E1YPt6V-0004Hd-UP@www.kamailio.org</a>><br>
<br>
Module: kamailio<br>
Branch: master<br>
Commit: 91596953115fe1bbe5c6f0dd0dd6e8d99cdbd285<br>
URL: <a href="https://github.com/kamailio/kamailio/commit/91596953115fe1bbe5c6f0dd0dd6e8d99cdbd285" target="_blank">https://github.com/kamailio/kamailio/commit/91596953115fe1bbe5c6f0dd0dd6e8d99cdbd285</a><br>
<br>
Author: Daniel-Constantin Mierla <<a href="mailto:miconda@gmail.com">miconda@gmail.com</a>><br>
Committer: Daniel-Constantin Mierla <<a href="mailto:miconda@gmail.com">miconda@gmail.com</a>><br>
Date: 2015-02-23T14:29:46+01:00<br>
<br>
sdpops: safety check when location a= line not to exceed end of message<br>
<br>
---<br>
<br>
Modified: modules/sdpops/sdpops_mod.c<br>
<br>
---<br>
<br>
Diff: <a href="https://github.com/kamailio/kamailio/commit/91596953115fe1bbe5c6f0dd0dd6e8d99cdbd285.diff" target="_blank">https://github.com/kamailio/kamailio/commit/91596953115fe1bbe5c6f0dd0dd6e8d99cdbd285.diff</a><br>
Patch: <a href="https://github.com/kamailio/kamailio/commit/91596953115fe1bbe5c6f0dd0dd6e8d99cdbd285.patch" target="_blank">https://github.com/kamailio/kamailio/commit/91596953115fe1bbe5c6f0dd0dd6e8d99cdbd285.patch</a><br>
<br>
---<br>
<br>
diff --git a/modules/sdpops/sdpops_mod.c b/modules/sdpops/sdpops_mod.c<br>
index 3357bb2..2a4aa6b 100644<br>
--- a/modules/sdpops/sdpops_mod.c<br>
+++ b/modules/sdpops/sdpops_mod.c<br>
@@ -159,12 +159,17 @@ static int mod_init(void)<br>
int sdp_locate_line(sip_msg_t* msg, char *pos, str *aline)<br>
{<br>
char *p;<br>
+ char *bend;<br>
+<br>
p = pos;<br>
while(*p!='\n') p--;<br>
aline->s = p + 1;<br>
p = pos;<br>
- while(*p!='\n') p++;<br>
+ bend = msg->buf+msg->len;<br>
+ while(*p!='\n' && p<bend) p++;<br>
aline->len = p - aline->s + 1;<br>
+ if(unlikely(p==bend)) aline->len--;<br>
+<br>
return 0;<br>
}<br>
<br>
<br>
<br>
<br>
<br>
------------------------------<br>
<br>
Message: 2<br>
Date: Mon, 23 Feb 2015 06:14:31 -0800<br>
From: lazedo <<a href="mailto:notifications@github.com">notifications@github.com</a>><br>
To: Kamailio Devel List <<a href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a>><br>
Subject: Re: [sr-dev] [kamailio] registrar - additional features (#91)<br>
Message-ID: <kamailio/kamailio/pull/91/<a href="mailto:c75547064@github.com">c75547064@github.com</a>><br>
Content-Type: text/plain; charset="utf-8"<br>
<br>
@miconda can you check if this is acceptable ? thanks.<br>
<br>
---<br>
Reply to this email directly or view it on GitHub:<br>
<a href="https://github.com/kamailio/kamailio/pull/91#issuecomment-75547064" target="_blank">https://github.com/kamailio/kamailio/pull/91#issuecomment-75547064</a><br>
-------------- next part --------------<br>
An HTML attachment was scrubbed...<br>
URL: <<a href="http://lists.sip-router.org/pipermail/sr-dev/attachments/20150223/a74d9010/attachment-0001.html" target="_blank">http://lists.sip-router.org/pipermail/sr-dev/attachments/20150223/a74d9010/attachment-0001.html</a>><br>
<br>
------------------------------<br>
<br>
Message: 3<br>
Date: Mon, 23 Feb 2015 15:21:10 -0500<br>
From: GG GG <<a href="mailto:ggcoding@gmail.com">ggcoding@gmail.com</a>><br>
To: <a href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a><br>
Subject: [sr-dev] aastra outbound support<br>
Message-ID:<br>
<CAO=<a href="mailto:zBEdDwW3VPFQiLR7jQMqWb9Sfqfmiqx%2BHCzrB%2BOiC5uMTaQ@mail.gmail.com">zBEdDwW3VPFQiLR7jQMqWb9Sfqfmiqx+HCzrB+OiC5uMTaQ@mail.gmail.com</a>><br>
Content-Type: text/plain; charset="utf-8"<br>
<br>
Hi !<br>
<br>
Aastra phone can support outbound (RFC 5626) but they put reg-id=0 in the<br>
SIP REGISTER.<br>
<br>
So the registrar server can't save the AOR and says "invalid reg-id value".<br>
I know Aastra should change that for reg-id=1, I already reported an issue<br>
but no feedback...<br>
<br>
Finally I applied a patch in modules/registrar/save.c:<br>
<br>
-- if(str2int(&_c->reg_id->body, &ci.reg_id)<0 || ci.reg_id==0)<br>
++ if(str2int(&_c->reg_id->body, &ci.reg_id)<0)<br>
{<br>
LM_ERR("invalid reg-id value\n");<br>
goto error;<br>
}<br>
<br>
Do you think it's safe to do that ?<br>
<br>
Thank you !<br>
-------------- next part --------------<br>
An HTML attachment was scrubbed...<br>
URL: <<a href="http://lists.sip-router.org/pipermail/sr-dev/attachments/20150223/59a5c54b/attachment-0001.html" target="_blank">http://lists.sip-router.org/pipermail/sr-dev/attachments/20150223/59a5c54b/attachment-0001.html</a>><br>
<br>
------------------------------<br>
<br>
Message: 4<br>
Date: Mon, 23 Feb 2015 21:56:18 +0100<br>
From: Luis Azedo <<a href="mailto:luis@2600hz.com">luis@2600hz.com</a>><br>
To: <a href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a><br>
Subject: [sr-dev] git:master:b9e5b918: kazoo - fix timeouts<br>
Message-ID: <<a href="mailto:E1YQ038-0002zX-FF@www.kamailio.org">E1YQ038-0002zX-FF@www.kamailio.org</a>><br>
<br>
Module: kamailio<br>
Branch: master<br>
Commit: b9e5b9181c0f9c315e0f27ad96f69d5ca8cafba3<br>
URL: <a href="https://github.com/kamailio/kamailio/commit/b9e5b9181c0f9c315e0f27ad96f69d5ca8cafba3" target="_blank">https://github.com/kamailio/kamailio/commit/b9e5b9181c0f9c315e0f27ad96f69d5ca8cafba3</a><br>
<br>
Author: Luis Azedo <<a href="mailto:luis@2600hz.com">luis@2600hz.com</a>><br>
Committer: Luis Azedo <<a href="mailto:luis@2600hz.com">luis@2600hz.com</a>><br>
Date: 2015-02-23T20:55:57Z<br>
<br>
kazoo - fix timeouts<br>
<br>
timeout should be ms not sec<br>
set time before state so timeout check doesn't set timeout immediately<br>
separate proc for handling timeouts<br>
<br>
---<br>
<br>
Modified: modules/kazoo/kazoo.c<br>
Modified: modules/kazoo/kz_amqp.c<br>
Modified: modules/kazoo/kz_amqp.h<br>
<br>
---<br>
<br>
Diff: <a href="https://github.com/kamailio/kamailio/commit/b9e5b9181c0f9c315e0f27ad96f69d5ca8cafba3.diff" target="_blank">https://github.com/kamailio/kamailio/commit/b9e5b9181c0f9c315e0f27ad96f69d5ca8cafba3.diff</a><br>
Patch: <a href="https://github.com/kamailio/kamailio/commit/b9e5b9181c0f9c315e0f27ad96f69d5ca8cafba3.patch" target="_blank">https://github.com/kamailio/kamailio/commit/b9e5b9181c0f9c315e0f27ad96f69d5ca8cafba3.patch</a><br>
<br>
<br>
<br>
<br>
------------------------------<br>
<br>
Message: 5<br>
Date: Mon, 23 Feb 2015 21:57:18 +0100<br>
From: Luis Azedo <<a href="mailto:luis@2600hz.com">luis@2600hz.com</a>><br>
To: <a href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a><br>
Subject: [sr-dev] git:4.2:449ba0c0: kazoo - fix timeouts<br>
Message-ID: <<a href="mailto:E1YQ046-0003Sl-A7@www.kamailio.org">E1YQ046-0003Sl-A7@www.kamailio.org</a>><br>
<br>
Module: kamailio<br>
Branch: 4.2<br>
Commit: 449ba0c0a3a1c79c597452c3411fd823465c9482<br>
URL: <a href="https://github.com/kamailio/kamailio/commit/449ba0c0a3a1c79c597452c3411fd823465c9482" target="_blank">https://github.com/kamailio/kamailio/commit/449ba0c0a3a1c79c597452c3411fd823465c9482</a><br>
<br>
Author: Luis Azedo <<a href="mailto:luis@2600hz.com">luis@2600hz.com</a>><br>
Committer: Luis Azedo <<a href="mailto:luis@2600hz.com">luis@2600hz.com</a>><br>
Date: 2015-02-23T20:56:53Z<br>
<br>
kazoo - fix timeouts<br>
<br>
timeout should be ms not sec<br>
set time before state so timeout check doesn't set timeout immediately<br>
separate proc for handling timeouts<br>
<br>
(cherry picked from commit b9e5b9181c0f9c315e0f27ad96f69d5ca8cafba3)<br>
<br>
---<br>
<br>
Modified: modules/kazoo/kazoo.c<br>
Modified: modules/kazoo/kz_amqp.c<br>
Modified: modules/kazoo/kz_amqp.h<br>
<br>
---<br>
<br>
Diff: <a href="https://github.com/kamailio/kamailio/commit/449ba0c0a3a1c79c597452c3411fd823465c9482.diff" target="_blank">https://github.com/kamailio/kamailio/commit/449ba0c0a3a1c79c597452c3411fd823465c9482.diff</a><br>
Patch: <a href="https://github.com/kamailio/kamailio/commit/449ba0c0a3a1c79c597452c3411fd823465c9482.patch" target="_blank">https://github.com/kamailio/kamailio/commit/449ba0c0a3a1c79c597452c3411fd823465c9482.patch</a><br>
<br>
<br>
<br>
<br>
------------------------------<br>
<br>
Message: 6<br>
Date: Mon, 23 Feb 2015 22:03:04 +0100<br>
From: Daniel-Constantin Mierla <<a href="mailto:miconda@gmail.com">miconda@gmail.com</a>><br>
To: <a href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a><br>
Subject: [sr-dev] git:4.2:e24c9ff7: sdpops: safety check when location<br>
a= line not to exceed end of message<br>
Message-ID: <<a href="mailto:E1YQ09g-0005dQ-Au@www.kamailio.org">E1YQ09g-0005dQ-Au@www.kamailio.org</a>><br>
<br>
Module: kamailio<br>
Branch: 4.2<br>
Commit: e24c9ff7038534e07682e8a7bafd903e4303590e<br>
URL: <a href="https://github.com/kamailio/kamailio/commit/e24c9ff7038534e07682e8a7bafd903e4303590e" target="_blank">https://github.com/kamailio/kamailio/commit/e24c9ff7038534e07682e8a7bafd903e4303590e</a><br>
<br>
Author: Daniel-Constantin Mierla <<a href="mailto:miconda@gmail.com">miconda@gmail.com</a>><br>
Committer: Daniel-Constantin Mierla <<a href="mailto:miconda@gmail.com">miconda@gmail.com</a>><br>
Date: 2015-02-23T22:02:51+01:00<br>
<br>
sdpops: safety check when location a= line not to exceed end of message<br>
<br>
(cherry picked from commit 91596953115fe1bbe5c6f0dd0dd6e8d99cdbd285)<br>
<br>
---<br>
<br>
Modified: modules/sdpops/sdpops_mod.c<br>
<br>
---<br>
<br>
Diff: <a href="https://github.com/kamailio/kamailio/commit/e24c9ff7038534e07682e8a7bafd903e4303590e.diff" target="_blank">https://github.com/kamailio/kamailio/commit/e24c9ff7038534e07682e8a7bafd903e4303590e.diff</a><br>
Patch: <a href="https://github.com/kamailio/kamailio/commit/e24c9ff7038534e07682e8a7bafd903e4303590e.patch" target="_blank">https://github.com/kamailio/kamailio/commit/e24c9ff7038534e07682e8a7bafd903e4303590e.patch</a><br>
<br>
---<br>
<br>
diff --git a/modules/sdpops/sdpops_mod.c b/modules/sdpops/sdpops_mod.c<br>
index 8717343..98c2f84 100644<br>
--- a/modules/sdpops/sdpops_mod.c<br>
+++ b/modules/sdpops/sdpops_mod.c<br>
@@ -156,12 +156,17 @@ static int mod_init(void)<br>
int sdp_locate_line(sip_msg_t* msg, char *pos, str *aline)<br>
{<br>
char *p;<br>
+ char *bend;<br>
+<br>
p = pos;<br>
while(*p!='\n') p--;<br>
aline->s = p + 1;<br>
p = pos;<br>
- while(*p!='\n') p++;<br>
+ bend = msg->buf+msg->len;<br>
+ while(*p!='\n' && p<bend) p++;<br>
aline->len = p - aline->s + 1;<br>
+ if(unlikely(p==bend)) aline->len--;<br>
+<br>
return 0;<br>
}<br>
<br>
<br>
<br>
<br>
<br>
------------------------------<br>
<br>
Message: 7<br>
Date: Mon, 23 Feb 2015 22:16:06 +0100<br>
From: Daniel-Constantin Mierla <<a href="mailto:miconda@gmail.com">miconda@gmail.com</a>><br>
To: Camille Oudot <<a href="mailto:camille.oudot@orange.com">camille.oudot@orange.com</a>>, sr-dev<br>
<<a href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a>><br>
Subject: [sr-dev] Issue after tcpops enhancement for lifetime per<br>
connection<br>
Message-ID: <<a href="mailto:54EB9896.1050101@gmail.com">54EB9896.1050101@gmail.com</a>><br>
Content-Type: text/plain; charset=utf-8<br>
<br>
Hi Camille,<br>
<br>
can you check and see what could have resulted in the issue reported on<br>
users mailing list referred in the next link?<br>
<br>
<a href="http://lists.sip-router.org/pipermail/sr-users/2015-February/087101.html" target="_blank">http://lists.sip-router.org/pipermail/sr-users/2015-February/087101.html</a><br>
<br>
There were couple of replies with some other details.<br>
<br>
Thanks,<br>
Daniel<br>
<br>
--<br>
Daniel-Constantin Mierla<br>
<a href="http://twitter.com/#!/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a><br>
Kamailio World Conference, May 27-29, 2015<br>
Berlin, Germany - <a href="http://www.kamailioworld.com" target="_blank">http://www.kamailioworld.com</a><br>
<br>
<br>
<br>
<br>
------------------------------<br>
<br>
Message: 8<br>
Date: Mon, 23 Feb 2015 22:18:01 +0100<br>
From: Daniel-Constantin Mierla <<a href="mailto:miconda@gmail.com">miconda@gmail.com</a>><br>
To: "Kamailio (SER) - Development Mailing List"<br>
<<a href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a>><br>
Subject: Re: [sr-dev] aastra outbound support<br>
Message-ID: <<a href="mailto:54EB9909.3030600@gmail.com">54EB9909.3030600@gmail.com</a>><br>
Content-Type: text/plain; charset="windows-1252"<br>
<br>
Hello,<br>
<br>
reg-id=0 is considered like no-outbound is advertised, so probaly no<br>
real outbound routing is done. If that's ok for you, then you can test a<br>
bit for side effects and keep the patch to run for you until aastra is<br>
fixing it.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
On 23/02/15 21:21, GG GG wrote:<br>
> Hi !<br>
><br>
> Aastra phone can support outbound (RFC 5626) but they put reg-id=0 in<br>
> the SIP REGISTER.<br>
><br>
> So the registrar server can't save the AOR and says "invalid reg-id<br>
> value". I know Aastra should change that for reg-id=1, I already<br>
> reported an issue but no feedback...<br>
><br>
> Finally I applied a patch in modules/registrar/save.c:<br>
><br>
> -- if(str2int(&_c->reg_id->body, &ci.reg_id)<0 || ci.reg_id==0)<br>
> ++ if(str2int(&_c->reg_id->body, &ci.reg_id)<0)<br>
> {<br>
> LM_ERR("invalid reg-id value\n");<br>
> goto error;<br>
> }<br>
><br>
> Do you think it's safe to do that ?<br>
><br>
> Thank you !<br>
><br>
><br>
> _______________________________________________<br>
> sr-dev mailing list<br>
> <a href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a><br>
> <a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
<br>
--<br>
Daniel-Constantin Mierla<br>
<a href="http://twitter.com/#!/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a><br>
Kamailio World Conference, May 27-29, 2015<br>
Berlin, Germany - <a href="http://www.kamailioworld.com" target="_blank">http://www.kamailioworld.com</a><br>
<br>
-------------- next part --------------<br>
An HTML attachment was scrubbed...<br>
URL: <<a href="http://lists.sip-router.org/pipermail/sr-dev/attachments/20150223/c69d9fd2/attachment-0001.html" target="_blank">http://lists.sip-router.org/pipermail/sr-dev/attachments/20150223/c69d9fd2/attachment-0001.html</a>><br>
<br>
------------------------------<br>
<br>
Message: 9<br>
Date: Mon, 23 Feb 2015 13:25:20 -0800<br>
From: Daniel-Constantin Mierla <<a href="mailto:notifications@github.com">notifications@github.com</a>><br>
To: Kamailio Devel List <<a href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a>><br>
Subject: Re: [sr-dev] [kamailio] registrar - additional features (#91)<br>
Message-ID: <kamailio/kamailio/pull/91/<a href="mailto:c75637132@github.com">c75637132@github.com</a>><br>
Content-Type: text/plain; charset="utf-8"<br>
<br>
A bit hard to follow, because now here are patches to patches to patches. Would be good to have a single patch against the master in kamailio for review.<br>
<br>
One thing I noticed, that some flags are still a module parameter. Wouldn't it be more flexible to be part of the function parameter, different flag values (eventually starting at 8 or 16)?<br>
<br>
---<br>
Reply to this email directly or view it on GitHub:<br>
<a href="https://github.com/kamailio/kamailio/pull/91#issuecomment-75637132" target="_blank">https://github.com/kamailio/kamailio/pull/91#issuecomment-75637132</a><br>
-------------- next part --------------<br>
An HTML attachment was scrubbed...<br>
URL: <<a href="http://lists.sip-router.org/pipermail/sr-dev/attachments/20150223/1e571a40/attachment.html" target="_blank">http://lists.sip-router.org/pipermail/sr-dev/attachments/20150223/1e571a40/attachment.html</a>><br>
<br>
------------------------------<br>
<br>
Subject: Digest Footer<br>
<br>
_______________________________________________<br>
sr-dev mailing list<br>
<a href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a><br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
<br>
<br>
------------------------------<br>
<br>
End of sr-dev Digest, Vol 76, Issue 83<br>
**************************************<br>
</blockquote></div><br></div></div></div>