<div dir="ltr">cool, will do now<br></div><br><div class="gmail_quote">On Fri, 20 Mar 2015 at 11:48 Daniel-Constantin Mierla <<a href="mailto:miconda@gmail.com">miconda@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
Hi Jason,<br>
<br>
go ahead and push the commit.<br>
<br>
Thanks,<br>
Daniel</div><div bgcolor="#FFFFFF" text="#000000"><br>
<br>
<div>On 20/03/15 10:41, Jason Penton wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hey Daniel,<br>
<br>
I have test with that setting restored so I suspect we may have
fixed it somewhere else. You can put it back or would you like
me to?
<div><br>
</div>
<div>Cheers</div>
<div>Jason</div>
</div>
<br>
<div class="gmail_quote">On Fri, 20 Mar 2015 at 10:40 Jason Penton
<<a href="mailto:jason.penton@gmail.com" target="_blank">jason.penton@gmail.com</a>>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Hey Daniel,<br>
<br>
can't remember but I am going to test it out just now. Will
have feedback soon</div>
<br>
<div class="gmail_quote">On Fri, 20 Mar 2015 at 10:28
Daniel-Constantin Mierla <<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> Hi Jason,<br>
<br>
thinking more about it, maybe the replies higher than
500 were not forwarded, given the algorithm to select
the winning reply. Can you remember more specifics from
the case that made you let the suspended branch open?<br>
<br>
Cheers,<br>
Daniel</div>
<div bgcolor="#FFFFFF" text="#000000"><br>
<br>
<div>On 20/03/15 09:07, Daniel-Constantin Mierla wrote:<br>
</div>
<blockquote type="cite"> Hi Jason,<br>
<br>
a t_relay() creates a new branch, so the replies
should be routed properly.<br>
<br>
Maybe there is something that needs to be fixed for
picked branch selection.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<div>On 20/03/15 08:58, Jason Penton wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hey Daniel,<br>
<br>
I added this code. My reasoning was because if you
set the blind uac to 500, for some reason replies
were not being forwarded after the t_relay (pick
branch was failing IIRC) run some tests and get
back to you. If I can restore I shall do so.
<div><br>
</div>
<div>Is that ok?</div>
<div><br>
</div>
<div>Cheers</div>
<div dir="ltr">
<div>Jason</div>
</div>
<br>
<div class="gmail_quote">On Fri, 20 Mar 2015 at
09:47 Daniel-Constantin Mierla <<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello Richard,<br>
<br>
with the commit 16e763c32d7a2b9fc451185e028a90b3be758f65
you removed the<br>
setting of last_received code for the branch
used for suspending the<br>
transaction (blind uac).<br>
<br>
You added some comments:<br>
<br>
+ /*we really don't need
this next line anymore<br>
otherwise we will<br>
+ never be able to
forward replies after a<br>
(t_relay) on this branch.<br>
+ We want to try and
treat this branch as 'normal'<br>
(as if it were a normal req, not async)' */<br>
+
//t->uac[branch].last_received=500;<br>
<br>
But a t_relay() will create a new uac/branch,
not reusing it.<br>
<br>
Do you have some specific use cases reusing
that suspended branch? If<br>
not, then I will revert the above change and
set the last_received to<br>
make the branch inactive. If yes, we have to
identify the case and set<br>
the last received for the rest.<br>
<br>
On a report from Alex Balashov with a crash,
the suspended branch is<br>
picked for handling cancel and apparently
messes some stuff. There is<br>
another active branch due to a t_relay() after
t_continue().<br>
<br>
Cheers,<br>
Daniel<br>
<br>
--<br>
Daniel-Constantin Mierla<br>
<a href="http://twitter.com/#%21/miconda" target="_blank">http://twitter.com/#!/miconda</a>
- <a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a><br>
Kamailio World Conference, May 27-29, 2015<br>
Berlin, Germany - <a href="http://www.kamailioworld.com" target="_blank">http://www.kamailioworld.com</a><br>
<br>
<br>
_______________________________________________<br>
sr-dev mailing list<br>
<a href="mailto:sr-dev@lists.sip-router.org" target="_blank">sr-dev@lists.sip-router.org</a><br>
<a href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
</blockquote>
</div>
</div>
</blockquote>
<br>
<pre cols="72">--
Daniel-Constantin Mierla
<a href="http://twitter.com/#%21/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a>
Kamailio World Conference, May 27-29, 2015
Berlin, Germany - <a href="http://www.kamailioworld.com" target="_blank">http://www.kamailioworld.com</a></pre>
</blockquote>
<br>
<pre cols="72">--
Daniel-Constantin Mierla
<a href="http://twitter.com/#%21/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a>
Kamailio World Conference, May 27-29, 2015
Berlin, Germany - <a href="http://www.kamailioworld.com" target="_blank">http://www.kamailioworld.com</a></pre>
</div>
</blockquote>
</div>
</blockquote>
</div>
</blockquote>
<br>
<pre cols="72">--
Daniel-Constantin Mierla
<a href="http://twitter.com/#!/miconda" target="_blank">http://twitter.com/#!/miconda</a> - <a href="http://www.linkedin.com/in/miconda" target="_blank">http://www.linkedin.com/in/miconda</a>
Kamailio World Conference, May 27-29, 2015
Berlin, Germany - <a href="http://www.kamailioworld.com" target="_blank">http://www.kamailioworld.com</a></pre>
</div></blockquote></div>