<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Hello Daniel,<br>
<br>
Thank you for your input. I will come with a second tested patch
tomorrow.<br>
<br>
<br>
On 04/16/2015 03:56 PM, Daniel-Constantin Mierla wrote:
<blockquote cite="mid:552FB198.7020800@gmail.com" type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
Hello,<br>
<br>
if I understood right, you want the calls that are cut after 30sec
(or so) because the ACK was not routed to be stored with duration
0, right? If yes, then it should be made configurable via module
parameter, with default of what was so far, because those calls
also cost money in most of the cases, being answered.<br>
<br>
As an extra note, I don't see a reason declare and to give the old
state as a string, should be given as the associated integer ID
(e.g., DLG_STATE_CONFIRMED) and compare params->dlg_data
casting to unsigned int.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<div class="moz-cite-prefix">On 16/04/15 11:51, Lucian Balaceanu
wrote:<br>
</div>
<blockquote cite="mid:552F8626.3090002@1and1.ro" type="cite"> Hi,<br>
<br>
I would like to propose a patch in which the dialog duration
displayed in the cdrs is:<br>
<i>0 -> timed-out not acknowledged dialogs <br>
duration from creation to timeout -> timed-out
acknowledged dialogs <br>
</i><br>
I am still testing the solution for the master branch while
tests pass on a previous version.<br>
Any comments on the code? (I am not particularly proud of the
string defines in the dlg_cb.h, but am unsure where to include
some const variable accessible to both acc and dialog to pass as
calback param for dialog expiration)<br>
<br>
Thank you,<br>
Lucian Balaceanu<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
sr-dev mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://twitter.com/#%21/miconda">http://twitter.com/#!/miconda</a> - <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a>
Kamailio World Conference, May 27-29, 2015
Berlin, Germany - <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://www.kamailioworld.com">http://www.kamailioworld.com</a></pre>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
sr-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a>
<a class="moz-txt-link-freetext" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a>
</pre>
</blockquote>
<br>
</body>
</html>