<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Hi,<br>
<br>
Please find attached the new patch. It is intended to trigger the
dialog duration computing when an acknowledged dialog times out.
(Non acknowledged dialogs are not considered). Previously, such
dialogs would not have a duration set on timeout. This is not
configurable. <br>
<br>
From an implementation point of view, the dialog duration computing
is triggered when the timeout takes place while the dialog is inside
a DLG_STATE_CONFIRMED state. I renounced at the string defines and
defined an int value inside a dlg_cb.h header accessible to both acc
and dialog module (didn't see fit to move the DLG_STATE_CONFIRMED
from the dlg_hash.h header to this one).<br>
<br>
Have a nice day,<br>
Lucian<br>
<br>
On 04/16/2015 06:57 PM, Lucian Balaceanu wrote:
<blockquote cite="mid:552FDBD2.7020007@1and1.ro" type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
Hello Daniel,<br>
<br>
Thank you for your input. I will come with a second tested patch
tomorrow.<br>
<br>
<br>
On 04/16/2015 03:56 PM, Daniel-Constantin Mierla wrote:
<blockquote cite="mid:552FB198.7020800@gmail.com" type="cite">
Hello,<br>
<br>
if I understood right, you want the calls that are cut after
30sec (or so) because the ACK was not routed to be stored with
duration 0, right? If yes, then it should be made configurable
via module parameter, with default of what was so far, because
those calls also cost money in most of the cases, being
answered.<br>
<br>
As an extra note, I don't see a reason declare and to give the
old state as a string, should be given as the associated integer
ID (e.g., DLG_STATE_CONFIRMED) and compare params->dlg_data
casting to unsigned int.<br>
<br>
Cheers,<br>
Daniel<br>
<br>
<div class="moz-cite-prefix">On 16/04/15 11:51, Lucian Balaceanu
wrote:<br>
</div>
<blockquote cite="mid:552F8626.3090002@1and1.ro" type="cite">
Hi,<br>
<br>
I would like to propose a patch in which the dialog duration
displayed in the cdrs is:<br>
<i>0 -> timed-out not acknowledged dialogs <br>
duration from creation to timeout -> timed-out
acknowledged dialogs <br>
</i><br>
I am still testing the solution for the master branch while
tests pass on a previous version.<br>
Any comments on the code? (I am not particularly proud of the
string defines in the dlg_cb.h, but am unsure where to include
some const variable accessible to both acc and dialog to pass
as calback param for dialog expiration)<br>
<br>
Thank you,<br>
Lucian Balaceanu<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
sr-dev mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a>
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Daniel-Constantin Mierla
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://twitter.com/#%21/miconda">http://twitter.com/#!/miconda</a> - <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://www.linkedin.com/in/miconda">http://www.linkedin.com/in/miconda</a>
Kamailio World Conference, May 27-29, 2015
Berlin, Germany - <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://www.kamailioworld.com">http://www.kamailioworld.com</a></pre>
<pre wrap=""><fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
sr-dev mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:sr-dev@lists.sip-router.org">sr-dev@lists.sip-router.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev">http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev</a>
</pre>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>