<p>This patch helps us to handle inadequatness of Linphone mobile apps (both iOS and Android flavours are affected) without reinventing a lot of logics to handle each transport (we use TCP, TLS, WS, WSS).<br>
E.g. if we have two TLS-based Linphone clients, even with enable_double_rr for gentle cross-forwarding we would get single RR header without transport= attribute, resulting in Linphone sending ACK and BYE via UDP.<br>
This new option, being enabled, results in two RR headers being always inserted, with transport attribute being always added. I believe this cannot harm the installation with enable_double_rr, just makes instructions more explicit.<br>
The Linphone's behaviour looks like a set of different bugs, but it would get us much more efforts to fix.<br>
I don't know if any other useragent needs such workaround. So I would perfectly understand if this commit wouldn't be accepted upstream.</p>
<p>Also this commit currently lacks README doc rebuild, because I don't know how to do that. Only XML doc is updated.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/257'>https://github.com/kamailio/kamailio/pull/257</a></p>
<h4>Commit Summary</h4>
<ul>
<li>rr: add enable_double_rr_always option</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/257/files#diff-0">modules/rr/doc/rr_admin.xml</a>
(24)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/257/files#diff-1">modules/rr/record.c</a>
(14)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/257/files#diff-2">modules/rr/rr_mod.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/257/files#diff-3">modules/rr/rr_mod.h</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/257/files#diff-4">tcp_read.c</a>
(5)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/257.patch'>https://github.com/kamailio/kamailio/pull/257.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/257.diff'>https://github.com/kamailio/kamailio/pull/257.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>Reply to this email directly or <a href="https://github.com/kamailio/kamailio/pull/257">view it on GitHub</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36ZdiO4F-iuKLy5WqGHGY4Fj2AssQEks5ofQyTgaJpZM4FcCRG.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/kamailio/kamailio/pull/257"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>