<p>Complete re-implementation of sdp_remove_line_by_prefix(), maybe reviewing by diff does not make sense.<br>
Also feedback is on unit test is welcome as I have not created such for Kamailio earlier.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/522'>https://github.com/kamailio/kamailio/pull/522</a></p>
<h4>Commit Summary</h4>
<ul>
<li>modules/sdpops: reimplement sdp_remove_line_by_prefix() to fix shortcomings</li>
<li>test/unit: add unit test for sdpops script function sdp_remove_line_by_prefix()</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/522/files#diff-0">modules/sdpops/sdpops_mod.c</a>
(118)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/kamailio/kamailio/pull/522/files#diff-1">test/unit/60-message-sdp0.sip</a>
(18)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/kamailio/kamailio/pull/522/files#diff-2">test/unit/60-message-sdp1.sip</a>
(18)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/kamailio/kamailio/pull/522/files#diff-3">test/unit/60-message-sdp2.sip</a>
(19)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/kamailio/kamailio/pull/522/files#diff-4">test/unit/60-message-sdp3.sip</a>
(19)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/kamailio/kamailio/pull/522/files#diff-5">test/unit/60-message-sdp4.sip</a>
(20)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/kamailio/kamailio/pull/522/files#diff-6">test/unit/60-message-sdp5.sip</a>
(20)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/kamailio/kamailio/pull/522/files#diff-7">test/unit/60-message-sdp6.sip</a>
(20)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/kamailio/kamailio/pull/522/files#diff-8">test/unit/60-message-sdp7.sip</a>
(19)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/kamailio/kamailio/pull/522/files#diff-9">test/unit/60.cfg</a>
(41)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/kamailio/kamailio/pull/522/files#diff-10">test/unit/60.sh</a>
(75)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/kamailio/kamailio/pull/522/files#diff-11">test/unit/include/require.sh</a>
(65)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/522.patch'>https://github.com/kamailio/kamailio/pull/522.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/522.diff'>https://github.com/kamailio/kamailio/pull/522.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>Reply to this email directly or <a href="https://github.com/kamailio/kamailio/pull/522">view it on GitHub</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36ZfFz5D9rzjKnWlnseRR1y2UqTtVSks5pov2qgaJpZM4HleHI.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/kamailio/kamailio/pull/522"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>