<pre><code>CC (clang38) [M ims_dialog.so] dlg_hash.o
dlg_hash.c:674:37: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
if ((d_entry_out->first == d_entry_out->last)) {
~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
dlg_hash.c:674:37: note: remove extraneous parentheses around the comparison to silence this warning
if ((d_entry_out->first == d_entry_out->last)) {
~ ^ ~
dlg_hash.c:674:37: note: use '=' to turn this equality comparison into an assignment
if ((d_entry_out->first == d_entry_out->last)) {
^~
=
CC (clang38) [M ims_qos.so] rx_avp.o
rx_avp.c:492:16: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]
if (bandwidth >= 0) {
~~~~~~~~~ ^ ~
rx_avp.c:504:16: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]
if (bandwidth >= 0) {
~~~~~~~~~ ^ ~
CC (clang38) [M ims_registrar_scscf.so] save.o
save.c:114:21: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]
if (expires_hdr >= 0)
~~~~~~~~~~~ ^ ~
</code></pre>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/637'>https://github.com/kamailio/kamailio/pull/637</a></p>
<h4>Commit Summary</h4>
<ul>
<li>modules/ims_auth lib/ims: use header type instead of header flag</li>
<li>modules/ims_qos modules/ims_registrar_scscf: fix comparison of unsigned expression</li>
<li>modules/ims_dialog: fix clang warning -Wparentheses-equality</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/637/files#diff-0">lib/ims/ims_getters.c</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/637/files#diff-1">modules/ims_auth/utils.c</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/637/files#diff-2">modules/ims_dialog/dlg_hash.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/637/files#diff-3">modules/ims_qos/rx_avp.c</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/637/files#diff-4">modules/ims_registrar_scscf/save.c</a>
(2)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/637.patch'>https://github.com/kamailio/kamailio/pull/637.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/637.diff'>https://github.com/kamailio/kamailio/pull/637.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly or <a href="https://github.com/kamailio/kamailio/pull/637">view it on GitHub</a><img alt="" height="1" src="https://github.com/notifications/beacon/AF36ZdG9loQVGjPIk-Ubr_Bbdz8LfmT4ks5qFDIQgaJpZM4Imb2Y.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/kamailio/kamailio/pull/637"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>